Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ios/chrome/browser/tabs/tab.mm

Issue 2919983002: Remove Tab's |-url| property. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/tabs/tab.h ('k') | ios/chrome/browser/ui/browser_view_controller_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/tabs/tab.mm
diff --git a/ios/chrome/browser/tabs/tab.mm b/ios/chrome/browser/tabs/tab.mm
index ebede094dd0fdd03631114b465343fc450e47625..02a6e5223b3406acf0d20f905cd4cce04c3afacf 100644
--- a/ios/chrome/browser/tabs/tab.mm
+++ b/ios/chrome/browser/tabs/tab.mm
@@ -590,13 +590,6 @@ - (void)retrieveSnapshot:(void (^)(UIImage*))callback {
callback:callback];
}
-- (const GURL&)url {
- // See note in header; this method should be removed.
- web::NavigationItem* item =
- [self navigationManagerImpl]->GetSessionController().currentItem;
- return item ? item->GetVirtualURL() : GURL::EmptyGURL();
-}
-
- (const GURL&)lastCommittedURL {
web::NavigationItem* item = self.navigationManager->GetLastCommittedItem();
return item ? item->GetVirtualURL() : GURL::EmptyGURL();
« no previous file with comments | « ios/chrome/browser/tabs/tab.h ('k') | ios/chrome/browser/ui/browser_view_controller_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698