Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Side by Side Diff: ios/chrome/browser/tabs/tab.h

Issue 2919983002: Remove Tab's |-url| property. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef IOS_CHROME_BROWSER_TABS_TAB_H_ 5 #ifndef IOS_CHROME_BROWSER_TABS_TAB_H_
6 #define IOS_CHROME_BROWSER_TABS_TAB_H_ 6 #define IOS_CHROME_BROWSER_TABS_TAB_H_
7 7
8 #import <UIKit/UIKit.h> 8 #import <UIKit/UIKit.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 // Information related to a single tab. The CRWWebController is similar to 94 // Information related to a single tab. The CRWWebController is similar to
95 // desktop Chrome's TabContents in that it encapsulates rendering. Acts as the 95 // desktop Chrome's TabContents in that it encapsulates rendering. Acts as the
96 // delegate for the CRWWebController in order to process info about pages having 96 // delegate for the CRWWebController in order to process info about pages having
97 // loaded. 97 // loaded.
98 @interface Tab 98 @interface Tab
99 : NSObject<CRWWebDelegate, ManageAccountsDelegate, SadTabTabHelperDelegate> 99 : NSObject<CRWWebDelegate, ManageAccountsDelegate, SadTabTabHelperDelegate>
100 100
101 // Browser state associated with this Tab. 101 // Browser state associated with this Tab.
102 @property(nonatomic, readonly) ios::ChromeBrowserState* browserState; 102 @property(nonatomic, readonly) ios::ChromeBrowserState* browserState;
103 103
104 // TODO(crbug.com/546208): Eliminate this; replace calls with either visible URL
105 // or last committed URL, depending on the specific use case.
106 // Do not add new calls to this method.
107 @property(nonatomic, readonly) const GURL& url;
108
109 // Returns the URL of the last committed NavigationItem for this Tab. 104 // Returns the URL of the last committed NavigationItem for this Tab.
110 @property(nonatomic, readonly) const GURL& lastCommittedURL; 105 @property(nonatomic, readonly) const GURL& lastCommittedURL;
111 106
112 // Returns the URL of the visible NavigationItem for this Tab. 107 // Returns the URL of the visible NavigationItem for this Tab.
113 @property(nonatomic, readonly) const GURL& visibleURL; 108 @property(nonatomic, readonly) const GURL& visibleURL;
114 109
115 // The Passkit Dialog provider used to show the UI to download a passkit object. 110 // The Passkit Dialog provider used to show the UI to download a passkit object.
116 @property(nonatomic, weak) id<PassKitDialogProvider> passKitDialogProvider; 111 @property(nonatomic, weak) id<PassKitDialogProvider> passKitDialogProvider;
117 112
118 // The current title of the tab. 113 // The current title of the tab.
(...skipping 182 matching lines...) Expand 10 before | Expand all | Expand 10 after
301 // Evaluates U2F result. 296 // Evaluates U2F result.
302 - (void)evaluateU2FResultFromURL:(const GURL&)url; 297 - (void)evaluateU2FResultFromURL:(const GURL&)url;
303 298
304 // Cancels prerendering. It is an error to call this on anything except a 299 // Cancels prerendering. It is an error to call this on anything except a
305 // prerender tab (where |isPrerenderTab| is set to YES). 300 // prerender tab (where |isPrerenderTab| is set to YES).
306 - (void)discardPrerender; 301 - (void)discardPrerender;
307 302
308 @end 303 @end
309 304
310 #endif // IOS_CHROME_BROWSER_TABS_TAB_H_ 305 #endif // IOS_CHROME_BROWSER_TABS_TAB_H_
OLDNEW
« no previous file with comments | « ios/chrome/browser/metrics/tab_usage_recorder_unittest.mm ('k') | ios/chrome/browser/tabs/tab.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698