Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: ios/chrome/browser/ui/browser_view_controller_unittest.mm

Issue 2919983002: Remove Tab's |-url| property. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/tabs/tab.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/browser_view_controller_unittest.mm
diff --git a/ios/chrome/browser/ui/browser_view_controller_unittest.mm b/ios/chrome/browser/ui/browser_view_controller_unittest.mm
index 162e3c5e2f05d82db18c8f7f51247080bfc0f203..1d274ef776b77d36ba4b4bb0edf9ebb859a42774 100644
--- a/ios/chrome/browser/ui/browser_view_controller_unittest.mm
+++ b/ios/chrome/browser/ui/browser_view_controller_unittest.mm
@@ -82,13 +82,11 @@ - (IBAction)chromeExecuteCommand:(id)sender;
@end
@interface BVCTestTabMock : OCMockComplexTypeHelper {
- GURL _url;
GURL _lastCommittedURL;
GURL _visibleURL;
WebStateImpl* _webState;
}
-@property(nonatomic, assign) const GURL& url;
@property(nonatomic, assign) const GURL& lastCommittedURL;
@property(nonatomic, assign) const GURL& visibleURL;
@property(nonatomic, assign) WebStateImpl* webState;
@@ -99,12 +97,6 @@ @interface BVCTestTabMock : OCMockComplexTypeHelper {
@end
@implementation BVCTestTabMock
-- (const GURL&)url {
- return _url;
-}
-- (void)setUrl:(const GURL&)url {
- _url = url;
-}
- (const GURL&)lastCommittedURL {
return _lastCommittedURL;
}
@@ -438,7 +430,6 @@ void TearDown() override {
TEST_F(BrowserViewControllerTest, TestSharePageCommandHandling) {
GURL expectedUrl("http://www.testurl.net");
NSString* expectedTitle = @"title";
- static_cast<BVCTestTabMock*>(tab_.get()).url = expectedUrl;
static_cast<BVCTestTabMock*>(tab_.get()).lastCommittedURL = expectedUrl;
static_cast<BVCTestTabMock*>(tab_.get()).visibleURL = expectedUrl;
OCMockObject* tabMock = static_cast<OCMockObject*>(tab_.get());
@@ -489,7 +480,6 @@ void TearDown() override {
NSString* expectedTitle = @"title";
// Sets WebState to nil because [tab close] clears the WebState.
static_cast<BVCTestTabMock*>(tab_.get()).webState = nil;
- static_cast<BVCTestTabMock*>(tab_.get()).url = expectedUrl;
static_cast<BVCTestTabMock*>(tab_.get()).lastCommittedURL = expectedUrl;
static_cast<BVCTestTabMock*>(tab_.get()).visibleURL = expectedUrl;
OCMockObject* tabMock = static_cast<OCMockObject*>(tab_.get());
« no previous file with comments | « ios/chrome/browser/tabs/tab.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698