[DMC #25] Make DocumentMarker::GetType() virtual

Make DocumentMarker::GetType() virtual

Now that we have subclasses of DocumentMarker for all the different MarkerTypes,
we can make GetType() a virtual method on each of the subtypes so we don't
actually have to store a field in DocumentMarker for this information.

BUG=707867
Review-Url: https://codereview.chromium.org/2911733002
Cr-Commit-Position: refs/heads/master@{#476473}
Committed: https://chromium.googlesource.com/chromium/src/+/adb3fe930f151b63798729d3e43f37f6097a7875

[rlanday, 2017-05-26 20:34:50]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[rlanday, 2017-05-26 20:35:07]

rlanday@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yosin@chromium.org

[commit-bot: I haz the power, 2017-05-26 20:35:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 20:38:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 20:38:14]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[rlanday, 2017-05-26 21:46:57]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 21:47:36]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 22:28:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 22:28:39]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[yosin_UTC9, 2017-05-29 05:17:09]

https://codereview.chromium.org/2911733002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/markers/CompositionMarker.h (right):

https://codereview.chromium.org/2911733002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/markers/CompositionMarker.h:26:
MarkerType GetType() const;
nit: s/;/final ;/

https://codereview.chromium.org/2911733002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/markers/GrammarMarker.h (right):

https://codereview.chromium.org/2911733002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/markers/GrammarMarker.h:19: MarkerType
GetType() const;
nit: s/;/final ;/

https://codereview.chromium.org/2911733002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/markers/SpellingMarker.h (right):

https://codereview.chromium.org/2911733002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/markers/SpellingMarker.h:19: MarkerType
GetType() const;
nit: s/;/final ;/

https://codereview.chromium.org/2911733002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/markers/TextMatchMarker.h (right):

https://codereview.chromium.org/2911733002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/markers/TextMatchMarker.h:54: MarkerType
GetType() const { return DocumentMarker::kTextMatch; }
We have an implementation of interface in ".cpp" file.

See "Stop inlining virtual methods" in
https://www.chromium.org/developers/coding-style/cpp-dos-and-donts

[rlanday, 2017-06-01 05:13:16]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[rlanday, 2017-06-01 05:13:20]

Updated

[commit-bot: I haz the power, 2017-06-01 05:13:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-06-01 05:49:01]

lgtm

https://codereview.chromium.org/2911733002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/markers/TextMatchMarker.h (right):

https://codereview.chromium.org/2911733002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/markers/TextMatchMarker.h:46:
TextMatchMarker(unsigned start_offset,
In following patch, could you move inline functions in |TextMatchMarker| class
to "TextMatchMaker.cpp"?
Because of they are not performance sensitive, and we want to have small header
file for fast compilation.

[commit-bot: I haz the power, 2017-06-01 06:22:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 06:22:55]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[rlanday, 2017-06-01 18:15:55]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-01 18:16:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rlanday, 2017-06-01 20:43:30]

The CQ bit was unchecked by rlanday@chromium.org

[rlanday, 2017-06-01 20:43:33]

The CQ bit was checked by rlanday@chromium.org

[rlanday, 2017-06-01 20:43:33]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2911733002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2017-06-01 20:44:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 23:12:49]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1496349813225390,
"parent_rev": "f5f0bccb0526f845360270c68cdaf0aa991a8ed5", "commit_rev":
"adb3fe930f151b63798729d3e43f37f6097a7875"}

[commit-bot: I haz the power, 2017-06-01 23:12:59]

Description was changed from

==========
Make DocumentMarker::GetType() virtual

Now that we have subclasses of DocumentMarker for all the different MarkerTypes,
we can make GetType() a virtual method on each of the subtypes so we don't
actually have to store a field in DocumentMarker for this information.

BUG=707867
==========

to

==========
Make DocumentMarker::GetType() virtual

Now that we have subclasses of DocumentMarker for all the different MarkerTypes,
we can make GetType() a virtual method on each of the subtypes so we don't
actually have to store a field in DocumentMarker for this information.

BUG=707867

Review-Url: https://codereview.chromium.org/2911733002
Cr-Commit-Position: refs/heads/master@{#476473}
Committed:
https://chromium.googlesource.com/chromium/src/+/adb3fe930f151b63798729d3e43f...
==========

[commit-bot: I haz the power, 2017-06-01 23:13:01]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/adb3fe930f151b63798729d3e43f...