Add CompositionMarker::Thickness enum
This CL changes CompositionMarker to take and store its thickness param as an
enum instead of a bool. This makes code creating CompositionMarkers easier to
understand (and also enables us to add additional thickness values in the future
if necessary).
BUG=707867
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Review-Url: https://codereview.chromium.org/2906953002
Cr-Commit-Position: refs/heads/master@{#476509}
Committed: https://chromium.googlesource.com/chromium/src/+/7fd1b84241b9f5fb8f43842317a722a0e8243b46
Description was changed from ========== Add CompositionMarker::Thickness enum This CL changes CompositionMarker to take and ...
3 years, 7 months ago
(2017-05-26 22:34:41 UTC)
#1
Description was changed from
==========
Add CompositionMarker::Thickness enum
This CL changes CompositionMarker to take and store its thickness param as an
enum instead of a bool. This makes code creating CompositionMarkers easier to
understand (and also enables us to add additional thickness values in the future
if necessary).
BUG=707867
==========
to
==========
Add CompositionMarker::Thickness enum
This CL changes CompositionMarker to take and store its thickness param as an
enum instead of a bool. This makes code creating CompositionMarkers easier to
understand (and also enables us to add additional thickness values in the future
if necessary).
BUG=707867
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========
rlanday
Description was changed from ========== Add CompositionMarker::Thickness enum This CL changes CompositionMarker to take and ...
3 years, 7 months ago
(2017-05-26 22:34:52 UTC)
#2
Description was changed from
==========
Add CompositionMarker::Thickness enum
This CL changes CompositionMarker to take and store its thickness param as an
enum instead of a bool. This makes code creating CompositionMarkers easier to
understand (and also enables us to add additional thickness values in the future
if necessary).
BUG=707867
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========
to
==========
Add CompositionMarker::Thickness enum
This CL changes CompositionMarker to take and store its thickness param as an
enum instead of a bool. This makes code creating CompositionMarkers easier to
understand (and also enables us to add additional thickness values in the future
if necessary).
BUG=707867
==========
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/277482)
3 years, 7 months ago
(2017-05-26 23:57:59 UTC)
#8
https://codereview.chromium.org/2906953002/diff/1/third_party/WebKit/Source/core/testing/Internals.cpp File third_party/WebKit/Source/core/testing/Internals.cpp (right): https://codereview.chromium.org/2906953002/diff/1/third_party/WebKit/Source/core/testing/Internals.cpp#newcode1071 third_party/WebKit/Source/core/testing/Internals.cpp:1071: if (EqualIgnoringASCIICase(thickness, "kThin")) Let's use "thin" and "thick" as ...
3 years, 6 months ago
(2017-05-29 05:22:08 UTC)
#9
Description was changed from ========== Add CompositionMarker::Thickness enum This CL changes CompositionMarker to take and ...
3 years, 6 months ago
(2017-06-01 05:18:30 UTC)
#10
Description was changed from
==========
Add CompositionMarker::Thickness enum
This CL changes CompositionMarker to take and store its thickness param as an
enum instead of a bool. This makes code creating CompositionMarkers easier to
understand (and also enables us to add additional thickness values in the future
if necessary).
BUG=707867
==========
to
==========
Add CompositionMarker::Thickness enum
This CL changes CompositionMarker to take and store its thickness param as an
enum instead of a bool. This makes code creating CompositionMarkers easier to
understand (and also enables us to add additional thickness values in the future
if necessary).
BUG=707867
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========
rlanday
The CQ bit was checked by rlanday@chromium.org to run a CQ dry run
3 years, 6 months ago
(2017-06-01 05:18:33 UTC)
#11
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/280347)
3 years, 6 months ago
(2017-06-01 06:30:04 UTC)
#18
CQ is committing da patch. Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496365445314390, "parent_rev": "48496eefc2ca8dc673daf4eff0d45a0822489ebf", "commit_rev": "7fd1b84241b9f5fb8f43842317a722a0e8243b46"}
3 years, 6 months ago
(2017-06-02 01:10:07 UTC)
#26
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496365445314390,
"parent_rev": "48496eefc2ca8dc673daf4eff0d45a0822489ebf", "commit_rev":
"7fd1b84241b9f5fb8f43842317a722a0e8243b46"}
commit-bot: I haz the power
Description was changed from ========== Add CompositionMarker::Thickness enum This CL changes CompositionMarker to take and ...
3 years, 6 months ago
(2017-06-02 01:10:15 UTC)
#27
Message was sent while issue was closed.
Description was changed from
==========
Add CompositionMarker::Thickness enum
This CL changes CompositionMarker to take and store its thickness param as an
enum instead of a bool. This makes code creating CompositionMarkers easier to
understand (and also enables us to add additional thickness values in the future
if necessary).
BUG=707867
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========
to
==========
Add CompositionMarker::Thickness enum
This CL changes CompositionMarker to take and store its thickness param as an
enum instead of a bool. This makes code creating CompositionMarkers easier to
understand (and also enables us to add additional thickness values in the future
if necessary).
BUG=707867
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Review-Url: https://codereview.chromium.org/2906953002
Cr-Commit-Position: refs/heads/master@{#476509}
Committed:
https://chromium.googlesource.com/chromium/src/+/7fd1b84241b9f5fb8f43842317a7...
==========
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/7fd1b84241b9f5fb8f43842317a722a0e8243b46
3 years, 6 months ago
(2017-06-02 01:10:16 UTC)
#28
Issue 2906953002: [DMC #26] Add CompositionMarker::Thickness enum
(Closed)
Created 3 years, 7 months ago by rlanday
Modified 3 years, 6 months ago
Reviewers: tkent, Xiaocheng, yosin_UTC9
Base URL:
Comments: 2