Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Issue 2906953002: [DMC #26] Add CompositionMarker::Thickness enum (Closed)

Created:
3 years, 7 months ago by rlanday
Modified:
3 years, 6 months ago
Reviewers:
tkent, yosin_UTC9, Xiaocheng
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add CompositionMarker::Thickness enum This CL changes CompositionMarker to take and store its thickness param as an enum instead of a bool. This makes code creating CompositionMarkers easier to understand (and also enables us to add additional thickness values in the future if necessary). BUG=707867 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2906953002 Cr-Commit-Position: refs/heads/master@{#476509} Committed: https://chromium.googlesource.com/chromium/src/+/7fd1b84241b9f5fb8f43842317a722a0e8243b46

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase, change enum #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -37 lines) Patch
M third_party/WebKit/LayoutTests/editing/composition-marker-basic.html View 1 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/composition-marker-split.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/InputMethodController.cpp View 1 2 chunks +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/markers/CompositionMarker.h View 1 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/markers/CompositionMarker.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/markers/CompositionMarkerListImplTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/markers/CompositionMarkerTest.cpp View 1 2 1 chunk +9 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp View 1 1 chunk +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 2 chunks +21 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.idl View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 28 (21 generated)
rlanday
3 years, 7 months ago (2017-05-26 22:36:57 UTC) #6
yosin_UTC9
https://codereview.chromium.org/2906953002/diff/1/third_party/WebKit/Source/core/testing/Internals.cpp File third_party/WebKit/Source/core/testing/Internals.cpp (right): https://codereview.chromium.org/2906953002/diff/1/third_party/WebKit/Source/core/testing/Internals.cpp#newcode1071 third_party/WebKit/Source/core/testing/Internals.cpp:1071: if (EqualIgnoringASCIICase(thickness, "kThin")) Let's use "thin" and "thick" as ...
3 years, 6 months ago (2017-05-29 05:22:08 UTC) #9
rlanday
Updated
3 years, 6 months ago (2017-06-01 05:18:49 UTC) #13
yosin_UTC9
lgtm +tkent@ for core/testing/Internals.{cpp,idl}
3 years, 6 months ago (2017-06-01 05:50:29 UTC) #15
tkent
lgtm
3 years, 6 months ago (2017-06-01 06:01:44 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2906953002/40001
3 years, 6 months ago (2017-06-02 01:04:51 UTC) #25
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 01:10:16 UTC) #28
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7fd1b84241b9f5fb8f43842317a7...

Powered by Google App Engine
This is Rietveld 408576698