Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarker.h

Issue 2911733002: [DMC #25] Make DocumentMarker::GetType() virtual (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/markers/DocumentMarker.h
diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarker.h b/third_party/WebKit/Source/core/editing/markers/DocumentMarker.h
index 0ab8fa70cacfa8eb0be4e25c14c10c2ffe7d4316..7440daed779ea1447807be2a830ffb9f78ff13a0 100644
--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarker.h
+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarker.h
@@ -129,7 +129,7 @@ class CORE_EXPORT DocumentMarker
virtual ~DocumentMarker();
- MarkerType GetType() const { return type_; }
+ virtual MarkerType GetType() const = 0;
unsigned StartOffset() const { return start_offset_; }
unsigned EndOffset() const { return end_offset_; }
@@ -151,10 +151,9 @@ class CORE_EXPORT DocumentMarker
DEFINE_INLINE_VIRTUAL_TRACE() {}
protected:
- DocumentMarker(MarkerType, unsigned start_offset, unsigned end_offset);
+ DocumentMarker(unsigned start_offset, unsigned end_offset);
private:
- const MarkerType type_;
unsigned start_offset_;
unsigned end_offset_;

Powered by Google App Engine
This is Rietveld 408576698