third_party/WebKit/Source/core/editing/markers/CompositionMarker.cpp - Issue 2911733002: [DMC #25] Make DocumentMarker::GetType() virtual

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/markers/CompositionMarker.cpp

Issue 2911733002: [DMC #25] Make DocumentMarker::GetType() virtual (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/markers/CompositionMarker.h ('k') | third_party/WebKit/Source/core/editing/markers/DocumentMarker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/markers/CompositionMarker.cpp

diff --git a/third_party/WebKit/Source/core/editing/markers/CompositionMarker.cpp b/third_party/WebKit/Source/core/editing/markers/CompositionMarker.cpp

index f445f502b496b4608790cf16e0b725f2a00e337a..f24217de7f541dce3e5b7f93a3ee73c419df9682 100644

--- a/third_party/WebKit/Source/core/editing/markers/CompositionMarker.cpp

+++ b/third_party/WebKit/Source/core/editing/markers/CompositionMarker.cpp

@@ -11,11 +11,15 @@ CompositionMarker::CompositionMarker(unsigned start_offset,

Color underline_color,

bool thick,

Color background_color)

- : DocumentMarker(DocumentMarker::kComposition, start_offset, end_offset),

+ : DocumentMarker(start_offset, end_offset),

underline_color_(underline_color),

background_color_(background_color),

thick_(thick) {}

+DocumentMarker::MarkerType CompositionMarker::GetType() const {

+ return DocumentMarker::kComposition;

Color CompositionMarker::UnderlineColor() const {

return underline_color_;

}