[DMC #25] Make DocumentMarker::GetType() virtual

third_party/WebKit/Source/core/editing/markers/TextMatchMarker.h

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Neither the name of Google Inc. nor the names of its
@@ skipping 28 matching lines @@
 class TextMatchMarker final : public DocumentMarker {
  private:
   enum class State { kInvalid, kValidNull, kValidNotNull };
 
  public:
   enum class MatchStatus { kInactive, kActive };
 
   TextMatchMarker(unsigned start_offset,
                   unsigned end_offset,
                   MatchStatus status)
-      : DocumentMarker(DocumentMarker::kTextMatch, start_offset, end_offset),
+      : DocumentMarker(start_offset, end_offset),
         match_status_(status),
         layout_state_(State::kInvalid) {}
 
+  // DocumentMarker implementations
+  MarkerType GetType() const { return DocumentMarker::kTextMatch; }

[yosin_UTC9, 2017/05/29 05:17:09]

We have an implementation of interface in ".cpp" file.

See "Stop inlining virtual methods" in
https://www.chromium.org/developers/coding-style/cpp-dos-and-donts

+
+  // TextMatchMarker-specific
   bool IsActiveMatch() const { return match_status_ == MatchStatus::kActive; }
   void SetIsActiveMatch(bool active) {
     match_status_ = active ? MatchStatus::kActive : MatchStatus::kInactive;
   }
 
   bool IsRendered() const { return layout_state_ == State::kValidNotNull; }
   bool Contains(const LayoutPoint& point) const {
     DCHECK_EQ(layout_state_, State::kValidNotNull);
     return rendered_rect_.Contains(point);
   }
@@ skipping 27 matching lines @@
 
 DEFINE_TYPE_CASTS(TextMatchMarker,
                   DocumentMarker,
                   marker,
                   marker->GetType() == DocumentMarker::kTextMatch,
                   marker.GetType() == DocumentMarker::kTextMatch);
 
 }  // namespace blink
 
 #endif