third_party/WebKit/Source/core/editing/markers/DocumentMarker.cpp - Issue 2911733002: [DMC #25] Make DocumentMarker::GetType() virtual

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarker.cpp

Issue 2911733002: [DMC #25] Make DocumentMarker::GetType() virtual (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/markers/DocumentMarker.cpp

diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarker.cpp b/third_party/WebKit/Source/core/editing/markers/DocumentMarker.cpp

index 7ecc32224ae3bf05816778252de2839a07336709..3a43d7aac9e359e6ee133db770829398a36ded9c 100644

--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarker.cpp

+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarker.cpp

@@ -37,10 +37,8 @@ namespace blink {

DocumentMarker::~DocumentMarker() = default;

-DocumentMarker::DocumentMarker(MarkerType type,

- unsigned start_offset,

- unsigned end_offset)

- : type_(type), start_offset_(start_offset), end_offset_(end_offset) {

+DocumentMarker::DocumentMarker(unsigned start_offset, unsigned end_offset)

+ : start_offset_(start_offset), end_offset_(end_offset) {

DCHECK_LT(start_offset_, end_offset_);

}