Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2909943003: Removing useless Win7 checks + standardize its use (Closed)

Created:
3 years, 6 months ago by Patrick Monette
Modified:
3 years, 6 months ago
CC:
chromium-reviews, vmpstr+watch_chromium.org, posciak+watch_chromium.org, chfremer+watch_chromium.org, pennymac+watch_chromium.org, mfoltz+watch_chromium.org, miu+watch_chromium.org, tapted, Matt Giuca, grt+watch_chromium.org, chromoting-reviews_chromium.org, jam, darin-cc_chromium.org, xjz+watch_chromium.org, vabr+watchlistpasswordmanager_chromium.org, timvolodine, feature-media-reviews_chromium.org, asvitkine+watch_chromium.org, mlamouri+watch-sensors_chromium.org, piman+watch_chromium.org, gcasto+watchlist_chromium.org, David Trainor- moved to gerrit, wfh+watch_chromium.org, phoglund+watch_chromium.org, dtapuska+chromiumwatch_chromium.org, riju_, danakj+watch_chromium.org, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing useless Win7 checks + standardize its use For example, if the comment mention Win8+, the check will be base::win::GetVersion() >= base::win::VERSION_WIN8. BUG=579196 Review-Url: https://codereview.chromium.org/2909943003 Cr-Commit-Position: refs/heads/master@{#476823} Committed: https://chromium.googlesource.com/chromium/src/+/dddfcf1b9e97593f1321a6744a37e91e8a32d7ab

Patch Set 1 #

Patch Set 2 : Small fix #

Patch Set 3 : merge #

Patch Set 4 : Remove unused function #

Patch Set 5 : fix small clang error #

Patch Set 6 : Remove unused function #

Patch Set 7 : Remove unused function #

Patch Set 8 : Fix unreachable code #

Total comments: 2

Patch Set 9 : Rebase #

Patch Set 10 : Fix reversed conditionnal #

Total comments: 12

Patch Set 11 : Various nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -467 lines) Patch
M base/files/file_enumerator_win.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +8 lines, -13 lines 0 comments Download
M base/path_service_unittest.cc View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M base/test/test_shortcut_win.cc View 2 chunks +34 lines, -37 lines 0 comments Download
M base/win/shortcut.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -0 lines 0 comments Download
M base/win/shortcut.cc View 4 chunks +4 lines, -13 lines 0 comments Download
M base/win/shortcut_unittest.cc View 4 chunks +5 lines, -11 lines 0 comments Download
M chrome/browser/download/download_status_updater_win.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/media/webrtc/webrtc_audio_quality_browsertest.cc View 1 2 3 4 5 6 7 8 9 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/media/webrtc/webrtc_browsertest_base.h View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/media/webrtc/webrtc_browsertest_base.cc View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/password_manager/password_manager_util_win.cc View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/prefs/incognito_mode_prefs.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/shell_integration_win.cc View 1 2 3 4 5 6 7 8 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/shell_integration_win_unittest.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/pdf/adobe_reader_info_win.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/prefs/prefs_tab_helper.cc View 1 2 3 4 5 6 7 8 2 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_desktop_window_tree_host_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc View 3 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_window_property_manager_win.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/taskbar_decorator_win.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/set_as_default_browser_ui_browsertest_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/unload_browsertest.cc View 1 2 3 4 5 6 7 2 chunks +1 line, -10 lines 0 comments Download
M chrome/browser/web_applications/update_shortcut_worker_win.cc View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/web_applications/web_app_win.cc View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/utility/importer/edge_database_reader_unittest_win.cc View 18 chunks +0 lines, -72 lines 0 comments Download
M cloud_print/virtual_driver/win/install/setup.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/metrics/drive_metrics_provider_win.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/renderer_host/legacy_render_widget_host_win.cc View 2 chunks +1 line, -3 lines 0 comments Download
M content/common/sandbox_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/ppapi_plugin/ppapi_thread.cc View 1 2 3 4 5 6 7 8 9 10 4 chunks +9 lines, -33 lines 0 comments Download
M device/gamepad/gamepad_platform_data_fetcher_win.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M device/power_save_blocker/power_save_blocker_win.cc View 1 2 3 4 5 chunks +3 lines, -35 lines 0 comments Download
M device/sensors/data_fetcher_shared_memory_win.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M media/capture/video/win/video_capture_device_factory_win.cc View 2 chunks +1 line, -9 lines 0 comments Download
M media/gpu/dxva_video_decode_accelerator_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M media/gpu/gpu_video_decode_accelerator_factory.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M remoting/base/auto_thread_unittest.cc View 4 chunks +6 lines, -23 lines 0 comments Download
M rlz/test/rlz_test_helpers.cc View 2 chunks +12 lines, -18 lines 0 comments Download
M sandbox/win/src/process_mitigations_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/win/shell.cc View 5 chunks +0 lines, -17 lines 0 comments Download
M ui/events/blink/web_input_event_builders_win_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/gl/vsync_provider_win.cc View 1 3 chunks +42 lines, -57 lines 0 comments Download
M ui/views/win/hwnd_message_handler.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 51 (35 generated)
Patrick Monette
thakis@ PTAL at base/, chrome/, ui/ and rlz/ reillyg@ PTAL at device/ and media/ kelvinp@ ...
3 years, 6 months ago (2017-06-01 00:53:21 UTC) #30
Reilly Grant (use Gerrit)
https://codereview.chromium.org/2909943003/diff/140001/chrome/browser/media/webrtc/webrtc_browsertest_base.cc File chrome/browser/media/webrtc/webrtc_browsertest_base.cc (right): https://codereview.chromium.org/2909943003/diff/140001/chrome/browser/media/webrtc/webrtc_browsertest_base.cc#newcode466 chrome/browser/media/webrtc/webrtc_browsertest_base.cc:466: return base::win::GetVersion() <= base::win::VERSION_WIN8; This is inverting the condition.
3 years, 6 months ago (2017-06-01 01:22:54 UTC) #31
Patrick Monette
https://codereview.chromium.org/2909943003/diff/140001/chrome/browser/media/webrtc/webrtc_browsertest_base.cc File chrome/browser/media/webrtc/webrtc_browsertest_base.cc (right): https://codereview.chromium.org/2909943003/diff/140001/chrome/browser/media/webrtc/webrtc_browsertest_base.cc#newcode466 chrome/browser/media/webrtc/webrtc_browsertest_base.cc:466: return base::win::GetVersion() <= base::win::VERSION_WIN8; On 2017/06/01 01:22:54, Reilly Grant ...
3 years, 6 months ago (2017-06-01 01:59:17 UTC) #33
pastarmovj
cloud_print lgtm
3 years, 6 months ago (2017-06-01 05:41:32 UTC) #34
Reilly Grant (use Gerrit)
device and media lgtm
3 years, 6 months ago (2017-06-01 06:28:49 UTC) #35
rkaplow
lgtm
3 years, 6 months ago (2017-06-01 14:45:07 UTC) #36
Nico
base chrome rlz ui lgtm https://codereview.chromium.org/2909943003/diff/140002/base/files/file_enumerator_win.cc File base/files/file_enumerator_win.cc (right): https://codereview.chromium.org/2909943003/diff/140002/base/files/file_enumerator_win.cc#newcode104 base/files/file_enumerator_win.cc:104: // Use a "large ...
3 years, 6 months ago (2017-06-01 15:01:23 UTC) #37
joedow
remoting lgtm
3 years, 6 months ago (2017-06-01 16:44:10 UTC) #39
kelvinp
lgtm
3 years, 6 months ago (2017-06-01 17:33:06 UTC) #40
jschuh
lgtm for sandbox, with one nit elsewhere. https://codereview.chromium.org/2909943003/diff/140002/base/win/shortcut.h File base/win/shortcut.h (right): https://codereview.chromium.org/2909943003/diff/140002/base/win/shortcut.h#newcode49 base/win/shortcut.h:49: // TODO(pmonette): ...
3 years, 6 months ago (2017-06-01 18:30:41 UTC) #41
jam
https://codereview.chromium.org/2909943003/diff/140002/content/ppapi_plugin/ppapi_thread.cc File content/ppapi_plugin/ppapi_thread.cc (right): https://codereview.chromium.org/2909943003/diff/140002/content/ppapi_plugin/ppapi_thread.cc#newcode90 content/ppapi_plugin/ppapi_thread.cc:90: typedef BOOL (WINAPI *PfnEnumSystemLocalesEx) just call EnumSystemLocalesEx directly?
3 years, 6 months ago (2017-06-01 23:55:19 UTC) #42
Patrick Monette
https://codereview.chromium.org/2909943003/diff/140002/base/files/file_enumerator_win.cc File base/files/file_enumerator_win.cc (right): https://codereview.chromium.org/2909943003/diff/140002/base/files/file_enumerator_win.cc#newcode104 base/files/file_enumerator_win.cc:104: // Use a "large fetch" on newer Windows which ...
3 years, 6 months ago (2017-06-02 00:34:04 UTC) #43
Patrick Monette
jrummell@ PTAL at media/
3 years, 6 months ago (2017-06-02 00:36:31 UTC) #44
jam
lgtm
3 years, 6 months ago (2017-06-02 04:49:31 UTC) #45
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2909943003/190001
3 years, 6 months ago (2017-06-02 19:21:03 UTC) #48
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 22:39:02 UTC) #51
Message was sent while issue was closed. 
Committed patchset #11 (id:190001) as
https://chromium.googlesource.com/chromium/src/+/dddfcf1b9e97593f1321a6744a37...

Powered by Google App Engine
This is Rietveld 408576698