content/common/sandbox_win.cc - Issue 2909943003: Removing useless Win7 checks + standardize its use

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/sandbox_win.cc

Issue 2909943003: Removing useless Win7 checks + standardize its use (Closed)

Patch Set: Various nits Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/sandbox_win.cc

diff --git a/content/common/sandbox_win.cc b/content/common/sandbox_win.cc

index 3d6f9b80575bf141b07c60704f0c8499c84aa4df..3963c6e33d9f211c96d5a76046f72d077398b38b 100644

--- a/content/common/sandbox_win.cc

+++ b/content/common/sandbox_win.cc

@@ -403,7 +403,7 @@ sandbox::ResultCode AddPolicyForSandboxedProcess(

sandbox::ResultCode result = sandbox::SBOX_ALL_OK;

// Win8+ adds a device DeviceApi that we don't need.

- if (base::win::GetVersion() > base::win::VERSION_WIN7)

+ if (base::win::GetVersion() >= base::win::VERSION_WIN8)

result = policy->AddKernelObjectToClose(L"File", L"\\Device\\DeviceApi");

if (result != sandbox::SBOX_ALL_OK)

return result;