Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Side by Side Diff: chrome/installer/util/shell_util.h

Issue 2909943003: Removing useless Win7 checks + standardize its use (Closed)
Patch Set: Fix reversed conditionnal Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // This file declares methods that are useful for integrating Chrome in 5 // This file declares methods that are useful for integrating Chrome in
6 // Windows shell. These methods are all static and currently part of 6 // Windows shell. These methods are all static and currently part of
7 // ShellUtil class. 7 // ShellUtil class.
8 8
9 #ifndef CHROME_INSTALLER_UTIL_SHELL_UTIL_H_ 9 #ifndef CHROME_INSTALLER_UTIL_SHELL_UTIL_H_
10 #define CHROME_INSTALLER_UTIL_SHELL_UTIL_H_ 10 #define CHROME_INSTALLER_UTIL_SHELL_UTIL_H_
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 53
54 // Typical shortcut directories. Resolved in GetShortcutPath(). 54 // Typical shortcut directories. Resolved in GetShortcutPath().
55 // Also used in ShortcutLocationIsSupported(). 55 // Also used in ShortcutLocationIsSupported().
56 enum ShortcutLocation { 56 enum ShortcutLocation {
57 SHORTCUT_LOCATION_FIRST = 0, 57 SHORTCUT_LOCATION_FIRST = 0,
58 SHORTCUT_LOCATION_DESKTOP = SHORTCUT_LOCATION_FIRST, 58 SHORTCUT_LOCATION_DESKTOP = SHORTCUT_LOCATION_FIRST,
59 SHORTCUT_LOCATION_QUICK_LAUNCH, 59 SHORTCUT_LOCATION_QUICK_LAUNCH,
60 SHORTCUT_LOCATION_START_MENU_ROOT, 60 SHORTCUT_LOCATION_START_MENU_ROOT,
61 SHORTCUT_LOCATION_START_MENU_CHROME_DIR_DEPRECATED, // now placed in root 61 SHORTCUT_LOCATION_START_MENU_CHROME_DIR_DEPRECATED, // now placed in root
62 SHORTCUT_LOCATION_START_MENU_CHROME_APPS_DIR, 62 SHORTCUT_LOCATION_START_MENU_CHROME_APPS_DIR,
63 SHORTCUT_LOCATION_TASKBAR_PINS, // base::win::VERSION_WIN7 + 63 SHORTCUT_LOCATION_TASKBAR_PINS,
Nico 2017/06/01 15:01:22 Keep comment?
Patrick Monette 2017/06/02 00:34:04 Done.
64 SHORTCUT_LOCATION_APP_SHORTCUTS, // base::win::VERSION_WIN8 + 64 SHORTCUT_LOCATION_APP_SHORTCUTS, // base::win::VERSION_WIN8 +
65 NUM_SHORTCUT_LOCATIONS 65 NUM_SHORTCUT_LOCATIONS
66 }; 66 };
67 67
68 enum ShortcutOperation { 68 enum ShortcutOperation {
69 // Create a new shortcut (overwriting if necessary). 69 // Create a new shortcut (overwriting if necessary).
70 SHELL_SHORTCUT_CREATE_ALWAYS, 70 SHELL_SHORTCUT_CREATE_ALWAYS,
71 // Create the per-user shortcut only if its system-level equivalent (with 71 // Create the per-user shortcut only if its system-level equivalent (with
72 // the same name) is not present. 72 // the same name) is not present.
73 SHELL_SHORTCUT_CREATE_IF_NO_SYSTEM_LEVEL, 73 SHELL_SHORTCUT_CREATE_IF_NO_SYSTEM_LEVEL,
(...skipping 562 matching lines...) Expand 10 before | Expand all | Expand 10 after
636 static bool AddRegistryEntries( 636 static bool AddRegistryEntries(
637 HKEY root, 637 HKEY root,
638 const std::vector<std::unique_ptr<RegistryEntry>>& entries); 638 const std::vector<std::unique_ptr<RegistryEntry>>& entries);
639 639
640 private: 640 private:
641 DISALLOW_COPY_AND_ASSIGN(ShellUtil); 641 DISALLOW_COPY_AND_ASSIGN(ShellUtil);
642 }; 642 };
643 643
644 644
645 #endif // CHROME_INSTALLER_UTIL_SHELL_UTIL_H_ 645 #endif // CHROME_INSTALLER_UTIL_SHELL_UTIL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698