Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6335)

Unified Diff: chrome/browser/password_manager/password_manager_util_win.cc

Issue 2909943003: Removing useless Win7 checks + standardize its use (Closed)
Patch Set: Various nits Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_manager_util_win.cc
diff --git a/chrome/browser/password_manager/password_manager_util_win.cc b/chrome/browser/password_manager/password_manager_util_win.cc
index 01dd5c2821f1ed2eb44a2f58d0efe2d5ef172637..c883e8f9340726bd90d83a1e470bd2fe98fa06fb 100644
--- a/chrome/browser/password_manager/password_manager_util_win.cc
+++ b/chrome/browser/password_manager/password_manager_util_win.cc
@@ -25,7 +25,6 @@
#include "base/strings/utf_string_conversions.h"
#include "base/task_scheduler/post_task.h"
#include "base/time/time.h"
-#include "base/win/windows_version.h"
#include "chrome/browser/browser_process.h"
#include "chrome/grit/chromium_strings.h"
#include "components/password_manager/core/browser/password_manager.h"
@@ -178,10 +177,7 @@ void GetOsPasswordStatusInternal(PasswordCheckPrefs* prefs,
*status = PASSWORD_STATUS_WIN_DOMAIN;
} else {
username_length = CREDUI_MAX_USERNAME_LENGTH;
- // CheckBlankPasswordWithPrefs() isn't safe to call on before Windows 7.
- // http://crbug.com/345916
- if (base::win::GetVersion() >= base::win::VERSION_WIN7 &&
- GetUserName(username, &username_length)) {
+ if (GetUserName(username, &username_length)) {
*status = CheckBlankPasswordWithPrefs(username, prefs) ?
PASSWORD_STATUS_BLANK :
PASSWORD_STATUS_NONBLANK;
« no previous file with comments | « chrome/browser/media/webrtc/webrtc_browsertest_base.cc ('k') | chrome/browser/prefs/incognito_mode_prefs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698