Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: device/gamepad/gamepad_platform_data_fetcher_win.cc

Issue 2909943003: Removing useless Win7 checks + standardize its use (Closed)
Patch Set: Various nits Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/ppapi_plugin/ppapi_thread.cc ('k') | device/power_save_blocker/power_save_blocker_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/gamepad/gamepad_platform_data_fetcher_win.cc
diff --git a/device/gamepad/gamepad_platform_data_fetcher_win.cc b/device/gamepad/gamepad_platform_data_fetcher_win.cc
index 42404e006f4df8e408b4284683956769626dd984..2f2f7ac34b70f3f3ddfb2578bdf11a297e533da6 100644
--- a/device/gamepad/gamepad_platform_data_fetcher_win.cc
+++ b/device/gamepad/gamepad_platform_data_fetcher_win.cc
@@ -68,14 +68,10 @@ const UChar* XInputDllFileName() {
// Xinput.h specifies it in build time. Approach here uses the same values
// and it is resolving dll filename based on Windows version it is running on.
if (base::win::GetVersion() >= base::win::VERSION_WIN8) {
- // For Windows 8 and 10, XINPUT_DLL is xinput1_4.dll.
+ // For Windows 8+, XINPUT_DLL is xinput1_4.dll.
return FILE_PATH_LITERAL("xinput1_4.dll");
- } else if (base::win::GetVersion() >= base::win::VERSION_WIN7) {
- return FILE_PATH_LITERAL("xinput9_1_0.dll");
- } else {
- NOTREACHED();
- return nullptr;
}
+ return FILE_PATH_LITERAL("xinput9_1_0.dll");
}
} // namespace
« no previous file with comments | « content/ppapi_plugin/ppapi_thread.cc ('k') | device/power_save_blocker/power_save_blocker_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698