Removing useless Win7 checks + standardize its use

base/win/shortcut.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_WIN_SHORTCUT_H_
 #define BASE_WIN_SHORTCUT_H_
 
 #include <windows.h>
 #include <stdint.h>
 
@@ skipping 28 matching lines @@
     PROPERTIES_DESCRIPTION = 1U << 3,
     PROPERTIES_ICON = 1U << 4,
     PROPERTIES_APP_ID = 1U << 5,
     PROPERTIES_DUAL_MODE = 1U << 6,
     // Be sure to update the values below when adding a new property.
     PROPERTIES_BASIC = PROPERTIES_TARGET |
         PROPERTIES_WORKING_DIR |
         PROPERTIES_ARGUMENTS |
         PROPERTIES_DESCRIPTION |
         PROPERTIES_ICON,
+    // TODO(pmonette): Get rid of PROPERTIES_WIN7 now that Windows 7 is the last
+    // supported Windows version.
     PROPERTIES_WIN7 = PROPERTIES_APP_ID | PROPERTIES_DUAL_MODE,
     PROPERTIES_ALL = PROPERTIES_BASIC | PROPERTIES_WIN7
   };
 
   ShortcutProperties();
   ShortcutProperties(const ShortcutProperties& other);
   ~ShortcutProperties();
 
   void set_target(const FilePath& target_in) {
     target = target_in;
@@ skipping 106 matching lines @@
 
 // Unpins a shortcut from the Windows 7+ taskbar. The |shortcut| must exist and
 // already be pinned to the taskbar. The app id of the shortcut is used as the
 // identifier for the taskbar item to remove and must be set correctly.
 BASE_EXPORT bool UnpinShortcutFromTaskbar(const FilePath& shortcut);
 
 }  // namespace win
 }  // namespace base
 
 #endif  // BASE_WIN_SHORTCUT_H_