[mus+ash] Removes WmWindow from ash (app_list, frame, metrics, session, system, wallpaper)

[mus+ash] Removes WmWindow from ash (app_list, frame, metrics, etc.)

Removes WmWindow from ash (app_list, frame, metrics, session, shared,
system, ash/test, wallpaper, ash/wm/maximize_mode, c/b/ui/ash)

With this CL the last places where WmWindow / wm_window.h are used are:
  ash/aura/shell_port_classic.*
  ash/mus/bridge/shell_port_mash.*
  ash/root_window_controller.*
  ash/shell.cc
  ash/shell_port.*
  ash/wm_transient_window_observer.h
  ash/wm_window.*

BUG=687656
TEST=None (refactoring)
TBR=reveman@chromium.org (for trivial changes to components/exo files)

Review-Url: https://codereview.chromium.org/2908333003
Cr-Commit-Position: refs/heads/master@{#475972}
Committed: https://chromium.googlesource.com/chromium/src/+/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1

[varkha, 2017-05-30 23:58:48]

The CQ bit was checked by varkha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 00:00:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[varkha, 2017-05-31 00:01:10]

Description was changed from

==========
[mus+ash] Removes WmWindow from ash (app_list, frame, metrics, etc.)

Removes WmWindow from ash (app_list, frame, metrics, session, shared,
system, ash/test, wallpaper, ash/wm/maximize_mode, c/b/ui/ash)

BUG=687656
TEST=None (refactoring)
==========

to

==========
[mus+ash] Removes WmWindow from ash (app_list, frame, metrics, etc.)

Removes WmWindow from ash (app_list, frame, metrics, session, shared,
system, ash/test, wallpaper, ash/wm/maximize_mode, c/b/ui/ash)

With this CL the last places where WmWindow / wm_window.h is used are:
  ash/aura/shell_port_classic.cc
  ash/mus/bridge/shell_port_mash.cc
  ash/root_window_controller.cc
  ash/shell.cc
  ash/shell_port.cc
  ash/wm_window.cc
  ash/wm_window.h

BUG=687656
TEST=None (refactoring)
==========

[varkha, 2017-05-31 00:02:03]

Description was changed from

==========
[mus+ash] Removes WmWindow from ash (app_list, frame, metrics, etc.)

Removes WmWindow from ash (app_list, frame, metrics, session, shared,
system, ash/test, wallpaper, ash/wm/maximize_mode, c/b/ui/ash)

With this CL the last places where WmWindow / wm_window.h is used are:
  ash/aura/shell_port_classic.cc
  ash/mus/bridge/shell_port_mash.cc
  ash/root_window_controller.cc
  ash/shell.cc
  ash/shell_port.cc
  ash/wm_window.cc
  ash/wm_window.h

BUG=687656
TEST=None (refactoring)
==========

to

==========
[mus+ash] Removes WmWindow from ash (app_list, frame, metrics, etc.)

Removes WmWindow from ash (app_list, frame, metrics, session, shared,
system, ash/test, wallpaper, ash/wm/maximize_mode, c/b/ui/ash)

With this CL the last places in ash where WmWindow / wm_window.h are
used are:
  ash/aura/shell_port_classic.cc
  ash/mus/bridge/shell_port_mash.cc
  ash/root_window_controller.cc
  ash/shell.cc
  ash/shell_port.cc
  ash/wm_window.cc
  ash/wm_window.h

BUG=687656
TEST=None (refactoring)
==========

[varkha, 2017-05-31 00:22:15]

Description was changed from

==========
[mus+ash] Removes WmWindow from ash (app_list, frame, metrics, etc.)

Removes WmWindow from ash (app_list, frame, metrics, session, shared,
system, ash/test, wallpaper, ash/wm/maximize_mode, c/b/ui/ash)

With this CL the last places in ash where WmWindow / wm_window.h are
used are:
  ash/aura/shell_port_classic.cc
  ash/mus/bridge/shell_port_mash.cc
  ash/root_window_controller.cc
  ash/shell.cc
  ash/shell_port.cc
  ash/wm_window.cc
  ash/wm_window.h

BUG=687656
TEST=None (refactoring)
==========

to

==========
[mus+ash] Removes WmWindow from ash (app_list, frame, metrics, etc.)

Removes WmWindow from ash (app_list, frame, metrics, session, shared,
system, ash/test, wallpaper, ash/wm/maximize_mode, c/b/ui/ash)

With this CL the last places where WmWindow / wm_window.h are used are:
  ash/aura/shell_port_classic.cc
  ash/mus/bridge/shell_port_mash.cc
  ash/root_window_controller.cc
  ash/shell.cc
  ash/shell_port.cc
  ash/wm_window.cc
  ash/wm_window.h
  chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc

BUG=687656
TEST=None (refactoring)
==========

[varkha, 2017-05-31 00:22:24]

The CQ bit was checked by varkha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 00:23:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[varkha, 2017-05-31 00:23:33]

varkha@chromium.org changed reviewers:
+ sky@chromium.org

[varkha, 2017-05-31 00:23:36]

sky@, can you please take a look? Should be not much left after this one.
Thanks!

[varkha, 2017-05-31 00:42:37]

Description was changed from

==========
[mus+ash] Removes WmWindow from ash (app_list, frame, metrics, etc.)

Removes WmWindow from ash (app_list, frame, metrics, session, shared,
system, ash/test, wallpaper, ash/wm/maximize_mode, c/b/ui/ash)

With this CL the last places where WmWindow / wm_window.h are used are:
  ash/aura/shell_port_classic.cc
  ash/mus/bridge/shell_port_mash.cc
  ash/root_window_controller.cc
  ash/shell.cc
  ash/shell_port.cc
  ash/wm_window.cc
  ash/wm_window.h
  chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc

BUG=687656
TEST=None (refactoring)
==========

to

==========
[mus+ash] Removes WmWindow from ash (app_list, frame, metrics, etc.)

Removes WmWindow from ash (app_list, frame, metrics, session, shared,
system, ash/test, wallpaper, ash/wm/maximize_mode, c/b/ui/ash)

With this CL the last places where WmWindow / wm_window.h are used are:
  ash/aura/shell_port_classic.*
  ash/mus/bridge/shell_port_mash.*
  ash/root_window_controller.*
  ash/shell.cc
  ash/shell_port.*
  ash/wm_transient_window_observer.h
  ash/wm_window.*

BUG=687656
TEST=None (refactoring)
==========

[varkha, 2017-05-31 00:42:59]

The CQ bit was checked by varkha@chromium.org to run a CQ dry run

[varkha, 2017-05-31 00:43:10]

Patchset #4 (id:60001) has been deleted

[commit-bot: I haz the power, 2017-05-31 00:43:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 02:14:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 02:14:26]

Dry run: This issue passed the CQ dry run.

[sky, 2017-05-31 15:18:07]

Yay! Getting closer to removing WmWindow entirely!

https://codereview.chromium.org/2908333003/diff/80001/ash/ash_touch_explorati...
File ash/ash_touch_exploration_manager_chromeos.cc (right):

https://codereview.chromium.org/2908333003/diff/80001/ash/ash_touch_explorati...
ash/ash_touch_exploration_manager_chromeos.cc:194: const display::Display
this_display =
this_display -> display

[varkha, 2017-05-31 15:22:16]

The CQ bit was checked by varkha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 15:22:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[varkha, 2017-05-31 15:41:13]

varkha@chromium.org changed reviewers:
+ jamescook@chromium.org

[varkha, 2017-05-31 15:41:15]

Thanks!

+jamescook@ for visibility.

https://codereview.chromium.org/2908333003/diff/80001/ash/ash_touch_explorati...
File ash/ash_touch_exploration_manager_chromeos.cc (right):

https://codereview.chromium.org/2908333003/diff/80001/ash/ash_touch_explorati...
ash/ash_touch_exploration_manager_chromeos.cc:194: const display::Display
this_display =
On 2017/05/31 15:18:07, sky wrote:
> this_display -> display

Done.

[varkha, 2017-05-31 15:44:56]

The CQ bit was checked by varkha@chromium.org to run a CQ dry run

[varkha, 2017-05-31 15:45:31]

Patchset #5 (id:100001) has been deleted

[commit-bot: I haz the power, 2017-05-31 15:45:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[varkha, 2017-05-31 15:47:57]

Description was changed from

==========
[mus+ash] Removes WmWindow from ash (app_list, frame, metrics, etc.)

Removes WmWindow from ash (app_list, frame, metrics, session, shared,
system, ash/test, wallpaper, ash/wm/maximize_mode, c/b/ui/ash)

With this CL the last places where WmWindow / wm_window.h are used are:
  ash/aura/shell_port_classic.*
  ash/mus/bridge/shell_port_mash.*
  ash/root_window_controller.*
  ash/shell.cc
  ash/shell_port.*
  ash/wm_transient_window_observer.h
  ash/wm_window.*

BUG=687656
TEST=None (refactoring)
==========

to

==========
[mus+ash] Removes WmWindow from ash (app_list, frame, metrics, etc.)

Removes WmWindow from ash (app_list, frame, metrics, session, shared,
system, ash/test, wallpaper, ash/wm/maximize_mode, c/b/ui/ash)

With this CL the last places where WmWindow / wm_window.h are used are:
  ash/aura/shell_port_classic.*
  ash/mus/bridge/shell_port_mash.*
  ash/root_window_controller.*
  ash/shell.cc
  ash/shell_port.*
  ash/wm_transient_window_observer.h
  ash/wm_window.*

BUG=687656
TEST=None (refactoring)
TBR=reveman@chromium.org (for trivial changes to components/exo files)
==========

[commit-bot: I haz the power, 2017-05-31 16:54:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 16:54:35]

Dry run: This issue passed the CQ dry run.

[sky, 2017-05-31 17:28:19]

LGTM

[varkha, 2017-05-31 17:28:57]

The CQ bit was checked by varkha@chromium.org

[commit-bot: I haz the power, 2017-05-31 17:29:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 19:09:05]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1496251737487900,
"parent_rev": "f7b17ca967e855df93193b868a33e4ccf892c163", "commit_rev":
"d7adc3078a4b00347f8d75959ebc9087b394d6d6"}

[commit-bot: I haz the power, 2017-05-31 19:09:17]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1496251737487900,
"parent_rev": "2046b091ea5f80064c33054b36fcc0fd261aa0c5", "commit_rev":
"c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1"}

[commit-bot: I haz the power, 2017-05-31 19:09:27]

Description was changed from

==========
[mus+ash] Removes WmWindow from ash (app_list, frame, metrics, etc.)

Removes WmWindow from ash (app_list, frame, metrics, session, shared,
system, ash/test, wallpaper, ash/wm/maximize_mode, c/b/ui/ash)

With this CL the last places where WmWindow / wm_window.h are used are:
  ash/aura/shell_port_classic.*
  ash/mus/bridge/shell_port_mash.*
  ash/root_window_controller.*
  ash/shell.cc
  ash/shell_port.*
  ash/wm_transient_window_observer.h
  ash/wm_window.*

BUG=687656
TEST=None (refactoring)
TBR=reveman@chromium.org (for trivial changes to components/exo files)
==========

to

==========
[mus+ash] Removes WmWindow from ash (app_list, frame, metrics, etc.)

Removes WmWindow from ash (app_list, frame, metrics, session, shared,
system, ash/test, wallpaper, ash/wm/maximize_mode, c/b/ui/ash)

With this CL the last places where WmWindow / wm_window.h are used are:
  ash/aura/shell_port_classic.*
  ash/mus/bridge/shell_port_mash.*
  ash/root_window_controller.*
  ash/shell.cc
  ash/shell_port.*
  ash/wm_transient_window_observer.h
  ash/wm_window.*

BUG=687656
TEST=None (refactoring)
TBR=reveman@chromium.org (for trivial changes to components/exo files)

Review-Url: https://codereview.chromium.org/2908333003
Cr-Commit-Position: refs/heads/master@{#475972}
Committed:
https://chromium.googlesource.com/chromium/src/+/c8621dd6ab0c3c023c24eba66b8b...
==========

[commit-bot: I haz the power, 2017-05-31 19:09:28]

Committed patchset #5 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/c8621dd6ab0c3c023c24eba66b8b...