Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2919533002: [mus+ash] removes WmWindow, wm_window.h and wm_window.cc (Closed)

Created:
3 years, 6 months ago by varkha
Modified:
3 years, 6 months ago
Reviewers:
James Cook, sky
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[mus+ash] removes WmWindow, wm_window.h and wm_window.cc This CL removes the last few places where WmWindow was used in ash/shell. BUG=687656 TEST=None (refactoring) Review-Url: https://codereview.chromium.org/2919533002 Cr-Commit-Position: refs/heads/master@{#476115} Committed: https://chromium.googlesource.com/chromium/src/+/59679634e6846617095b88b22c5be83f951fedbe

Patch Set 1 #

Patch Set 2 : [mus+ash] removes WmWindow, wm_window.h and wm_window.cc (rebase) #

Patch Set 3 : [mus+ash] removes WmWindow, wm_window.h and wm_window.cc (rebased) #

Patch Set 4 : [mus+ash] removes WmWindow, wm_window.h and wm_window.cc (fixes build) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -935 lines) Patch
M ash/BUILD.gn View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M ash/aura/shell_port_classic.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/aura/shell_port_classic.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M ash/mus/bridge/shell_port_mash.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/mus/bridge/shell_port_mash.cc View 2 chunks +6 lines, -12 lines 0 comments Download
M ash/root_window_controller.h View 3 chunks +0 lines, -16 lines 0 comments Download
M ash/root_window_controller.cc View 1 3 chunks +0 lines, -10 lines 0 comments Download
M ash/shell.cc View 1 7 chunks +13 lines, -17 lines 0 comments Download
M ash/shell_port.h View 2 chunks +1 line, -2 lines 0 comments Download
M ash/shell_port.cc View 2 chunks +9 lines, -6 lines 0 comments Download
D ash/wm_transient_window_observer.h View 1 chunk +0 lines, -25 lines 0 comments Download
D ash/wm_window.h View 1 1 chunk +0 lines, -295 lines 0 comments Download
D ash/wm_window.cc View 1 chunk +0 lines, -539 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (10 generated)
varkha
Please take a look. This still needs https://codereview.chromium.org/2908333003/ and then there should be no need ...
3 years, 6 months ago (2017-05-31 16:33:57 UTC) #2
sky
Yay! LGTM
3 years, 6 months ago (2017-05-31 16:54:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2919533002/40001
3 years, 6 months ago (2017-05-31 19:16:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2919533002/60001
3 years, 6 months ago (2017-05-31 19:45:23 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/458316)
3 years, 6 months ago (2017-05-31 21:21:38 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2919533002/60001
3 years, 6 months ago (2017-05-31 21:36:24 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 00:42:17 UTC) #17
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/59679634e6846617095b88b22c5b...

Powered by Google App Engine
This is Rietveld 408576698