Update WebLocalFrameImpl with WebLocalFrameBase to break dependencies.

This CL moves many more classes over to use WebLocalFrameBase from
WebLocalFrameImpl.

The majority of these changes are a result of changing WebViewImpl::MainFrameImpl()
to return WebLocalFrameBase*, and then fixing all of the errors that resulted.

There are no logic changes with this change, only moving the code to use the 
abstract class rather than the concrete Impl.

Some methods were only defined in WebLocalFrameImpl. In this case they were made
pure virtual in WebLocalFrameBase and overriden in WebLocalFrameImpl.

BUG=708879
Review-Url: https://codereview.chromium.org/2896563002
Cr-Commit-Position: refs/heads/master@{#474262}
Committed: https://chromium.googlesource.com/chromium/src/+/f7ba3ebc82c44224baf56adda18795a0578a47c9

[slangley, 2017-05-21 23:57:35]

Description was changed from

==========
Seems to work.

BUG=
==========

to

==========
This CL moves many more classes over to use WebLocalFrameBase from
WebLocalFrameImpl.

The majority of these changes are a result of changing
WebViewImpl::MainFrameImpl()
to return WebLocalFrameBase*, and then fixing all of the errors that resulted.

There are no logic changes with this change, only moving the code to use the 
abstract class rather than the concrete Impl.

BUG=
==========

[slangley, 2017-05-22 00:00:13]

Description was changed from

==========
This CL moves many more classes over to use WebLocalFrameBase from
WebLocalFrameImpl.

The majority of these changes are a result of changing
WebViewImpl::MainFrameImpl()
to return WebLocalFrameBase*, and then fixing all of the errors that resulted.

There are no logic changes with this change, only moving the code to use the 
abstract class rather than the concrete Impl.

BUG=
==========

to

==========
This CL moves many more classes over to use WebLocalFrameBase from
WebLocalFrameImpl.

The majority of these changes are a result of changing
WebViewImpl::MainFrameImpl()
to return WebLocalFrameBase*, and then fixing all of the errors that resulted.

There are no logic changes with this change, only moving the code to use the 
abstract class rather than the concrete Impl.

Some methods were only defined in WebLocalFrameImpl. In this case they were made
pure virtual in WebLocalFrameBase and overriden in WebLocalFrameImpl.

BUG=708879
==========

[slangley, 2017-05-22 00:00:14]

slangley@chromium.org changed reviewers:
+ joelhockey@chromium.org

[joelhockey, 2017-05-22 01:23:18]

lgtm

fyi: I've started using gerrit for all code reviews.  You can set this up with:
git config --local gerrit.host true

[slangley, 2017-05-22 02:58:42]

slangley@chromium.org changed reviewers:
+ tkent@chromium.org

[slangley, 2017-05-22 02:58:43]

tkent@ - ptal

[tkent, 2017-05-22 03:07:20]

lgtm

[haraken, 2017-05-22 04:40:27]

LGTM

[slangley, 2017-05-24 06:28:30]

The CQ bit was checked by slangley@chromium.org

[commit-bot: I haz the power, 2017-05-24 06:29:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 06:32:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 06:32:56]

Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[slangley, 2017-05-24 06:43:52]

The CQ bit was checked by slangley@chromium.org

[slangley, 2017-05-24 06:43:53]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
haraken@chromium.org, joelhockey@chromium.org
Link to the patchset: https://codereview.chromium.org/2896563002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2017-05-24 06:44:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 07:02:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 07:03:00]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[slangley, 2017-05-24 07:21:18]

The CQ bit was checked by slangley@chromium.org

[slangley, 2017-05-24 07:21:19]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
haraken@chromium.org, joelhockey@chromium.org
Link to the patchset: https://codereview.chromium.org/2896563002/#ps80001
(title: "Fix test compiler errors.")

[commit-bot: I haz the power, 2017-05-24 07:21:45]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 10:04:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 10:04:29]

Failed to apply patch for third_party/WebKit/Source/web/tests/WebViewTest.cpp:
While running git apply --index -3 -p1;
  error: patch failed: third_party/WebKit/Source/web/tests/WebViewTest.cpp:2863
  Falling back to three-way merge...
  Applied patch to 'third_party/WebKit/Source/web/tests/WebViewTest.cpp' with
conflicts.
  U third_party/WebKit/Source/web/tests/WebViewTest.cpp

Patch:       third_party/WebKit/Source/web/tests/WebViewTest.cpp
Index: third_party/WebKit/Source/web/tests/WebViewTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebViewTest.cpp
b/third_party/WebKit/Source/web/tests/WebViewTest.cpp
index
e9d4b48e14ff8816a0b5913aef880802c2094455..4d1ca4e7d7ec29179db7ae53d291971bee1cb2d3
100644
--- a/third_party/WebKit/Source/web/tests/WebViewTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebViewTest.cpp
@@ -47,6 +47,7 @@
 #include "core/frame/LocalFrame.h"
 #include "core/frame/Settings.h"
 #include "core/frame/VisualViewport.h"
+#include "core/frame/WebLocalFrameBase.h"
 #include "core/html/HTMLIFrameElement.h"
 #include "core/html/HTMLInputElement.h"
 #include "core/html/HTMLTextAreaElement.h"
@@ -108,7 +109,6 @@
 #include "third_party/skia/include/core/SkCanvas.h"
 #include "web/DevToolsEmulator.h"
 #include "web/WebInputMethodControllerImpl.h"
-#include "web/WebLocalFrameImpl.h"
 #include "web/WebSettingsImpl.h"
 #include "web/tests/FrameTestHelpers.h"
 
@@ -513,7 +513,7 @@ TEST_P(WebViewTest, FocusIsInactive) {
 
   web_view->SetFocus(true);
   web_view->SetIsActive(true);
-  WebLocalFrameImpl* frame = web_view->MainFrameImpl();
+  WebLocalFrameBase* frame = web_view->MainFrameImpl();
   EXPECT_TRUE(frame->GetFrame()->GetDocument()->IsHTMLDocument());
 
   Document* document = frame->GetFrame()->GetDocument();
@@ -675,7 +675,7 @@ void WebViewTest::TestAutoResize(
       web_view_helper_.InitializeAndLoad(url, true, 0, &client);
   client.GetTestData().SetWebView(web_view);
 
-  WebLocalFrameImpl* frame = web_view->MainFrameImpl();
+  WebLocalFrameBase* frame = web_view->MainFrameImpl();
   FrameView* frame_view = frame->GetFrame()->View();
   frame_view->UpdateLayout();
   EXPECT_FALSE(frame_view->LayoutPending());
@@ -782,7 +782,7 @@ void WebViewTest::TestTextInputType(WebTextInputType
expected_type,
   RegisterMockedHttpURLLoad(html_file);
   WebViewBase* web_view =
       web_view_helper_.InitializeAndLoad(base_url_ + html_file);
-  WebInputMethodControllerImpl* controller =
+  WebInputMethodController* controller =
       web_view->MainFrameImpl()->GetInputMethodController();
   EXPECT_EQ(kWebTextInputTypeNone, controller->TextInputType());
   EXPECT_EQ(kWebTextInputTypeNone, controller->TextInputInfo().type);
@@ -908,8 +908,8 @@ TEST_P(WebViewTest,
SetEditableSelectionOffsetsAndTextInputInfo) {
   WebViewBase* web_view = web_view_helper_.InitializeAndLoad(
       base_url_ + "input_field_populated.html");
   web_view->SetInitialFocus(false);
-  WebLocalFrameImpl* frame = web_view->MainFrameImpl();
-  WebInputMethodControllerImpl* active_input_method_controller =
+  WebLocalFrameBase* frame = web_view->MainFrameImpl();
+  WebInputMethodController* active_input_method_controller =
       frame->GetInputMethodController();
   frame->SetEditableSelectionOffsets(5, 13);
   EXPECT_EQ("56789abc", frame->SelectionAsText());
@@ -1331,7 +1331,7 @@ TEST_P(WebViewTest,
FinishCompositionDoesNotRevealSelection) {
 
   // Set up a composition from existing text that needs to be committed.
   Vector<CompositionUnderline> empty_underlines;
-  WebLocalFrameImpl* frame = web_view->MainFrameImpl();
+  WebLocalFrameBase* frame = web_view->MainFrameImpl();
   frame->GetFrame()->GetInputMethodController().SetCompositionFromExistingText(
       empty_underlines, 0, 3);
 
@@ -1362,7 +1362,7 @@ TEST_P(WebViewTest,
InsertNewLinePlacementAfterFinishComposingText) {
 
   WebVector<WebCompositionUnderline> empty_underlines;
 
-  WebLocalFrameImpl* frame = web_view->MainFrameImpl();
+  WebLocalFrameBase* frame = web_view->MainFrameImpl();
   WebInputMethodController* active_input_method_controller =
       frame->GetInputMethodController();
   frame->SetEditableSelectionOffsets(4, 4);
@@ -1401,7 +1401,7 @@ TEST_P(WebViewTest, ExtendSelectionAndDelete) {
   RegisterMockedHttpURLLoad("input_field_populated.html");
   WebViewBase* web_view = web_view_helper_.InitializeAndLoad(
       base_url_ + "input_field_populated.html");
-  WebLocalFrameImpl* frame = web_view->MainFrameImpl();
+  WebLocalFrameBase* frame = web_view->MainFrameImpl();
   web_view->SetInitialFocus(false);
   frame->SetEditableSelectionOffsets(10, 10);
   frame->ExtendSelectionAndDelete(5, 8);
@@ -1420,7 +1420,7 @@ TEST_P(WebViewTest, DeleteSurroundingText) {
   RegisterMockedHttpURLLoad("input_field_populated.html");
   WebView* web_view = web_view_helper_.InitializeAndLoad(
       base_url_ + "input_field_populated.html");
-  WebLocalFrameImpl* frame = ToWebLocalFrameImpl(web_view->MainFrame());
+  WebLocalFrameBase* frame = ToWebLocalFrameBase(web_view->MainFrame());
   WebInputMethodController* active_input_method_controller =
       frame->GetInputMethodController();
   web_view->SetInitialFocus(false);
@@ -1466,7 +1466,7 @@ TEST_P(WebViewTest, SetCompositionFromExistingText) {
   web_view->SetInitialFocus(false);
   WebVector<WebCompositionUnderline> underlines(static_cast<size_t>(1));
   underlines[0] = WebCompositionUnderline(0, 4, 0, false, 0);
-  WebLocalFrameImpl* frame = web_view->MainFrameImpl();
+  WebLocalFrameBase* frame = web_view->MainFrameImpl();
   WebInputMethodController* active_input_method_controller =
       frame->GetInputMethodController();
   frame->SetEditableSelectionOffsets(4, 10);
@@ -1492,7 +1492,7 @@ TEST_P(WebViewTest,
SetCompositionFromExistingTextInTextArea) {
   web_view->SetInitialFocus(false);
   WebVector<WebCompositionUnderline> underlines(static_cast<size_t>(1));
   underlines[0] = WebCompositionUnderline(0, 4, 0, false, 0);
-  WebLocalFrameImpl* frame = web_view->MainFrameImpl();
+  WebLocalFrameBase* frame = web_view->MainFrameImpl();
   WebInputMethodController* active_input_method_controller =
       frame->FrameWidget()->GetActiveWebInputMethodController();
   frame->SetEditableSelectionOffsets(27, 27);
@@ -1535,7 +1535,7 @@ TEST_P(WebViewTest,
SetCompositionFromExistingTextInRichText) {
   web_view->SetInitialFocus(false);
   WebVector<WebCompositionUnderline> underlines(static_cast<size_t>(1));
   underlines[0] = WebCompositionUnderline(0, 4, 0, false, 0);
-  WebLocalFrameImpl* frame = web_view->MainFrameImpl();
+  WebLocalFrameBase* frame = web_view->MainFrameImpl();
   frame->SetEditableSelectionOffsets(1, 1);
   WebDocument document = web_view->MainFrame()->GetDocument();
   EXPECT_FALSE(document.GetElementById("bold").IsNull());
@@ -1570,7 +1570,7 @@ TEST_P(WebViewTest,
SetEditableSelectionOffsetsKeepsComposition) {
   EXPECT_EQ(6, info.composition_start);
   EXPECT_EQ(11, info.composition_end);
 
-  WebLocalFrameImpl* frame = web_view->MainFrameImpl();
+  WebLocalFrameBase* frame = web_view->MainFrameImpl();
   frame->SetEditableSelectionOffsets(6, 6);
   info = active_input_method_controller->TextInputInfo();
   EXPECT_EQ("hello world", std::string(info.value.Utf8().data()));
@@ -2291,7 +2291,7 @@ TEST_P(WebViewTest, LongPressEmptyNonEditableSelection) {
   event.source_device = kWebGestureDeviceTouchscreen;
   event.x = 300;
   event.y = 300;
-  WebLocalFrameImpl* frame = web_view->MainFrameImpl();
+  WebLocalFrameBase* frame = web_view->MainFrameImpl();
 
   EXPECT_EQ(WebInputEventResult::kHandledSystem,
             web_view->HandleInputEvent(WebCoalescedInputEvent(event)));
@@ -2309,7 +2309,7 @@ TEST_P(WebViewTest, LongPressSelection) {
 
   WebString target = WebString::FromUTF8("target");
   WebString onselectstartfalse = WebString::FromUTF8("onselectstartfalse");
-  WebLocalFrameImpl* frame = web_view->MainFrameImpl();
+  WebLocalFrameBase* frame = web_view->MainFrameImpl();
 
   EXPECT_TRUE(
       TapElementById(WebInputEvent::kGestureLongPress, onselectstartfalse));
@@ -2328,7 +2328,7 @@ TEST_P(WebViewTest,
FinishComposingTextDoesNotDismissHandles) {
   RunPendingTasks();
 
   WebString target = WebString::FromUTF8("target");
-  WebLocalFrameImpl* frame = web_view->MainFrameImpl();
+  WebLocalFrameBase* frame = web_view->MainFrameImpl();
   WebInputMethodController* active_input_method_controller =
       frame->FrameWidget()->GetActiveWebInputMethodController();
   EXPECT_TRUE(TapElementById(WebInputEvent::kGestureTap, target));
@@ -2364,7 +2364,7 @@ TEST_P(WebViewTest, TouchDoesntSelectEmptyTextarea) {
   RunPendingTasks();
 
   WebString blanklinestextbox = WebString::FromUTF8("blanklinestextbox");
-  WebLocalFrameImpl* frame = web_view->MainFrameImpl();
+  WebLocalFrameBase* frame = web_view->MainFrameImpl();
 
   // Long-press on carriage returns.
   EXPECT_TRUE(
@@ -2425,7 +2425,7 @@ TEST_P(WebViewTest, BlinkCaretAfterLongPress) {
   RunPendingTasks();
 
   WebString target = WebString::FromUTF8("target");
-  WebLocalFrameImpl* main_frame = web_view->MainFrameImpl();
+  WebLocalFrameBase* main_frame = web_view->MainFrameImpl();
 
   EXPECT_TRUE(TapElementById(WebInputEvent::kGestureLongPress, target));
   EXPECT_FALSE(main_frame->GetFrame()->Selection().IsCaretBlinkingSuspended());
@@ -2452,7 +2452,7 @@ TEST_P(WebViewTest, BlinkCaretOnClosingContextMenu) {
   web_view->HandleInputEvent(WebCoalescedInputEvent(mouse_event));
   RunPendingTasks();
 
-  WebLocalFrameImpl* main_frame = web_view->MainFrameImpl();
+  WebLocalFrameBase* main_frame = web_view->MainFrameImpl();
   EXPECT_TRUE(main_frame->GetFrame()->Selection().IsCaretBlinkingSuspended());
 
   // Caret blinking is still suspended after showing context menu.
@@ -2475,7 +2475,7 @@ TEST_P(WebViewTest, SelectionOnReadOnlyInput) {
 
   std::string test_word = "This text should be selected.";
 
-  WebLocalFrameImpl* frame = web_view->MainFrameImpl();
+  WebLocalFrameBase* frame = web_view->MainFrameI…
(message too large)

[slangley, 2017-05-24 11:08:56]

The CQ bit was checked by slangley@chromium.org

[slangley, 2017-05-24 11:08:57]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
haraken@chromium.org, joelhockey@chromium.org
Link to the patchset: https://codereview.chromium.org/2896563002/#ps100001
(title: "Rebase")

[commit-bot: I haz the power, 2017-05-24 11:09:15]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 12:40:01]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1495624136816760,
"parent_rev": "cf13270c47f29b21ce7a8c937f598989cd66c840", "commit_rev":
"f7ba3ebc82c44224baf56adda18795a0578a47c9"}

[commit-bot: I haz the power, 2017-05-24 12:40:11]

Description was changed from

==========
This CL moves many more classes over to use WebLocalFrameBase from
WebLocalFrameImpl.

The majority of these changes are a result of changing
WebViewImpl::MainFrameImpl()
to return WebLocalFrameBase*, and then fixing all of the errors that resulted.

There are no logic changes with this change, only moving the code to use the 
abstract class rather than the concrete Impl.

Some methods were only defined in WebLocalFrameImpl. In this case they were made
pure virtual in WebLocalFrameBase and overriden in WebLocalFrameImpl.

BUG=708879
==========

to

==========
This CL moves many more classes over to use WebLocalFrameBase from
WebLocalFrameImpl.

The majority of these changes are a result of changing
WebViewImpl::MainFrameImpl()
to return WebLocalFrameBase*, and then fixing all of the errors that resulted.

There are no logic changes with this change, only moving the code to use the 
abstract class rather than the concrete Impl.

Some methods were only defined in WebLocalFrameImpl. In this case they were made
pure virtual in WebLocalFrameBase and overriden in WebLocalFrameImpl.

BUG=708879

Review-Url: https://codereview.chromium.org/2896563002
Cr-Commit-Position: refs/heads/master@{#474262}
Committed:
https://chromium.googlesource.com/chromium/src/+/f7ba3ebc82c44224baf56adda187...
==========

[commit-bot: I haz the power, 2017-05-24 12:40:16]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/f7ba3ebc82c44224baf56adda187...