third_party/WebKit/Source/web/tests/FrameTestHelpers.h - Issue 2896563002: Update WebLocalFrameImpl with WebLocalFrameBase to break dependencies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/FrameTestHelpers.h

Issue 2896563002: Update WebLocalFrameImpl with WebLocalFrameBase to break dependencies. (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/FrameTestHelpers.h

diff --git a/third_party/WebKit/Source/web/tests/FrameTestHelpers.h b/third_party/WebKit/Source/web/tests/FrameTestHelpers.h

index 157034126d2d0b3501224a5271e17551c7d9e4b8..8c752a52cf2463b0e5597e2713bd87f3384ff881 100644

--- a/third_party/WebKit/Source/web/tests/FrameTestHelpers.h

+++ b/third_party/WebKit/Source/web/tests/FrameTestHelpers.h

@@ -53,7 +53,7 @@

namespace blink {

class WebFrame;

-class WebLocalFrameImpl;

+class WebLocalFrameBase;

class WebRemoteFrameImpl;

class WebSettings;

enum class WebCachePolicy;

@@ -91,7 +91,7 @@ WebMouseEvent CreateMouseEvent(WebInputEvent::Type,

// Calls WebRemoteFrame::createLocalChild, but with some arguments prefilled

// with default test values (i.e. with a default |client| or |properties| and/or

// with a precalculated |uniqueName|).

-WebLocalFrameImpl* CreateLocalChild(

+WebLocalFrameBase* CreateLocalChild(

WebRemoteFrame* parent,

const WebString& name = WebString(),

WebFrameClient* = nullptr,