third_party/WebKit/Source/web/tests/VisualViewportTest.cpp - Issue 2896563002: Update WebLocalFrameImpl with WebLocalFrameBase to break dependencies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

Issue 2896563002: Update WebLocalFrameImpl with WebLocalFrameBase to break dependencies. (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp b/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

index f8dc2cb97dfd0884bcb66253f502b3663f3ffb4b..82335a0f2b5654318d97110d944fc4929b10d23f 100644

--- a/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

+++ b/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

@@ -1800,7 +1800,7 @@ TEST_P(VisualViewportTest, TestMainFrameInitializationSizing) {

RegisterMockedHttpURLLoad("content-width-1000-min-scale.html");

NavigateTo(base_url_ + "content-width-1000-min-scale.html");

- WebLocalFrameImpl* local_frame = WebViewImpl()->MainFrameImpl();

+ WebLocalFrameBase* local_frame = WebViewImpl()->MainFrameImpl();

// The shutdown() calls are a hack to prevent this test from violating

// invariants about frame state during navigation/detach.

local_frame->GetFrame()->GetDocument()->Shutdown();