third_party/WebKit/Source/web/PageOverlay.cpp - Issue 2896563002: Update WebLocalFrameImpl with WebLocalFrameBase to break dependencies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/PageOverlay.cpp

Issue 2896563002: Update WebLocalFrameImpl with WebLocalFrameBase to break dependencies. (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/PageOverlay.cpp

diff --git a/third_party/WebKit/Source/web/PageOverlay.cpp b/third_party/WebKit/Source/web/PageOverlay.cpp

index a663cc5b33b5221921be4739f9915627d6d11551..dd43c7a31ed48e22b4bea869506839929e74704b 100644

--- a/third_party/WebKit/Source/web/PageOverlay.cpp

+++ b/third_party/WebKit/Source/web/PageOverlay.cpp

@@ -46,12 +46,12 @@

namespace blink {

std::unique_ptr<PageOverlay> PageOverlay::Create(

- WebLocalFrameImpl* frame_impl,

+ WebLocalFrameBase* frame_impl,

std::unique_ptr<PageOverlay::Delegate> delegate) {

return WTF::WrapUnique(new PageOverlay(frame_impl, std::move(delegate)));

}

-PageOverlay::PageOverlay(WebLocalFrameImpl* frame_impl,

+PageOverlay::PageOverlay(WebLocalFrameBase* frame_impl,

std::unique_ptr<PageOverlay::Delegate> delegate)

: frame_impl_(frame_impl), delegate_(std::move(delegate)) {}