Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1128)

Side by Side Diff: third_party/WebKit/Source/core/exported/WebViewBase.h

Issue 2896563002: Update WebLocalFrameImpl with WebLocalFrameBase to break dependencies. (Closed)
Patch Set: Rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/WebLocalFrameBase.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.#ifndef WebViewBase_h 3 // found in the LICENSE file.#ifndef WebViewBase_h
4 4
5 #ifndef WebViewBase_h 5 #ifndef WebViewBase_h
6 #define WebViewBase_h 6 #define WebViewBase_h
7 7
8 #include "core/page/EventWithHitTestResults.h" 8 #include "core/page/EventWithHitTestResults.h"
9 #include "platform/transforms/TransformationMatrix.h" 9 #include "platform/transforms/TransformationMatrix.h"
10 #include "platform/wtf/RefCounted.h" 10 #include "platform/wtf/RefCounted.h"
(...skipping 18 matching lines...) Expand all
29 class LinkHighlightImpl; 29 class LinkHighlightImpl;
30 class Page; 30 class Page;
31 class PaintLayerCompositor; 31 class PaintLayerCompositor;
32 class PagePopup; 32 class PagePopup;
33 class PagePopupClient; 33 class PagePopupClient;
34 class PageScaleConstraintsSet; 34 class PageScaleConstraintsSet;
35 class WebInputEvent; 35 class WebInputEvent;
36 class WebInputMethodControllerImpl; 36 class WebInputMethodControllerImpl;
37 class WebKeyboardEvent; 37 class WebKeyboardEvent;
38 class WebLayer; 38 class WebLayer;
39 class WebLocalFrameImpl; 39 class WebLocalFrameBase;
40 class WebLayerTreeView; 40 class WebLayerTreeView;
41 class WebPagePopupImpl; 41 class WebPagePopupImpl;
42 class WebSettingsImpl; 42 class WebSettingsImpl;
43 struct WebRect; 43 struct WebRect;
44 44
45 // WebViewBase is a temporary class introduced to decouple the defintion of 45 // WebViewBase is a temporary class introduced to decouple the defintion of
46 // WebViewImpl from the concrete implementation. It was not possible to move the 46 // WebViewImpl from the concrete implementation. It was not possible to move the
47 // defintion of these methods to WebView as we did not want to pollute the 47 // defintion of these methods to WebView as we did not want to pollute the
48 // public API surface area. 48 // public API surface area.
49 // 49 //
(...skipping 14 matching lines...) Expand all
64 virtual void SetShowDebugBorders(bool) = 0; 64 virtual void SetShowDebugBorders(bool) = 0;
65 65
66 virtual Page* GetPage() const = 0; 66 virtual Page* GetPage() const = 0;
67 virtual Frame* FocusedCoreFrame() const = 0; 67 virtual Frame* FocusedCoreFrame() const = 0;
68 68
69 static WebViewBase* FromPage(Page*); 69 static WebViewBase* FromPage(Page*);
70 static HashSet<WebViewBase*>& AllInstances(); 70 static HashSet<WebViewBase*>& AllInstances();
71 71
72 // Returns the main frame associated with this view. This may be null when 72 // Returns the main frame associated with this view. This may be null when
73 // the page is shutting down, but will be valid at all other times. 73 // the page is shutting down, but will be valid at all other times.
74 virtual WebLocalFrameImpl* MainFrameImpl() const = 0; 74 virtual WebLocalFrameBase* MainFrameImpl() const = 0;
75 75
76 virtual float DefaultMinimumPageScaleFactor() const = 0; 76 virtual float DefaultMinimumPageScaleFactor() const = 0;
77 virtual float DefaultMaximumPageScaleFactor() const = 0; 77 virtual float DefaultMaximumPageScaleFactor() const = 0;
78 virtual float MinimumPageScaleFactor() const = 0; 78 virtual float MinimumPageScaleFactor() const = 0;
79 virtual float MaximumPageScaleFactor() const = 0; 79 virtual float MaximumPageScaleFactor() const = 0;
80 virtual float ClampPageScaleFactorToLimits(float) const = 0; 80 virtual float ClampPageScaleFactorToLimits(float) const = 0;
81 virtual void ResetScaleStateImmediately() = 0; 81 virtual void ResetScaleStateImmediately() = 0;
82 82
83 virtual WebLayerTreeView* LayerTreeView() const = 0; 83 virtual WebLayerTreeView* LayerTreeView() const = 0;
84 virtual WebViewClient* Client() = 0; 84 virtual WebViewClient* Client() = 0;
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 virtual void ClosePagePopup(PagePopup*) = 0; 130 virtual void ClosePagePopup(PagePopup*) = 0;
131 virtual void CleanupPagePopup() = 0; 131 virtual void CleanupPagePopup() = 0;
132 virtual LocalDOMWindow* PagePopupWindow() const = 0; 132 virtual LocalDOMWindow* PagePopupWindow() const = 0;
133 133
134 virtual void InvalidateRect(const IntRect&) = 0; 134 virtual void InvalidateRect(const IntRect&) = 0;
135 // Indicates two things: 135 // Indicates two things:
136 // 1) This view may have a new layout now. 136 // 1) This view may have a new layout now.
137 // 2) Calling updateAllLifecyclePhases() is a no-op. 137 // 2) Calling updateAllLifecyclePhases() is a no-op.
138 // After calling WebWidget::updateAllLifecyclePhases(), expect to get this 138 // After calling WebWidget::updateAllLifecyclePhases(), expect to get this
139 // notification unless the view did not need a layout. 139 // notification unless the view did not need a layout.
140 virtual void LayoutUpdated(WebLocalFrameImpl*) = 0; 140 virtual void LayoutUpdated(WebLocalFrameBase*) = 0;
141 virtual void ResizeAfterLayout(WebLocalFrameImpl*) = 0; 141 virtual void ResizeAfterLayout(WebLocalFrameBase*) = 0;
142 142
143 virtual void UpdatePageDefinedViewportConstraints( 143 virtual void UpdatePageDefinedViewportConstraints(
144 const ViewportDescription&) = 0; 144 const ViewportDescription&) = 0;
145 145
146 virtual void EnterFullscreen(LocalFrame&) = 0; 146 virtual void EnterFullscreen(LocalFrame&) = 0;
147 virtual void ExitFullscreen(LocalFrame&) = 0; 147 virtual void ExitFullscreen(LocalFrame&) = 0;
148 virtual void FullscreenElementChanged(Element*, Element*) = 0; 148 virtual void FullscreenElementChanged(Element*, Element*) = 0;
149 149
150 virtual bool HasOpenedPopup() const = 0; 150 virtual bool HasOpenedPopup() const = 0;
151 151
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
216 virtual void EnableTapHighlightAtPoint( 216 virtual void EnableTapHighlightAtPoint(
217 const GestureEventWithHitTestResults& targeted_tap_event) = 0; 217 const GestureEventWithHitTestResults& targeted_tap_event) = 0;
218 virtual LinkHighlightImpl* GetLinkHighlight(int) = 0; 218 virtual LinkHighlightImpl* GetLinkHighlight(int) = 0;
219 virtual unsigned NumLinkHighlights() = 0; 219 virtual unsigned NumLinkHighlights() = 0;
220 virtual void EnableTapHighlights(HeapVector<Member<Node>>&) = 0; 220 virtual void EnableTapHighlights(HeapVector<Member<Node>>&) = 0;
221 virtual void SetCurrentInputEventForTest(const WebInputEvent*) = 0; 221 virtual void SetCurrentInputEventForTest(const WebInputEvent*) = 0;
222 }; 222 };
223 } 223 }
224 224
225 #endif 225 #endif
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/WebLocalFrameBase.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698