Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1197)

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.h

Issue 2896563002: Update WebLocalFrameImpl with WebLocalFrameBase to break dependencies. (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebViewFrameWidget.cpp ('k') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebViewImpl.h
diff --git a/third_party/WebKit/Source/web/WebViewImpl.h b/third_party/WebKit/Source/web/WebViewImpl.h
index 520bd2428ec93f990e472713842938bdb84357c5..591da9f4054516f7a2869cd94890a4ed55c22e2d 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.h
+++ b/third_party/WebKit/Source/web/WebViewImpl.h
@@ -88,7 +88,7 @@ class WebElement;
class WebInputMethodControllerImpl;
class WebLayerTreeView;
class WebLocalFrame;
-class WebLocalFrameImpl;
+class WebLocalFrameBase;
class CompositorMutatorImpl;
class WebRemoteFrame;
class WebSettingsImpl;
@@ -309,7 +309,7 @@ class WEB_EXPORT WebViewImpl final
// Returns the main frame associated with this view. This may be null when
// the page is shutting down, but will be valid at all other times.
- WebLocalFrameImpl* MainFrameImpl() const override;
+ WebLocalFrameBase* MainFrameImpl() const override;
// Event related methods:
void MouseContextMenu(const WebMouseEvent&);
@@ -348,8 +348,8 @@ class WEB_EXPORT WebViewImpl final
// 2) Calling updateAllLifecyclePhases() is a no-op.
// After calling WebWidget::updateAllLifecyclePhases(), expect to get this
// notification unless the view did not need a layout.
- void LayoutUpdated(WebLocalFrameImpl*) override;
- void ResizeAfterLayout(WebLocalFrameImpl*) override;
+ void LayoutUpdated(WebLocalFrameBase*) override;
+ void ResizeAfterLayout(WebLocalFrameBase*) override;
void DidChangeContentsSize() override;
void PageScaleFactorChanged() override;
@@ -582,7 +582,7 @@ class WEB_EXPORT WebViewImpl final
WebGestureEvent CreateGestureScrollEventFromFling(WebInputEvent::Type,
WebGestureDevice) const;
- void EnablePopupMouseWheelEventListener(WebLocalFrameImpl* local_root);
+ void EnablePopupMouseWheelEventListener(WebLocalFrameBase* local_root);
void DisablePopupMouseWheelEventListener();
void CancelPagePopup();
@@ -726,7 +726,7 @@ class WEB_EXPORT WebViewImpl final
// The local root whose document has |popup_mouse_wheel_event_listener_|
// registered.
- WeakPersistent<WebLocalFrameImpl> local_root_with_empty_mouse_wheel_listener_;
+ WeakPersistent<WebLocalFrameBase> local_root_with_empty_mouse_wheel_listener_;
WebPageImportanceSignals page_importance_signals_;
« no previous file with comments | « third_party/WebKit/Source/web/WebViewFrameWidget.cpp ('k') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698