[mus+ash] Removes WmWindow from ash/wm/mru_window_tracker and overview mode

[mus+ash] Removes WmWindow from ash/wm/mru_window_tracker and overview

Refactoring mru_window_tracker and connected classes to remove use of
WmWindow.

BUG=722553
TEST=None
TBR=xiyuan@chromium.org for a small non-behavioral change in chrome/browser/chromeos/login/users/wallpaper/wallpaper_window_state_manager.cc

Review-Url: https://codereview.chromium.org/2895713002
Cr-Commit-Position: refs/heads/master@{#474310}
Committed: https://chromium.googlesource.com/chromium/src/+/843aa52b01713a6605988ab3ee104b43d9087cd7

[varkha, 2017-05-19 19:11:24]

varkha@chromium.org changed reviewers:
+ jamescook@chromium.org, msw@chromium.org

[varkha, 2017-05-19 19:11:24]

msw@, jamescook@, not ready for review yet, just trying to give visibility into
what I am doing now.

[James Cook, 2017-05-22 08:47:40]

On 2017/05/19 19:11:24, varkha wrote:
> msw@, jamescook@, not ready for review yet, just trying to give visibility
into
> what I am doing now.

Thanks. I've got https://codereview.chromium.org/2895843002/ in flight for
//ash/system, but I don't think they will collide.

[msw, 2017-05-22 19:45:59]

A quick sampling looks pretty good, I'll probably hold off on more conversion
work until this lands. lmk if/when you want a full review pass.

[varkha, 2017-05-23 18:16:10]

The CQ bit was checked by varkha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 18:16:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[varkha, 2017-05-23 18:32:40]

Can you please take a first look?
Thanks!

[James Cook, 2017-05-23 20:24:06]

On 2017/05/23 18:32:40, varkha wrote:
> Can you please take a first look?
> Thanks!

msw@ graciously volunteered to look first. I'll wait for him, then I can give
you an owners stamp.

[James Cook, 2017-05-23 20:25:59]

On 2017/05/23 20:24:06, James Cook wrote:
> On 2017/05/23 18:32:40, varkha wrote:
> > Can you please take a first look?
> > Thanks!
> 
> msw@ graciously volunteered to look first. I'll wait for him, then I can give
> you an owners stamp.

Also, just FYI sky@ recently landed https://codereview.chromium.org/2901663003
that touches WmWindow in ash/wm.

[varkha, 2017-05-23 21:30:28]

> Also, just FYI sky@ recently landed https://codereview.chromium.org/2901663003
> that touches WmWindow in ash/wm.

Yes, I'll need to rebase to that, still PTAL in the meanwhile if you have
cycles.
Certainly the WindowState->window() will simplify a few things.
Thanks!

[msw, 2017-05-23 22:50:25]

lgtm with minor nits; feel free to ignore some/most (many are just about
aura::Window::Windows use opportunities). I'll look at any updated patch sets.

https://codereview.chromium.org/2895713002/diff/80001/ash/shelf/shelf_layout_...
File ash/shelf/shelf_layout_manager.cc (right):

https://codereview.chromium.org/2895713002/diff/80001/ash/shelf/shelf_layout_...
ash/shelf/shelf_layout_manager.cc:880: const std::vector<aura::Window*> windows
=
optional nit: use aura::Window::Windows

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/ash_focus_rules.cc
File ash/wm/ash_focus_rules.cc (right):

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/ash_focus_rules....
ash/wm/ash_focus_rules.cc:93: std::vector<aura::Window*> windows =
mru->BuildMruWindowList();
ditto optional nit.

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/maximize_mode/ma...
File ash/wm/maximize_mode/maximize_mode_window_manager.cc (right):

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/maximize_mode/ma...
ash/wm/maximize_mode/maximize_mode_window_manager.cc:302: for (aura::Window*
root : Shell::Get()->GetAllRootWindows()) {
optional nit: use the static Shell::GetAllRootWindowControllers() (or just skip
Get(), GetAllRootWindows is also static)

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/maximize_mode/ma...
File ash/wm/maximize_mode/maximize_mode_window_state.h (right):

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/maximize_mode/ma...
ash/wm/maximize_mode/maximize_mode_window_state.h:14: class Window;
optional nit: not needed (pulled in via ash/wm/window_state.h)

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/maximize_mode/ma...
ash/wm/maximize_mode/maximize_mode_window_state.h:76: // The state object for
this object which owns this instance.
aside: lol comment

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/mru_window_track...
File ash/wm/mru_window_tracker.cc (right):

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/mru_window_track...
ash/wm/mru_window_tracker.cc:59: for (size_t i = 0; i <
wm::kSwitchableWindowContainerIdsLength; ++i)
nit: keep curlies for multi-line loop block

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/mru_window_track...
ash/wm/mru_window_tracker.cc:64: std::vector<aura::Window*>::iterator itr =
windows.begin();
nit: aura::Window::Windows

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/mru_window_track...
File ash/wm/mru_window_tracker.h (right):

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/mru_window_track...
ash/wm/mru_window_tracker.h:17: class Window;
optional nit: not needed (per window_observer.h & activation_change_observer.h)

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/mru_window_track...
ash/wm/mru_window_tracker.h:28: using WindowList = std::vector<aura::Window*>;
optional nit: use aura::Window::Windows

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/overview/scoped_...
File ash/wm/overview/scoped_overview_animation_settings_factory_aura.h (right):

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/overview/scoped_...
ash/wm/overview/scoped_overview_animation_settings_factory_aura.h:16: class
ScopedOverviewAnimationSettingsFactoryAura
aside: This is *super* ripe for cleanup, but feel free to punt that for now.

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/overview/scoped_...
File ash/wm/overview/scoped_transform_overview_window.cc (right):

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/overview/scoped_...
ash/wm/overview/scoped_transform_overview_window.cc:375: for (auto* window :
GetTransientTreeIterator(GetOverviewWindow())) {
optional nit: curlies not needed

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/overview/scoped_...
File ash/wm/overview/scoped_transform_overview_window.h (right):

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/overview/scoped_...
ash/wm/overview/scoped_transform_overview_window.h:151: // if it does not exit.
nit: s/exit/exist/, poor comment spelling/grammar abounds here!

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/overview/window_...
File ash/wm/overview/window_grid.cc (right):

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/overview/window_...
ash/wm/overview/window_grid.cc:55: // A comparator for locating a given target
window.
aside: It might be nice to remove this and make WindowGrid::Contains return the
iter (or use find_if like line 571), but that's completely unrelated.

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/overview/window_...
ash/wm/overview/window_grid.cc:278: const std::vector<aura::Window*>& windows,
ditto optional nit here and below.

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/overview/window_...
File ash/wm/overview/window_grid.h (right):

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/overview/window_...
ash/wm/overview/window_grid.h:54: const std::vector<aura::Window*>& window_list,
ditto optional nit

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/overview/window_...
File ash/wm/overview/window_selector.cc (right):

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/overview/window_...
ash/wm/overview/window_selector.cc:248: std::vector<aura::Window*> root_windows
= Shell::GetAllRootWindows();
ditto

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/overview/window_...
ash/wm/overview/window_selector.cc:424: std::vector<aura::Window*> window_list =
ditto

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/overview/window_...
File ash/wm/overview/window_selector.h (right):

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/overview/window_...
ash/wm/overview/window_selector.h:25: class Window;
nit: not needed (window_observer.h)

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/overview/window_...
ash/wm/overview/window_selector.h:51: using WindowList =
std::vector<aura::Window*>;
ditto optional nit

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/overview/window_...
File ash/wm/overview/window_selector_item.h (right):

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/overview/window_...
ash/wm/overview/window_selector_item.h:22: class Window;
nit: not needed

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/window_positione...
File ash/wm/window_positioner.cc (right):

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/window_positione...
ash/wm/window_positioner.cc:101: std::vector<aura::Window*> transient_children =
ditto

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/window_positione...
ash/wm/window_positioner.cc:176: const std::vector<aura::Window*> windows =
ditto

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/window_positione...
ash/wm/window_positioner.cc:496: const std::vector<aura::Window*> windows =
ditto

https://codereview.chromium.org/2895713002/diff/80001/chrome/browser/chromeos...
File
chrome/browser/chromeos/login/users/wallpaper/wallpaper_window_state_manager.cc
(right):

https://codereview.chromium.org/2895713002/diff/80001/chrome/browser/chromeos...
chrome/browser/chromeos/login/users/wallpaper/wallpaper_window_state_manager.cc:69:
std::vector<aura::Window*> windows =
ditto

[varkha, 2017-05-24 15:24:51]

The CQ bit was checked by varkha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 15:25:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[varkha, 2017-05-24 15:28:46]

Description was changed from

==========
[mus+ash] Removes WmWindow from ash/wm/mru_window_tracker and overview

WIP - uploading to give visibility into what I am doing here.
Refactoring mru_window_tracker and connected classes to remove use of
WmWindow.

BUG=722553
TEST=None
==========

to

==========
[mus+ash] Removes WmWindow from ash/wm/mru_window_tracker and overview

WIP - uploading to give visibility into what I am doing here.
Refactoring mru_window_tracker and connected classes to remove use of
WmWindow.

BUG=722553
TEST=None
TBR=xiyuan@chromium.org for a small non-behavioral change in
chrome/browser/chromeos/login/users/wallpaper/wallpaper_window_state_manager.cc
==========

[varkha, 2017-05-24 15:29:15]

Thanks, jamescook@, could you please take a look for OWNERS?

https://codereview.chromium.org/2895713002/diff/80001/ash/shelf/shelf_layout_...
File ash/shelf/shelf_layout_manager.cc (right):

https://codereview.chromium.org/2895713002/diff/80001/ash/shelf/shelf_layout_...
ash/shelf/shelf_layout_manager.cc:880: const std::vector<aura::Window*> windows
=
On 2017/05/23 22:50:24, msw wrote:
> optional nit: use aura::Window::Windows

Done.

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/ash_focus_rules.cc
File ash/wm/ash_focus_rules.cc (right):

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/ash_focus_rules....
ash/wm/ash_focus_rules.cc:93: std::vector<aura::Window*> windows =
mru->BuildMruWindowList();
On 2017/05/23 22:50:24, msw wrote:
> ditto optional nit.

Done.

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/maximize_mode/ma...
File ash/wm/maximize_mode/maximize_mode_window_manager.cc (right):

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/maximize_mode/ma...
ash/wm/maximize_mode/maximize_mode_window_manager.cc:302: for (aura::Window*
root : Shell::Get()->GetAllRootWindows()) {
On 2017/05/23 22:50:24, msw wrote:
> optional nit: use the static Shell::GetAllRootWindowControllers() (or just
skip
> Get(), GetAllRootWindows is also static)

Done.

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/maximize_mode/ma...
File ash/wm/maximize_mode/maximize_mode_window_state.h (right):

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/maximize_mode/ma...
ash/wm/maximize_mode/maximize_mode_window_state.h:14: class Window;
On 2017/05/23 22:50:24, msw wrote:
> optional nit: not needed (pulled in via ash/wm/window_state.h)

Done.

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/maximize_mode/ma...
ash/wm/maximize_mode/maximize_mode_window_state.h:76: // The state object for
this object which owns this instance.
On 2017/05/23 22:50:24, msw wrote:
> aside: lol comment

Done.

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/mru_window_track...
File ash/wm/mru_window_tracker.cc (right):

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/mru_window_track...
ash/wm/mru_window_tracker.cc:59: for (size_t i = 0; i <
wm::kSwitchableWindowContainerIdsLength; ++i)
On 2017/05/23 22:50:24, msw wrote:
> nit: keep curlies for multi-line loop block

Done.

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/mru_window_track...
ash/wm/mru_window_tracker.cc:64: std::vector<aura::Window*>::iterator itr =
windows.begin();
On 2017/05/23 22:50:24, msw wrote:
> nit: aura::Window::Windows

Done.

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/mru_window_track...
File ash/wm/mru_window_tracker.h (right):

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/mru_window_track...
ash/wm/mru_window_tracker.h:17: class Window;
On 2017/05/23 22:50:24, msw wrote:
> optional nit: not needed (per window_observer.h &
activation_change_observer.h)

Done.

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/mru_window_track...
ash/wm/mru_window_tracker.h:28: using WindowList = std::vector<aura::Window*>;
On 2017/05/23 22:50:24, msw wrote:
> optional nit: use aura::Window::Windows

aura::Window is only forward defined at this point so I would need an include of
window.h, no?

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/overview/scoped_...
File ash/wm/overview/scoped_overview_animation_settings_factory_aura.h (right):

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/overview/scoped_...
ash/wm/overview/scoped_overview_animation_settings_factory_aura.h:16: class
ScopedOverviewAnimationSettingsFactoryAura
On 2017/05/23 22:50:24, msw wrote:
> aside: This is *super* ripe for cleanup, but feel free to punt that for now.

I'll do it in a follow-up, it seems isolated enough.

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/overview/scoped_...
File ash/wm/overview/scoped_transform_overview_window.cc (right):

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/overview/scoped_...
ash/wm/overview/scoped_transform_overview_window.cc:375: for (auto* window :
GetTransientTreeIterator(GetOverviewWindow())) {
On 2017/05/23 22:50:24, msw wrote:
> optional nit: curlies not needed

Done.

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/overview/scoped_...
File ash/wm/overview/scoped_transform_overview_window.h (right):

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/overview/scoped_...
ash/wm/overview/scoped_transform_overview_window.h:151: // if it does not exit.
On 2017/05/23 22:50:24, msw wrote:
> nit: s/exit/exist/, poor comment spelling/grammar abounds here!

Done. Fixed a few places I could spot, see if you can find some more offenders.
Thanks!

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/overview/window_...
File ash/wm/overview/window_grid.cc (right):

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/overview/window_...
ash/wm/overview/window_grid.cc:55: // A comparator for locating a given target
window.
On 2017/05/23 22:50:24, msw wrote:
> aside: It might be nice to remove this and make WindowGrid::Contains return
the
> iter (or use find_if like line 571), but that's completely unrelated.

Did you mean find_if like line 632? I can do it separately.

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/overview/window_...
ash/wm/overview/window_grid.cc:278: const std::vector<aura::Window*>& windows,
On 2017/05/23 22:50:24, msw wrote:
> ditto optional nit here and below.

I agree that we should use Windows below but here I am tempted to match
verbatim the spelling in the window_grid.h (where aura::Window is only
forward-declared). WDYT?

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/overview/window_...
File ash/wm/overview/window_grid.h (right):

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/overview/window_...
ash/wm/overview/window_grid.h:54: const std::vector<aura::Window*>& window_list,
On 2017/05/23 22:50:24, msw wrote:
> ditto optional nit

Is it worth including aura/window.h for this?

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/overview/window_...
File ash/wm/overview/window_selector.cc (right):

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/overview/window_...
ash/wm/overview/window_selector.cc:248: std::vector<aura::Window*> root_windows
= Shell::GetAllRootWindows();
On 2017/05/23 22:50:25, msw wrote:
> ditto

Done.

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/overview/window_...
ash/wm/overview/window_selector.cc:424: std::vector<aura::Window*> window_list =
On 2017/05/23 22:50:24, msw wrote:
> ditto

Done.

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/overview/window_...
File ash/wm/overview/window_selector.h (right):

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/overview/window_...
ash/wm/overview/window_selector.h:25: class Window;
On 2017/05/23 22:50:25, msw wrote:
> nit: not needed (window_observer.h)

Done.

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/overview/window_...
ash/wm/overview/window_selector.h:51: using WindowList =
std::vector<aura::Window*>;
On 2017/05/23 22:50:25, msw wrote:
> ditto optional nit

Worth include aura/window.h?

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/overview/window_...
File ash/wm/overview/window_selector_item.h (right):

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/overview/window_...
ash/wm/overview/window_selector_item.h:22: class Window;
On 2017/05/23 22:50:25, msw wrote:
> nit: not needed

Done.

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/window_positione...
File ash/wm/window_positioner.cc (right):

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/window_positione...
ash/wm/window_positioner.cc:101: std::vector<aura::Window*> transient_children =
On 2017/05/23 22:50:25, msw wrote:
> ditto

Done.

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/window_positione...
ash/wm/window_positioner.cc:176: const std::vector<aura::Window*> windows =
On 2017/05/23 22:50:25, msw wrote:
> ditto

Done.

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/window_positione...
ash/wm/window_positioner.cc:496: const std::vector<aura::Window*> windows =
On 2017/05/23 22:50:25, msw wrote:
> ditto

Done.

https://codereview.chromium.org/2895713002/diff/80001/chrome/browser/chromeos...
File
chrome/browser/chromeos/login/users/wallpaper/wallpaper_window_state_manager.cc
(right):

https://codereview.chromium.org/2895713002/diff/80001/chrome/browser/chromeos...
chrome/browser/chromeos/login/users/wallpaper/wallpaper_window_state_manager.cc:69:
std::vector<aura::Window*> windows =
On 2017/05/23 22:50:25, msw wrote:
> ditto

Done.

[varkha, 2017-05-24 15:31:32]

+cc:sky@ - FYI, this seems to be almost ready to land.

[James Cook, 2017-05-24 15:50:22]

LGTM

https://codereview.chromium.org/2895713002/diff/100001/ash/wm/maximize_mode/m...
File ash/wm/maximize_mode/maximize_mode_window_manager.cc (right):

https://codereview.chromium.org/2895713002/diff/100001/ash/wm/maximize_mode/m...
ash/wm/maximize_mode/maximize_mode_window_manager.cc:210: for (auto* window :
windows)
Aside: This is fine, but in general I prefer to spell out the type
(aura::Window*) in range-based for loops unless the type is really long.

[commit-bot: I haz the power, 2017-05-24 15:56:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 15:56:51]

Dry run: This issue passed the CQ dry run.

[varkha, 2017-05-24 16:00:07]

https://codereview.chromium.org/2895713002/diff/100001/ash/wm/maximize_mode/m...
File ash/wm/maximize_mode/maximize_mode_window_manager.cc (right):

https://codereview.chromium.org/2895713002/diff/100001/ash/wm/maximize_mode/m...
ash/wm/maximize_mode/maximize_mode_window_manager.cc:210: for (auto* window :
windows)
On 2017/05/24 15:50:22, James Cook wrote:
> Aside: This is fine, but in general I prefer to spell out the type
> (aura::Window*) in range-based for loops unless the type is really long.

Acknowledged.

[varkha, 2017-05-24 16:00:28]

The CQ bit was checked by varkha@chromium.org

[varkha, 2017-05-24 16:00:29]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2895713002/#ps100001
(title: "Address nits, unit_tests target compiles")

[commit-bot: I haz the power, 2017-05-24 16:00:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 16:06:04]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1495641628918050,
"parent_rev": "257f536a7a0d55b86cfd1a874aee483f99a46f7e", "commit_rev":
"843aa52b01713a6605988ab3ee104b43d9087cd7"}

[commit-bot: I haz the power, 2017-05-24 16:06:20]

Description was changed from

==========
[mus+ash] Removes WmWindow from ash/wm/mru_window_tracker and overview

WIP - uploading to give visibility into what I am doing here.
Refactoring mru_window_tracker and connected classes to remove use of
WmWindow.

BUG=722553
TEST=None
TBR=xiyuan@chromium.org for a small non-behavioral change in
chrome/browser/chromeos/login/users/wallpaper/wallpaper_window_state_manager.cc
==========

to

==========
[mus+ash] Removes WmWindow from ash/wm/mru_window_tracker and overview

WIP - uploading to give visibility into what I am doing here.
Refactoring mru_window_tracker and connected classes to remove use of
WmWindow.

BUG=722553
TEST=None
TBR=xiyuan@chromium.org for a small non-behavioral change in
chrome/browser/chromeos/login/users/wallpaper/wallpaper_window_state_manager.cc

Review-Url: https://codereview.chromium.org/2895713002
Cr-Commit-Position: refs/heads/master@{#474310}
Committed:
https://chromium.googlesource.com/chromium/src/+/843aa52b01713a6605988ab3ee10...
==========

[commit-bot: I haz the power, 2017-05-24 16:06:21]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/843aa52b01713a6605988ab3ee10...

[varkha, 2017-05-24 16:09:13]

Description was changed from

==========
[mus+ash] Removes WmWindow from ash/wm/mru_window_tracker and overview

WIP - uploading to give visibility into what I am doing here.
Refactoring mru_window_tracker and connected classes to remove use of
WmWindow.

BUG=722553
TEST=None
TBR=xiyuan@chromium.org for a small non-behavioral change in
chrome/browser/chromeos/login/users/wallpaper/wallpaper_window_state_manager.cc

Review-Url: https://codereview.chromium.org/2895713002
Cr-Commit-Position: refs/heads/master@{#474310}
Committed:
https://chromium.googlesource.com/chromium/src/+/843aa52b01713a6605988ab3ee10...
==========

to

==========
[mus+ash] Removes WmWindow from ash/wm/mru_window_tracker and overview

Refactoring mru_window_tracker and connected classes to remove use of
WmWindow.

BUG=722553
TEST=None
TBR=xiyuan@chromium.org for a small non-behavioral change in
chrome/browser/chromeos/login/users/wallpaper/wallpaper_window_state_manager.cc

Review-Url: https://codereview.chromium.org/2895713002
Cr-Commit-Position: refs/heads/master@{#474310}
Committed:
https://chromium.googlesource.com/chromium/src/+/843aa52b01713a6605988ab3ee10...
==========

[varkha, 2017-05-24 17:26:33]

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/overview/scoped_...
File ash/wm/overview/scoped_overview_animation_settings_factory_aura.h (right):

https://codereview.chromium.org/2895713002/diff/80001/ash/wm/overview/scoped_...
ash/wm/overview/scoped_overview_animation_settings_factory_aura.h:16: class
ScopedOverviewAnimationSettingsFactoryAura
On 2017/05/24 15:29:15, varkha wrote:
> On 2017/05/23 22:50:24, msw wrote:
> > aside: This is *super* ripe for cleanup, but feel free to punt that for now.
> 
> I'll do it in a follow-up, it seems isolated enough.

Update - done in https://codereview.chromium.org/2901903003/ .