chrome/browser/chromeos/login/users/wallpaper/wallpaper_window_state_manager.cc - Issue 2895713002: [mus+ash] Removes WmWindow from ash/wm/mru_window_tracker and overview mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/users/wallpaper/wallpaper_window_state_manager.cc

Issue 2895713002: [mus+ash] Removes WmWindow from ash/wm/mru_window_tracker and overview mode (Closed)

Patch Set: Address nits, unit_tests target compiles Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ash/wm/maximize_mode/maximize_mode_window_manager.cc ('K') | « ash/wm/workspace/workspace_layout_manager.cc ('k') | chrome/browser/ui/ash/chrome_shell_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/users/wallpaper/wallpaper_window_state_manager.cc

diff --git a/chrome/browser/chromeos/login/users/wallpaper/wallpaper_window_state_manager.cc b/chrome/browser/chromeos/login/users/wallpaper/wallpaper_window_state_manager.cc

index 21b46710f4787ad4320a598a6f3b756b7e705afa..a3e279490f32dc8b4d46419cac75922f2a6a9f28 100644

--- a/chrome/browser/chromeos/login/users/wallpaper/wallpaper_window_state_manager.cc

+++ b/chrome/browser/chromeos/login/users/wallpaper/wallpaper_window_state_manager.cc

@@ -66,10 +66,10 @@ void WallpaperWindowStateManager::BuildWindowListAndMinimizeInactiveForUser(

std::set<aura::Window*>* results =

&user_id_hash_window_list_map_[user_id_hash];

- std::vector<aura::Window*> windows = ash::WmWindow::ToAuraWindows(

- ash::Shell::Get()->mru_window_tracker()->BuildWindowListIgnoreModal());

+ aura::Window::Windows windows =

+ ash::Shell::Get()->mru_window_tracker()->BuildWindowListIgnoreModal();

- for (std::vector<aura::Window*>::iterator iter = windows.begin();

+ for (aura::Window::Windows::iterator iter = windows.begin();

iter != windows.end(); ++iter) {

// Ignore active window and minimized windows.

if (*iter == active_window || ash::wm::GetWindowState(*iter)->IsMinimized())