ash/wm/overview/window_selector_controller.cc - Issue 2895713002: [mus+ash] Removes WmWindow from ash/wm/mru_window_tracker and overview mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/overview/window_selector_controller.cc

Issue 2895713002: [mus+ash] Removes WmWindow from ash/wm/mru_window_tracker and overview mode (Closed)

Patch Set: Address nits, unit_tests target compiles Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/wm/overview/window_selector_controller.cc

diff --git a/ash/wm/overview/window_selector_controller.cc b/ash/wm/overview/window_selector_controller.cc

index 006a1a7fbfc5a26c6a663c0a4832d0bd4522a64b..80efd79e8da05b3136feb39b719c9946dd3334c1 100644

--- a/ash/wm/overview/window_selector_controller.cc

+++ b/ash/wm/overview/window_selector_controller.cc

@@ -49,8 +49,7 @@ bool WindowSelectorController::ToggleOverview() {

if (!CanSelect())

return false;

- std::vector<WmWindow*> windows =

- Shell::Get()->mru_window_tracker()->BuildMruWindowList();

+ auto windows = Shell::Get()->mru_window_tracker()->BuildMruWindowList();

auto end =

std::remove_if(windows.begin(), windows.end(),

std::not1(std::ptr_fun(&WindowSelector::IsSelectable)));