chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc - Issue 2895713002: [mus+ash] Removes WmWindow from ash/wm/mru_window_tracker and overview mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc

Issue 2895713002: [mus+ash] Removes WmWindow from ash/wm/mru_window_tracker and overview mode (Closed)

Patch Set: Address nits, unit_tests target compiles Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ash/wm/maximize_mode/maximize_mode_window_manager.cc ('K') | « chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc ('k') | chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc

diff --git a/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc b/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc

index 326719fc54a6e4f65ce8fb5e857de61c053dc1e4..99a8b0763eadb9ce24fdf5bbb9f438f9d4d2f6e5 100644

--- a/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc

+++ b/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc

@@ -687,10 +687,8 @@ void MultiUserWindowManagerChromeOS::SetWindowVisible(

// are not user activatable. Since invisible windows are not being tracked,

// we tell it to maximize / track this window now before it gets shown, to

// reduce animation jank from multiple resizes.

- if (visible) {

- ash::Shell::Get()->maximize_mode_controller()->AddWindow(

- ash::WmWindow::Get(window));

- }

+ if (visible)

+ ash::Shell::Get()->maximize_mode_controller()->AddWindow(window);

AnimationSetter animation_setter(

window,