Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2893953002: Revert of Remove ScopedVector from all other codes in media/ (Closed)

Created:
3 years, 7 months ago by Greg Levin
Modified:
3 years, 7 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, posciak+watch_chromium.org, yzshen+watch_chromium.org, apacible+watch_chromium.org, alokp+watch_chromium.org, mfoltz+watch_chromium.org, mlamouri+watch-media_chromium.org, miu+watch_chromium.org, toyoshim+midi_chromium.org, lcwu+watch_chromium.org, jam, abarth-chromium, eme-reviews_chromium.org, darin-cc_chromium.org, halliwell+watch_chromium.org, xjz+watch_chromium.org, mlamouri+watch-content_chromium.org, feature-media-reviews_chromium.org, piman+watch_chromium.org, avayvod+watch_chromium.org, Aaron Boodman, darin (slow to review), erickung+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove ScopedVector from all other codes in media/ (patchset #2 id:20001 of https://codereview.chromium.org/2891683002/ ) Reason for revert: Changes to jpeg_decode_accelerator_unittest.cc don't compile in build target "jpeg_decode_accelerator_unittest". Original issue's description: > Remove ScopedVector from all other codes in media/ > > base::ScopedVector is deprecated, see bug. > > BUG=554289, 588249 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2891683002 > Cr-Commit-Position: refs/heads/master@{#472700} > Committed: https://chromium.googlesource.com/chromium/src/+/60c246a6e0e6e0423d8b183c6143f9ce3e18b091 TBR=xhwang@chromium.org,alokp@chromium.org,bbudge@chromium.org,xiaofeng.zhang@intel.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=554289, 588249 Review-Url: https://codereview.chromium.org/2893953002 Cr-Commit-Position: refs/heads/master@{#472818} Committed: https://chromium.googlesource.com/chromium/src/+/af28b6ff67b45355fdea16f239fa507dcb4f1315

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -124 lines) Patch
M chromecast/media/cdm/cast_cdm.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M content/renderer/pepper/content_decryptor_delegate.cc View 2 chunks +1 line, -2 lines 0 comments Download
M media/base/android/media_drm_bridge.cc View 2 chunks +1 line, -3 lines 0 comments Download
M media/base/content_decryption_module.h View 2 chunks +2 lines, -1 line 0 comments Download
M media/blink/cdm_session_adapter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/blink/webcontentdecryptionmodulesession_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cdm/aes_decryptor.cc View 2 chunks +1 line, -3 lines 0 comments Download
M media/cdm/aes_decryptor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cdm/cdm_adapter.cc View 2 chunks +1 line, -2 lines 0 comments Download
M media/cdm/ppapi/external_clear_key/clear_key_cdm.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M media/formats/webm/opus_packet_builder.h View 2 chunks +2 lines, -1 line 0 comments Download
M media/formats/webm/opus_packet_builder.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M media/formats/webm/webm_cluster_parser_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/gpu/jpeg_decode_accelerator_unittest.cc View 6 chunks +10 lines, -11 lines 0 comments Download
M media/gpu/video_encode_accelerator_unittest.cc View 11 chunks +21 lines, -22 lines 0 comments Download
M media/midi/midi_device_android.h View 3 chunks +5 lines, -8 lines 0 comments Download
M media/midi/midi_device_android.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M media/midi/midi_manager_android.h View 2 chunks +2 lines, -1 line 0 comments Download
M media/midi/midi_manager_android.cc View 3 chunks +14 lines, -16 lines 0 comments Download
M media/midi/midi_manager_unittest.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M media/midi/midi_manager_usb.h View 2 chunks +3 lines, -4 lines 0 comments Download
M media/midi/midi_manager_usb.cc View 5 chunks +5 lines, -7 lines 0 comments Download
M media/midi/midi_manager_usb_unittest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M media/midi/usb_midi_device.h View 2 chunks +2 lines, -1 line 0 comments Download
M media/midi/usb_midi_device_factory_android.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M media/mojo/clients/mojo_cdm.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/mojo/services/mojo_cdm_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/remoting/proto_utils.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Greg Levin
Created Revert of Remove ScopedVector from all other codes in media/
3 years, 7 months ago (2017-05-18 15:17:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893953002/1
3 years, 7 months ago (2017-05-18 15:18:14 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 15:19:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/af28b6ff67b45355fdea16f239fa...

Powered by Google App Engine
This is Rietveld 408576698