| Index: media/midi/midi_manager_android.cc
|
| diff --git a/media/midi/midi_manager_android.cc b/media/midi/midi_manager_android.cc
|
| index 4c085b362148c9f186c18d6b8ff8c54ef21e24fb..8ba58b735fae3a7194349f40cbb8d679171a9282 100644
|
| --- a/media/midi/midi_manager_android.cc
|
| +++ b/media/midi/midi_manager_android.cc
|
| @@ -155,18 +155,16 @@
|
| void MidiManagerAndroid::OnDetached(JNIEnv* env,
|
| const JavaParamRef<jobject>& caller,
|
| const JavaParamRef<jobject>& raw_device) {
|
| - for (auto& device : devices_) {
|
| + for (auto* device : devices_) {
|
| if (device->HasRawDevice(env, raw_device)) {
|
| - for (auto& port : device->input_ports()) {
|
| - DCHECK(input_port_to_index_.end() !=
|
| - input_port_to_index_.find(port.get()));
|
| - size_t index = input_port_to_index_[port.get()];
|
| + for (auto* port : device->input_ports()) {
|
| + DCHECK(input_port_to_index_.end() != input_port_to_index_.find(port));
|
| + size_t index = input_port_to_index_[port];
|
| SetInputPortState(index, PortState::DISCONNECTED);
|
| }
|
| - for (auto& port : device->output_ports()) {
|
| - DCHECK(output_port_to_index_.end() !=
|
| - output_port_to_index_.find(port.get()));
|
| - size_t index = output_port_to_index_[port.get()];
|
| + for (auto* port : device->output_ports()) {
|
| + DCHECK(output_port_to_index_.end() != output_port_to_index_.find(port));
|
| + size_t index = output_port_to_index_[port];
|
| SetOutputPortState(index, PortState::DISCONNECTED);
|
| }
|
| }
|
| @@ -174,28 +172,28 @@
|
| }
|
|
|
| void MidiManagerAndroid::AddDevice(std::unique_ptr<MidiDeviceAndroid> device) {
|
| - for (auto& port : device->input_ports()) {
|
| + for (auto* port : device->input_ports()) {
|
| // We implicitly open input ports here, because there are no signal
|
| // from the renderer when to open.
|
| // TODO(yhirano): Implement open operation in Blink.
|
| PortState state = port->Open() ? PortState::OPENED : PortState::CONNECTED;
|
|
|
| const size_t index = all_input_ports_.size();
|
| - all_input_ports_.push_back(port.get());
|
| + all_input_ports_.push_back(port);
|
| // Port ID must be unique in a MIDI manager. This ID setting is
|
| // sufficiently unique although there is no user-friendly meaning.
|
| // TODO(yhirano): Use a hashed string as ID.
|
| const std::string id(
|
| base::StringPrintf("native:port-in-%ld", static_cast<long>(index)));
|
|
|
| - input_port_to_index_.insert(std::make_pair(port.get(), index));
|
| + input_port_to_index_.insert(std::make_pair(port, index));
|
| AddInputPort(MidiPortInfo(id, device->GetManufacturer(),
|
| device->GetProductName(),
|
| device->GetDeviceVersion(), state));
|
| }
|
| - for (auto& port : device->output_ports()) {
|
| + for (auto* port : device->output_ports()) {
|
| const size_t index = all_output_ports_.size();
|
| - all_output_ports_.push_back(port.get());
|
| + all_output_ports_.push_back(port);
|
|
|
| // Port ID must be unique in a MIDI manager. This ID setting is
|
| // sufficiently unique although there is no user-friendly meaning.
|
| @@ -203,12 +201,12 @@
|
| const std::string id(
|
| base::StringPrintf("native:port-out-%ld", static_cast<long>(index)));
|
|
|
| - output_port_to_index_.insert(std::make_pair(port.get(), index));
|
| + output_port_to_index_.insert(std::make_pair(port, index));
|
| AddOutputPort(
|
| MidiPortInfo(id, device->GetManufacturer(), device->GetProductName(),
|
| device->GetDeviceVersion(), PortState::CONNECTED));
|
| }
|
| - devices_.push_back(std::move(device));
|
| + devices_.push_back(device.release());
|
| }
|
|
|
| bool MidiManagerAndroid::Register(JNIEnv* env) {
|
|
|