Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: media/midi/midi_manager_android.h

Issue 2893953002: Revert of Remove ScopedVector from all other codes in media/ (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « media/midi/midi_device_android.cc ('k') | media/midi/midi_manager_android.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MEDIA_MIDI_MIDI_MANAGER_ANDROID_H_ 5 #ifndef MEDIA_MIDI_MIDI_MANAGER_ANDROID_H_
6 #define MEDIA_MIDI_MIDI_MANAGER_ANDROID_H_ 6 #define MEDIA_MIDI_MIDI_MANAGER_ANDROID_H_
7 7
8 #include <jni.h> 8 #include <jni.h>
9 #include <stddef.h> 9 #include <stddef.h>
10 #include <stdint.h> 10 #include <stdint.h>
11 11
12 #include <memory> 12 #include <memory>
13 #include <vector> 13 #include <vector>
14 14
15 #include "base/android/scoped_java_ref.h" 15 #include "base/android/scoped_java_ref.h"
16 #include "base/containers/hash_tables.h" 16 #include "base/containers/hash_tables.h"
17 #include "base/memory/scoped_vector.h"
17 #include "base/synchronization/lock.h" 18 #include "base/synchronization/lock.h"
18 #include "base/time/time.h" 19 #include "base/time/time.h"
19 #include "media/midi/midi_input_port_android.h" 20 #include "media/midi/midi_input_port_android.h"
20 #include "media/midi/midi_manager.h" 21 #include "media/midi/midi_manager.h"
21 #include "media/midi/midi_scheduler.h" 22 #include "media/midi/midi_scheduler.h"
22 23
23 namespace midi { 24 namespace midi {
24 25
25 class MidiDeviceAndroid; 26 class MidiDeviceAndroid;
26 class MidiOutputPortAndroid; 27 class MidiOutputPortAndroid;
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 65
65 static bool Register(JNIEnv* env); 66 static bool Register(JNIEnv* env);
66 67
67 private: 68 private:
68 void AddDevice(std::unique_ptr<MidiDeviceAndroid> device); 69 void AddDevice(std::unique_ptr<MidiDeviceAndroid> device);
69 void AddInputPortAndroid(MidiInputPortAndroid* port, 70 void AddInputPortAndroid(MidiInputPortAndroid* port,
70 MidiDeviceAndroid* device); 71 MidiDeviceAndroid* device);
71 void AddOutputPortAndroid(MidiOutputPortAndroid* port, 72 void AddOutputPortAndroid(MidiOutputPortAndroid* port,
72 MidiDeviceAndroid* device); 73 MidiDeviceAndroid* device);
73 74
74 std::vector<std::unique_ptr<MidiDeviceAndroid>> devices_; 75 ScopedVector<MidiDeviceAndroid> devices_;
75 // All ports held in |devices_|. Each device has ownership of ports, but we 76 // All ports held in |devices_|. Each device has ownership of ports, but we
76 // can store pointers here because a device will keep its ports while it is 77 // can store pointers here because a device will keep its ports while it is
77 // alive. 78 // alive.
78 std::vector<MidiInputPortAndroid*> all_input_ports_; 79 std::vector<MidiInputPortAndroid*> all_input_ports_;
79 // A dictionary from a port to its index. 80 // A dictionary from a port to its index.
80 // input_port_to_index_[all_input_ports_[i]] == i for each valid |i|. 81 // input_port_to_index_[all_input_ports_[i]] == i for each valid |i|.
81 base::hash_map<MidiInputPortAndroid*, size_t> input_port_to_index_; 82 base::hash_map<MidiInputPortAndroid*, size_t> input_port_to_index_;
82 83
83 // Ditto for output ports. 84 // Ditto for output ports.
84 std::vector<MidiOutputPortAndroid*> all_output_ports_; 85 std::vector<MidiOutputPortAndroid*> all_output_ports_;
85 base::hash_map<MidiOutputPortAndroid*, size_t> output_port_to_index_; 86 base::hash_map<MidiOutputPortAndroid*, size_t> output_port_to_index_;
86 87
87 base::android::ScopedJavaGlobalRef<jobject> raw_manager_; 88 base::android::ScopedJavaGlobalRef<jobject> raw_manager_;
88 89
89 // Lock to ensure the MidiScheduler is being destructed only once in 90 // Lock to ensure the MidiScheduler is being destructed only once in
90 // Finalize() on Chrome_IOThread. 91 // Finalize() on Chrome_IOThread.
91 base::Lock scheduler_lock_; 92 base::Lock scheduler_lock_;
92 std::unique_ptr<MidiScheduler> scheduler_; // GUARDED_BY(scheduler_lock_) 93 std::unique_ptr<MidiScheduler> scheduler_; // GUARDED_BY(scheduler_lock_)
93 }; 94 };
94 95
95 } // namespace midi 96 } // namespace midi
96 97
97 #endif // MEDIA_MIDI_MIDI_MANAGER_ANDROID_H_ 98 #endif // MEDIA_MIDI_MIDI_MANAGER_ANDROID_H_
OLDNEW
« no previous file with comments | « media/midi/midi_device_android.cc ('k') | media/midi/midi_manager_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698