Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: media/midi/usb_midi_device_factory_android.cc

Issue 2893953002: Revert of Remove ScopedVector from all other codes in media/ (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « media/midi/usb_midi_device.h ('k') | media/mojo/clients/mojo_cdm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/midi/usb_midi_device_factory_android.h" 5 #include "media/midi/usb_midi_device_factory_android.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include "base/android/context_utils.h" 9 #include "base/android/context_utils.h"
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 45
46 delegate_ = delegate; 46 delegate_ = delegate;
47 callback_ = callback; 47 callback_ = callback;
48 48
49 if (Java_UsbMidiDeviceFactoryAndroid_enumerateDevices( 49 if (Java_UsbMidiDeviceFactoryAndroid_enumerateDevices(
50 env, raw_factory_, base::android::GetApplicationContext())) { 50 env, raw_factory_, base::android::GetApplicationContext())) {
51 // Asynchronous operation. 51 // Asynchronous operation.
52 return; 52 return;
53 } 53 }
54 // No devices are found. 54 // No devices are found.
55 UsbMidiDevice::Devices devices; 55 ScopedVector<UsbMidiDevice> devices;
56 callback.Run(true, &devices); 56 callback.Run(true, &devices);
57 } 57 }
58 58
59 // Called from the Java world. 59 // Called from the Java world.
60 void UsbMidiDeviceFactoryAndroid::OnUsbMidiDeviceRequestDone( 60 void UsbMidiDeviceFactoryAndroid::OnUsbMidiDeviceRequestDone(
61 JNIEnv* env, 61 JNIEnv* env,
62 const JavaParamRef<jobject>& caller, 62 const JavaParamRef<jobject>& caller,
63 const JavaParamRef<jobjectArray>& devices) { 63 const JavaParamRef<jobjectArray>& devices) {
64 size_t size = env->GetArrayLength(devices); 64 size_t size = env->GetArrayLength(devices);
65 UsbMidiDevice::Devices devices_to_pass; 65 ScopedVector<UsbMidiDevice> devices_to_pass;
66 for (size_t i = 0; i < size; ++i) { 66 for (size_t i = 0; i < size; ++i) {
67 base::android::ScopedJavaLocalRef<jobject> raw_device( 67 base::android::ScopedJavaLocalRef<jobject> raw_device(
68 env, env->GetObjectArrayElement(devices, i)); 68 env, env->GetObjectArrayElement(devices, i));
69 devices_to_pass.push_back( 69 devices_to_pass.push_back(new UsbMidiDeviceAndroid(raw_device, delegate_));
70 base::MakeUnique<UsbMidiDeviceAndroid>(raw_device, delegate_));
71 } 70 }
72 71
73 callback_.Run(true, &devices_to_pass); 72 callback_.Run(true, &devices_to_pass);
74 } 73 }
75 74
76 // Called from the Java world. 75 // Called from the Java world.
77 void UsbMidiDeviceFactoryAndroid::OnUsbMidiDeviceAttached( 76 void UsbMidiDeviceFactoryAndroid::OnUsbMidiDeviceAttached(
78 JNIEnv* env, 77 JNIEnv* env,
79 const JavaParamRef<jobject>& caller, 78 const JavaParamRef<jobject>& caller,
80 const JavaParamRef<jobject>& device) { 79 const JavaParamRef<jobject>& device) {
81 delegate_->OnDeviceAttached( 80 delegate_->OnDeviceAttached(
82 base::MakeUnique<UsbMidiDeviceAndroid>(device, delegate_)); 81 base::MakeUnique<UsbMidiDeviceAndroid>(device, delegate_));
83 } 82 }
84 83
85 // Called from the Java world. 84 // Called from the Java world.
86 void UsbMidiDeviceFactoryAndroid::OnUsbMidiDeviceDetached( 85 void UsbMidiDeviceFactoryAndroid::OnUsbMidiDeviceDetached(
87 JNIEnv* env, 86 JNIEnv* env,
88 const JavaParamRef<jobject>& caller, 87 const JavaParamRef<jobject>& caller,
89 jint index) { 88 jint index) {
90 delegate_->OnDeviceDetached(index); 89 delegate_->OnDeviceDetached(index);
91 } 90 }
92 91
93 bool UsbMidiDeviceFactoryAndroid::RegisterUsbMidiDeviceFactory(JNIEnv* env) { 92 bool UsbMidiDeviceFactoryAndroid::RegisterUsbMidiDeviceFactory(JNIEnv* env) {
94 return RegisterNativesImpl(env); 93 return RegisterNativesImpl(env);
95 } 94 }
96 95
97 } // namespace midi 96 } // namespace midi
OLDNEW
« no previous file with comments | « media/midi/usb_midi_device.h ('k') | media/mojo/clients/mojo_cdm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698