Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Side by Side Diff: media/midi/midi_manager_usb.cc

Issue 2893953002: Revert of Remove ScopedVector from all other codes in media/ (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « media/midi/midi_manager_usb.h ('k') | media/midi/midi_manager_usb_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/midi/midi_manager_usb.h" 5 #include "media/midi/midi_manager_usb.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/memory/ptr_util.h"
11 #include "base/message_loop/message_loop.h" 10 #include "base/message_loop/message_loop.h"
12 #include "base/strings/stringprintf.h" 11 #include "base/strings/stringprintf.h"
13 #include "media/midi/midi_scheduler.h" 12 #include "media/midi/midi_scheduler.h"
14 #include "media/midi/usb_midi_descriptor_parser.h" 13 #include "media/midi/usb_midi_descriptor_parser.h"
15 14
16 namespace midi { 15 namespace midi {
17 16
18 using mojom::PortState; 17 using mojom::PortState;
19 using mojom::Result; 18 using mojom::Result;
20 19
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 // |port_index| is provided by a renderer so we can't believe that it is 60 // |port_index| is provided by a renderer so we can't believe that it is
62 // in the valid range. 61 // in the valid range.
63 return; 62 return;
64 } 63 }
65 // output_streams_[port_index] is alive unless MidiManagerUsb is deleted. 64 // output_streams_[port_index] is alive unless MidiManagerUsb is deleted.
66 // The task posted to the MidiScheduler will be disposed safely on deleting 65 // The task posted to the MidiScheduler will be disposed safely on deleting
67 // the scheduler. 66 // the scheduler.
68 scheduler_->PostSendDataTask( 67 scheduler_->PostSendDataTask(
69 client, data.size(), timestamp, 68 client, data.size(), timestamp,
70 base::Bind(&UsbMidiOutputStream::Send, 69 base::Bind(&UsbMidiOutputStream::Send,
71 base::Unretained(output_streams_[port_index].get()), data)); 70 base::Unretained(output_streams_[port_index]), data));
72 } 71 }
73 72
74 void MidiManagerUsb::ReceiveUsbMidiData(UsbMidiDevice* device, 73 void MidiManagerUsb::ReceiveUsbMidiData(UsbMidiDevice* device,
75 int endpoint_number, 74 int endpoint_number,
76 const uint8_t* data, 75 const uint8_t* data,
77 size_t size, 76 size_t size,
78 base::TimeTicks time) { 77 base::TimeTicks time) {
79 if (!input_stream_) 78 if (!input_stream_)
80 return; 79 return;
81 input_stream_->OnReceivedData(device, 80 input_stream_->OnReceivedData(device,
82 endpoint_number, 81 endpoint_number,
83 data, 82 data,
84 size, 83 size,
85 time); 84 time);
86 } 85 }
87 86
88 void MidiManagerUsb::OnDeviceAttached(std::unique_ptr<UsbMidiDevice> device) { 87 void MidiManagerUsb::OnDeviceAttached(std::unique_ptr<UsbMidiDevice> device) {
89 int device_id = static_cast<int>(devices_.size()); 88 int device_id = static_cast<int>(devices_.size());
90 devices_.push_back(std::move(device)); 89 devices_.push_back(std::move(device));
91 AddPorts(devices_.back().get(), device_id); 90 AddPorts(devices_.back(), device_id);
92 } 91 }
93 92
94 void MidiManagerUsb::OnDeviceDetached(size_t index) { 93 void MidiManagerUsb::OnDeviceDetached(size_t index) {
95 if (index >= devices_.size()) { 94 if (index >= devices_.size()) {
96 return; 95 return;
97 } 96 }
98 UsbMidiDevice* device = devices_[index].get(); 97 UsbMidiDevice* device = devices_[index];
99 for (size_t i = 0; i < output_streams_.size(); ++i) { 98 for (size_t i = 0; i < output_streams_.size(); ++i) {
100 if (output_streams_[i]->jack().device == device) { 99 if (output_streams_[i]->jack().device == device) {
101 SetOutputPortState(static_cast<uint32_t>(i), PortState::DISCONNECTED); 100 SetOutputPortState(static_cast<uint32_t>(i), PortState::DISCONNECTED);
102 } 101 }
103 } 102 }
104 const std::vector<UsbMidiJack>& input_jacks = input_stream_->jacks(); 103 const std::vector<UsbMidiJack>& input_jacks = input_stream_->jacks();
105 for (size_t i = 0; i < input_jacks.size(); ++i) { 104 for (size_t i = 0; i < input_jacks.size(); ++i) {
106 if (input_jacks[i].device == device) { 105 if (input_jacks[i].device == device) {
107 SetInputPortState(static_cast<uint32_t>(i), PortState::DISCONNECTED); 106 SetInputPortState(static_cast<uint32_t>(i), PortState::DISCONNECTED);
108 } 107 }
(...skipping 10 matching lines...) Expand all
119 118
120 void MidiManagerUsb::OnEnumerateDevicesDone(bool result, 119 void MidiManagerUsb::OnEnumerateDevicesDone(bool result,
121 UsbMidiDevice::Devices* devices) { 120 UsbMidiDevice::Devices* devices) {
122 if (!result) { 121 if (!result) {
123 initialize_callback_.Run(Result::INITIALIZATION_ERROR); 122 initialize_callback_.Run(Result::INITIALIZATION_ERROR);
124 return; 123 return;
125 } 124 }
126 input_stream_.reset(new UsbMidiInputStream(this)); 125 input_stream_.reset(new UsbMidiInputStream(this));
127 devices->swap(devices_); 126 devices->swap(devices_);
128 for (size_t i = 0; i < devices_.size(); ++i) { 127 for (size_t i = 0; i < devices_.size(); ++i) {
129 if (!AddPorts(devices_[i].get(), static_cast<int>(i))) { 128 if (!AddPorts(devices_[i], static_cast<int>(i))) {
130 initialize_callback_.Run(Result::INITIALIZATION_ERROR); 129 initialize_callback_.Run(Result::INITIALIZATION_ERROR);
131 return; 130 return;
132 } 131 }
133 } 132 }
134 initialize_callback_.Run(Result::OK); 133 initialize_callback_.Run(Result::OK);
135 } 134 }
136 135
137 bool MidiManagerUsb::AddPorts(UsbMidiDevice* device, int device_id) { 136 bool MidiManagerUsb::AddPorts(UsbMidiDevice* device, int device_id) {
138 UsbMidiDescriptorParser parser; 137 UsbMidiDescriptorParser parser;
139 std::vector<uint8_t> descriptor = device->GetDescriptors(); 138 std::vector<uint8_t> descriptor = device->GetDescriptors();
(...skipping 10 matching lines...) Expand all
150 std::string product_name(device->GetProductName()); 149 std::string product_name(device->GetProductName());
151 std::string version(device->GetDeviceVersion()); 150 std::string version(device->GetDeviceVersion());
152 151
153 for (size_t j = 0; j < jacks.size(); ++j) { 152 for (size_t j = 0; j < jacks.size(); ++j) {
154 // Port ID must be unique in a MIDI manager. This ID setting is 153 // Port ID must be unique in a MIDI manager. This ID setting is
155 // sufficiently unique although there is no user-friendly meaning. 154 // sufficiently unique although there is no user-friendly meaning.
156 // TODO(yhirano): Use a hashed string as ID. 155 // TODO(yhirano): Use a hashed string as ID.
157 std::string id( 156 std::string id(
158 base::StringPrintf("usb:port-%d-%ld", device_id, static_cast<long>(j))); 157 base::StringPrintf("usb:port-%d-%ld", device_id, static_cast<long>(j)));
159 if (jacks[j].direction() == UsbMidiJack::DIRECTION_OUT) { 158 if (jacks[j].direction() == UsbMidiJack::DIRECTION_OUT) {
160 output_streams_.push_back( 159 output_streams_.push_back(new UsbMidiOutputStream(jacks[j]));
161 base::MakeUnique<UsbMidiOutputStream>(jacks[j]));
162 AddOutputPort(MidiPortInfo(id, manufacturer, product_name, version, 160 AddOutputPort(MidiPortInfo(id, manufacturer, product_name, version,
163 PortState::OPENED)); 161 PortState::OPENED));
164 } else { 162 } else {
165 DCHECK_EQ(jacks[j].direction(), UsbMidiJack::DIRECTION_IN); 163 DCHECK_EQ(jacks[j].direction(), UsbMidiJack::DIRECTION_IN);
166 input_stream_->Add(jacks[j]); 164 input_stream_->Add(jacks[j]);
167 AddInputPort(MidiPortInfo(id, manufacturer, product_name, version, 165 AddInputPort(MidiPortInfo(id, manufacturer, product_name, version,
168 PortState::OPENED)); 166 PortState::OPENED));
169 } 167 }
170 } 168 }
171 return true; 169 return true;
172 } 170 }
173 171
174 } // namespace midi 172 } // namespace midi
OLDNEW
« no previous file with comments | « media/midi/midi_manager_usb.h ('k') | media/midi/midi_manager_usb_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698