Remove ScopedVector from all other codes in media/

Remove ScopedVector from all other codes in media/

base::ScopedVector is deprecated, see bug.

BUG=554289, 588249
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2891683002
Cr-Commit-Position: refs/heads/master@{#472700}
Committed: https://chromium.googlesource.com/chromium/src/+/60c246a6e0e6e0423d8b183c6143f9ce3e18b091

[xiaofengzhang, 2017-05-17 04:49:40]

Description was changed from

==========
Remove ScopedVector from all other codes in media/

base::ScopedVector is deprecated, see bug.

BUG=554289, 588249
==========

to

==========
Remove ScopedVector from all other codes in media/

base::ScopedVector is deprecated, see bug.

BUG=554289, 588249
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[xiaofengzhang, 2017-05-17 04:50:18]

The CQ bit was checked by xiaofeng.zhang@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 04:51:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 06:30:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 06:30:09]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xiaofengzhang, 2017-05-17 08:54:47]

xiaofeng.zhang@intel.com changed reviewers:
+ xhwang@chromium.org

[xiaofengzhang, 2017-05-17 08:54:48]

Hi xhwang, please help to review, thanks!

[xiaofengzhang, 2017-05-17 09:00:39]

xiaofeng.zhang@intel.com changed reviewers:
+ alokp@chromium.org, bbudge@chromium.org

[xiaofengzhang, 2017-05-17 09:00:39]

alokp@, could you help to review as the owner of
chromecast/media/cdm/cast_cdm.cc? Thanks.

bbudge@ could you help to review as the owner of
	content/renderer/pepper/content_decryptor_delegate.cc? Thanks.

[alokp, 2017-05-17 12:07:02]

chromecast/ lgtm % nit

https://codereview.chromium.org/2891683002/diff/1/chromecast/media/cdm/cast_c...
File chromecast/media/cdm/cast_cdm.cc (right):

https://codereview.chromium.org/2891683002/diff/1/chromecast/media/cdm/cast_c...
chromecast/media/cdm/cast_cdm.cc:159: auto
cdm_key_information(base::MakeUnique<::media::CdmKeyInformation>(
nit: the two lines can now be combined:

keys_info->push_back(base::MakeUnique<::media::CdmKeyInformation>());

[bbudge, 2017-05-17 13:00:40]

content/renderer/pepper lgtm

[xhwang, 2017-05-17 16:39:45]

Thank you again for working on this! Code health is very important and I am so
happy we have your help.

The CL looks mostly good, I only have a few minor comments/nits.

https://codereview.chromium.org/2891683002/diff/1/media/base/android/media_dr...
File media/base/android/media_drm_bridge.cc (right):

https://codereview.chromium.org/2891683002/diff/1/media/base/android/media_dr...
media/base/android/media_drm_bridge.cc:744:
base::MakeUnique<CdmKeyInformation>(key_id, key_status, 0));
Here and everywhere else, include base/memory/ptr_util.h for MakeUnique.

https://codereview.chromium.org/2891683002/diff/1/media/cdm/ppapi/external_cl...
File media/cdm/ppapi/external_clear_key/clear_key_cdm.cc (right):

https://codereview.chromium.org/2891683002/diff/1/media/cdm/ppapi/external_cl...
media/cdm/ppapi/external_clear_key/clear_key_cdm.cc:881:
ConvertCdmKeysInfo(ConvertToRawPtrVector(keys_info), &keys_vector);
Instead of adding ConvertToRawPtrVector(), can you just update
ConvertCdmKeysInfo() which should be easier?

https://codereview.chromium.org/2891683002/diff/1/media/formats/webm/opus_pac...
File media/formats/webm/opus_packet_builder.cc (right):

https://codereview.chromium.org/2891683002/diff/1/media/formats/webm/opus_pac...
media/formats/webm/opus_packet_builder.cc:5: #include
"media/formats/webm/opus_packet_builder.h"
nit: add an empty line here

https://codereview.chromium.org/2891683002/diff/1/media/midi/midi_manager_usb...
File media/midi/midi_manager_usb_unittest.cc (right):

https://codereview.chromium.org/2891683002/diff/1/media/midi/midi_manager_usb...
media/midi/midi_manager_usb_unittest.cc:268:
std::vector<std::unique_ptr<UsbMidiDevice>> devices;
nit: Use UsbMidiDevice::Devices as the type?

https://codereview.chromium.org/2891683002/diff/1/media/midi/usb_midi_device_...
File media/midi/usb_midi_device_factory_android.cc (right):

https://codereview.chromium.org/2891683002/diff/1/media/midi/usb_midi_device_...
media/midi/usb_midi_device_factory_android.cc:55:
std::vector<std::unique_ptr<UsbMidiDevice>> devices;
nit: Use UsbMidiDevice::Devices as the type?

[xiaofengzhang, 2017-05-18 03:02:03]

The CQ bit was checked by xiaofeng.zhang@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 03:05:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 05:42:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 05:42:17]

Dry run: This issue passed the CQ dry run.

[xiaofengzhang, 2017-05-18 05:43:27]

xhwang@, please help review again.

https://codereview.chromium.org/2891683002/diff/1/chromecast/media/cdm/cast_c...
File chromecast/media/cdm/cast_cdm.cc (right):

https://codereview.chromium.org/2891683002/diff/1/chromecast/media/cdm/cast_c...
chromecast/media/cdm/cast_cdm.cc:159: auto
cdm_key_information(base::MakeUnique<::media::CdmKeyInformation>(
On 2017/05/17 12:07:02, alokp wrote:
> nit: the two lines can now be combined:
> 
> keys_info->push_back(base::MakeUnique<::media::CdmKeyInformation>());

Done.

https://codereview.chromium.org/2891683002/diff/1/media/base/android/media_dr...
File media/base/android/media_drm_bridge.cc (right):

https://codereview.chromium.org/2891683002/diff/1/media/base/android/media_dr...
media/base/android/media_drm_bridge.cc:744:
base::MakeUnique<CdmKeyInformation>(key_id, key_status, 0));
On 2017/05/17 16:39:45, xhwang wrote:
> Here and everywhere else, include base/memory/ptr_util.h for MakeUnique.

Done.

https://codereview.chromium.org/2891683002/diff/1/media/cdm/ppapi/external_cl...
File media/cdm/ppapi/external_clear_key/clear_key_cdm.cc (right):

https://codereview.chromium.org/2891683002/diff/1/media/cdm/ppapi/external_cl...
media/cdm/ppapi/external_clear_key/clear_key_cdm.cc:881:
ConvertCdmKeysInfo(ConvertToRawPtrVector(keys_info), &keys_vector);
On 2017/05/17 16:39:45, xhwang wrote:
> Instead of adding ConvertToRawPtrVector(), can you just update
> ConvertCdmKeysInfo() which should be easier?

Done.

https://codereview.chromium.org/2891683002/diff/1/media/formats/webm/opus_pac...
File media/formats/webm/opus_packet_builder.cc (right):

https://codereview.chromium.org/2891683002/diff/1/media/formats/webm/opus_pac...
media/formats/webm/opus_packet_builder.cc:5: #include
"media/formats/webm/opus_packet_builder.h"
On 2017/05/17 16:39:45, xhwang wrote:
> nit: add an empty line here

Done.

https://codereview.chromium.org/2891683002/diff/1/media/midi/midi_manager_usb...
File media/midi/midi_manager_usb_unittest.cc (right):

https://codereview.chromium.org/2891683002/diff/1/media/midi/midi_manager_usb...
media/midi/midi_manager_usb_unittest.cc:268:
std::vector<std::unique_ptr<UsbMidiDevice>> devices;
On 2017/05/17 16:39:45, xhwang wrote:
> nit: Use UsbMidiDevice::Devices as the type?

Done. Very nice!

https://codereview.chromium.org/2891683002/diff/1/media/midi/usb_midi_device_...
File media/midi/usb_midi_device_factory_android.cc (right):

https://codereview.chromium.org/2891683002/diff/1/media/midi/usb_midi_device_...
media/midi/usb_midi_device_factory_android.cc:55:
std::vector<std::unique_ptr<UsbMidiDevice>> devices;
On 2017/05/17 16:39:45, xhwang wrote:
> nit: Use UsbMidiDevice::Devices as the type?

Done.

[xhwang, 2017-05-18 05:59:22]

lgtm

[xiaofengzhang, 2017-05-18 06:00:35]

The CQ bit was checked by xiaofeng.zhang@intel.com

[xiaofengzhang, 2017-05-18 06:00:35]

The patchset sent to the CQ was uploaded after l-g-t-m from bbudge@chromium.org,
alokp@chromium.org
Link to the patchset: https://codereview.chromium.org/2891683002/#ps20001
(title: "Address alokp and xhwang's comments")

[commit-bot: I haz the power, 2017-05-18 06:01:25]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 06:11:00]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495087235040100,
"parent_rev": "c14b45bb07c2f0afe5dfdf3713fecd9e96f312ea", "commit_rev":
"4c66ba1672921f73bde96b1596c550a82b073f8c"}

[commit-bot: I haz the power, 2017-05-18 06:11:17]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495087235040100,
"parent_rev": "268fc24e770401f31288f09d8de7f17d86dc0220", "commit_rev":
"60c246a6e0e6e0423d8b183c6143f9ce3e18b091"}

[commit-bot: I haz the power, 2017-05-18 06:11:28]

Description was changed from

==========
Remove ScopedVector from all other codes in media/

base::ScopedVector is deprecated, see bug.

BUG=554289, 588249
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove ScopedVector from all other codes in media/

base::ScopedVector is deprecated, see bug.

BUG=554289, 588249
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2891683002
Cr-Commit-Position: refs/heads/master@{#472700}
Committed:
https://chromium.googlesource.com/chromium/src/+/60c246a6e0e6e0423d8b183c6143...
==========

[commit-bot: I haz the power, 2017-05-18 06:11:29]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/60c246a6e0e6e0423d8b183c6143...

[Greg Levin, 2017-05-18 15:17:35]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2893953002/ by glevin@chromium.org.

The reason for reverting is: Changes to jpeg_decode_accelerator_unittest.cc
don't compile in build target "jpeg_decode_accelerator_unittest"..