Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Issue 2891603002: [CRD iOS] Trackpad Input Mode (Closed)

Created:
3 years, 7 months ago by Yuwei
Modified:
3 years, 7 months ago
Reviewers:
nicholss
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[CRD iOS] Trackpad Input Mode This CL adds support for the trackpad input mode to the CRD iOS client. It also renames some gestures to be more abstract so that it's easier to do things like using 3D touch for dragging in the future. BUG=718704 Review-Url: https://codereview.chromium.org/2891603002 Cr-Commit-Position: refs/heads/master@{#473012} Committed: https://chromium.googlesource.com/chromium/src/+/e1bd6ca3c206cf48b29523ae64bdfeca06a1e1b6

Patch Set 1 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+326 lines, -87 lines) Patch
M remoting/client/ui/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/client/ui/desktop_viewport.h View 2 chunks +8 lines, -3 lines 0 comments Download
M remoting/client/ui/desktop_viewport.cc View 2 chunks +20 lines, -5 lines 0 comments Download
M remoting/client/ui/direct_input_strategy.h View 1 chunk +5 lines, -5 lines 0 comments Download
M remoting/client/ui/direct_input_strategy.cc View 3 chunks +11 lines, -10 lines 0 comments Download
M remoting/client/ui/gesture_interpreter.h View 3 chunks +29 lines, -14 lines 0 comments Download
M remoting/client/ui/gesture_interpreter.cc View 6 chunks +57 lines, -23 lines 0 comments Download
M remoting/client/ui/input_strategy.h View 1 chunk +15 lines, -9 lines 0 comments Download
M remoting/client/ui/renderer_proxy.cc View 1 chunk +2 lines, -1 line 0 comments Download
A remoting/client/ui/trackpad_input_strategy.h View 1 chunk +50 lines, -0 lines 0 comments Download
A remoting/client/ui/trackpad_input_strategy.cc View 1 chunk +88 lines, -0 lines 0 comments Download
M remoting/ios/app/host_view_controller.mm View 2 chunks +21 lines, -0 lines 0 comments Download
M remoting/ios/client_gestures.mm View 3 chunks +18 lines, -17 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (14 generated)
Yuwei
PTAL thanks! You can still move around the files in client/ui. I can rebase after ...
3 years, 7 months ago (2017-05-17 23:22:10 UTC) #12
nicholss
lgtm
3 years, 7 months ago (2017-05-18 22:00:13 UTC) #13
Yuwei
Thanks!
3 years, 7 months ago (2017-05-18 22:08:07 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891603002/160001
3 years, 7 months ago (2017-05-18 22:09:51 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 01:23:03 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/e1bd6ca3c206cf48b29523ae64bd...

Powered by Google App Engine
This is Rietveld 408576698