[DMC #7] Only create RenderedDocumentMarkers for TextMatchMarkerListImpl

Only create RenderedDocumentMarkers for TextMatchMarkerListImpl

This sets us up to start creating a polymorphic class hierarchy for
DocumentMarker. RenderedDocumentMarker will become TextMatchMarker, and we will
also add subclasses of DocumentMarker for the other MarkerTypes as well.

BUG=715365
Review-Url: https://codereview.chromium.org/2883503004
Cr-Commit-Position: refs/heads/master@{#473345}
Committed: https://chromium.googlesource.com/chromium/src/+/8ee9280525895b4dbb74d3e6117547f79b96d89e

[rlanday, 2017-05-12 21:01:53]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[rlanday, 2017-05-12 21:02:04]

rlanday@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yosin@chromium.org

[commit-bot: I haz the power, 2017-05-12 21:03:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 21:08:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 21:08:44]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Xiaocheng, 2017-05-12 21:16:10]

Looks fine.

https://codereview.chromium.org/2883503004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
(right):

https://codereview.chromium.org/2883503004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp:411:
DocumentMarker::MarkerType marker_type) {
At which step are we going to remove |marker_type|?

[rlanday, 2017-05-12 22:02:55]

https://codereview.chromium.org/2883503004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
(right):

https://codereview.chromium.org/2883503004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp:411:
DocumentMarker::MarkerType marker_type) {
On 2017/05/12 at 21:16:10, Xiaocheng wrote:
> At which step are we going to remove |marker_type|?

I think there's a handful of API changes we want to make...I was thinking I'd
put up a series of patches for them at some point, doesn't really matter when I
guess...

[rlanday, 2017-05-15 18:54:06]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 18:54:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 19:00:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 19:00:54]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[rlanday, 2017-05-17 18:44:52]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 18:46:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 18:51:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 18:51:47]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[rlanday, 2017-05-17 19:01:17]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 19:04:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 21:56:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 21:56:08]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yosin_UTC9, 2017-05-18 05:35:31]

https://codereview.chromium.org/2883503004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
(right):

https://codereview.chromium.org/2883503004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp:411:
DocumentMarker::MarkerType marker_type) {
On 2017/05/12 at 22:02:55, rlanday wrote:
> On 2017/05/12 at 21:16:10, Xiaocheng wrote:
> > At which step are we going to remove |marker_type|?
> 
> I think there's a handful of API changes we want to make...I was thinking I'd
put up a series of patches for them at some point, doesn't really matter when I
guess...

Can we have DCHECK_EQ(marker_type, DocumentMakerType::TextMatch) in this patch?

[rlanday, 2017-05-18 18:43:15]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[rlanday, 2017-05-18 18:43:41]

On 2017/05/18 at 05:35:31, yosin wrote:
> Can we have DCHECK_EQ(marker_type, DocumentMakerType::TextMatch) in this
patch?

Updated (also got rid of a loop and fixed a test case to use TextMatch markers)

[commit-bot: I haz the power, 2017-05-18 18:44:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-05-18 19:15:09]

https://codereview.chromium.org/2883503004/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
(right):

https://codereview.chromium.org/2883503004/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp:466:
void DocumentMarkerController::InvalidateRectsForAllMarkers() {
This function should modify only TextMatch marker lists.

https://codereview.chromium.org/2883503004/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp:476:
ToRenderedDocumentMarker(marker)->Invalidate();
Otherwise this is a bad cast

[rlanday, 2017-05-18 20:29:47]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 20:30:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rlanday, 2017-05-18 20:30:48]

On 2017/05/18 at 19:15:09, xiaochengh wrote:
>
https://codereview.chromium.org/2883503004/diff/60001/third_party/WebKit/Sour...
> File
third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
(right):
> 
>
https://codereview.chromium.org/2883503004/diff/60001/third_party/WebKit/Sour...
>
third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp:466:
void DocumentMarkerController::InvalidateRectsForAllMarkers() {
> This function should modify only TextMatch marker lists.
> 
>
https://codereview.chromium.org/2883503004/diff/60001/third_party/WebKit/Sour...
>
third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp:476:
ToRenderedDocumentMarker(marker)->Invalidate();
> Otherwise this is a bad cast

Ah...I've uploaded https://codereview.chromium.org/2896483002 to implement
InvalidateRectsForAllMarkers() on top of InvalidateRectsForMarkersInNode() so we
only have to make this change in one place, and rebased this CL on top.

[Xiaocheng, 2017-05-18 21:21:43]

lgtm

[commit-bot: I haz the power, 2017-05-19 00:29:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 00:29:26]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[yosin_UTC9, 2017-05-19 06:00:29]

lgtm

Yes! This is what we want to do!

[yosin_UTC9, 2017-05-19 06:00:32]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-05-19 06:01:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 06:01:08]

This CL has an open dependency (Issue 2896483002 Patch 1). Please resolve the
dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[rlanday, 2017-05-19 20:06:25]

The CQ bit was checked by rlanday@chromium.org

[commit-bot: I haz the power, 2017-05-19 20:07:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 21:53:54]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1495224385724820,
"parent_rev": "e9a2e7cbf01e6266d9bdaf0e67915c9e9c6ee9fe", "commit_rev":
"8ee9280525895b4dbb74d3e6117547f79b96d89e"}

[commit-bot: I haz the power, 2017-05-19 21:54:10]

Description was changed from

==========
Only create RenderedDocumentMarkers for TextMatchMarkerListImpl

This sets us up to start creating a polymorphic class hierarchy for
DocumentMarker. RenderedDocumentMarker will become TextMatchMarker, and we will
also add subclasses of DocumentMarker for the other MarkerTypes as well.

BUG=715365
==========

to

==========
Only create RenderedDocumentMarkers for TextMatchMarkerListImpl

This sets us up to start creating a polymorphic class hierarchy for
DocumentMarker. RenderedDocumentMarker will become TextMatchMarker, and we will
also add subclasses of DocumentMarker for the other MarkerTypes as well.

BUG=715365

Review-Url: https://codereview.chromium.org/2883503004
Cr-Commit-Position: refs/heads/master@{#473345}
Committed:
https://chromium.googlesource.com/chromium/src/+/8ee9280525895b4dbb74d3e61175...
==========

[commit-bot: I haz the power, 2017-05-19 21:54:11]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/8ee9280525895b4dbb74d3e61175...