[DMC #7] Only create RenderedDocumentMarkers for TextMatchMarkerListImpl

third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.cpp

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/editing/markers/DocumentMarkerListEditor.h"
 
 #include "core/editing/markers/RenderedDocumentMarker.h"
 #include "core/editing/markers/SpellCheckMarkerListImpl.h"
 
 namespace blink {
 
 void DocumentMarkerListEditor::AddMarkerWithoutMergingOverlapping(
     MarkerList* list,
-    const DocumentMarker* marker) {
-  RenderedDocumentMarker* rendered_marker =
-      RenderedDocumentMarker::Create(*marker);
+    DocumentMarker* marker) {
   if (list->IsEmpty() || list->back()->EndOffset() <= marker->StartOffset()) {
-    list->push_back(rendered_marker);
+    list->push_back(marker);
     return;
   }
 
   const auto pos = std::lower_bound(
       list->begin(), list->end(), marker,
-      [](const Member<RenderedDocumentMarker>& marker_in_list,
+      [](const Member<DocumentMarker>& marker_in_list,
          const DocumentMarker* marker_to_insert) {
         return marker_in_list->StartOffset() < marker_to_insert->StartOffset();
       });
-  list->insert(pos - list->begin(), rendered_marker);
+  list->insert(pos - list->begin(), marker);
 }
 
 bool DocumentMarkerListEditor::MoveMarkers(MarkerList* src_list,
                                            int length,
                                            DocumentMarkerList* dst_list) {
   DCHECK_GT(length, 0);
   bool didMoveMarker = false;
   unsigned end_offset = length - 1;
 
   MarkerList::iterator it;
@@ skipping 19 matching lines @@
 // TODO(rlanday): this method was created by cutting and pasting code from
 // DocumentMarkerController::RemoveMarkers(), it should be refactored in a
 // future CL
 bool DocumentMarkerListEditor::RemoveMarkers(MarkerList* list,
                                              unsigned start_offset,
                                              int length) {
   bool doc_dirty = false;
   const unsigned end_offset = start_offset + length;
   MarkerList::iterator start_pos = std::upper_bound(
       list->begin(), list->end(), start_offset,
-      [](size_t start_offset, const Member<RenderedDocumentMarker>& marker) {
+      [](size_t start_offset, const Member<DocumentMarker>& marker) {
         return start_offset < marker->EndOffset();
       });
   for (MarkerList::iterator i = start_pos; i != list->end();) {
     DocumentMarker marker(*i->Get());
 
     // markers are returned in order, so stop if we are now past the specified
     // range
     if (marker.StartOffset() >= end_offset)
       break;
 
     list->erase(i - list->begin());
     doc_dirty = true;
   }
 
   return doc_dirty;
 }
 
 bool DocumentMarkerListEditor::ShiftMarkers(MarkerList* list,
                                             unsigned offset,
                                             unsigned old_length,
                                             unsigned new_length) {
   bool did_shift_marker = false;
   for (MarkerList::iterator it = list->begin(); it != list->end(); ++it) {
-    RenderedDocumentMarker& marker = **it;
+    DocumentMarker& marker = **it;
     Optional<DocumentMarker::MarkerOffsets> result =
         marker.ComputeOffsetsAfterShift(offset, old_length, new_length);
     if (result == WTF::nullopt) {
       list->erase(it - list->begin());
       --it;
       did_shift_marker = true;
       continue;
     }
 
     if (marker.StartOffset() != result.value().start_offset ||
         marker.EndOffset() != result.value().end_offset) {
       did_shift_marker = true;
       marker.SetStartOffset(result.value().start_offset);
       marker.SetEndOffset(result.value().end_offset);
     }
   }
 
   return did_shift_marker;
 }
 
 }  // namespace blink