Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: third_party/WebKit/Source/core/editing/markers/CompositionMarkerListImpl.h

Issue 2883503004: [DMC #7] Only create RenderedDocumentMarkers for TextMatchMarkerListImpl (Closed)
Patch Set: Rebase on InvalidateRectsForAllMarkers() refactor Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/markers/CompositionMarkerListImpl.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CompositionMarkerListImpl_h 5 #ifndef CompositionMarkerListImpl_h
6 #define CompositionMarkerListImpl_h 6 #define CompositionMarkerListImpl_h
7 7
8 #include "core/editing/markers/DocumentMarkerList.h" 8 #include "core/editing/markers/DocumentMarkerList.h"
9 9
10 namespace blink { 10 namespace blink {
11 11
12 // Implementation of DocumentMarkerList for Composition markers. 12 // Implementation of DocumentMarkerList for Composition markers.
13 // Composition markers are always inserted in order, aside from some potential 13 // Composition markers are always inserted in order, aside from some potential
14 // oddball cases (e.g. splitting the marker list into two nodes, then undoing 14 // oddball cases (e.g. splitting the marker list into two nodes, then undoing
15 // the split). This means we can keep the list in sorted order to do some 15 // the split). This means we can keep the list in sorted order to do some
16 // operations more efficiently, while still being able to do inserts in O(1) 16 // operations more efficiently, while still being able to do inserts in O(1)
17 // time at the end of the list. 17 // time at the end of the list.
18 class CORE_EXPORT CompositionMarkerListImpl final : public DocumentMarkerList { 18 class CORE_EXPORT CompositionMarkerListImpl final : public DocumentMarkerList {
19 public: 19 public:
20 CompositionMarkerListImpl() = default; 20 CompositionMarkerListImpl() = default;
21 21
22 // DocumentMarkerList implementations 22 // DocumentMarkerList implementations
23 DocumentMarker::MarkerType MarkerType() const final; 23 DocumentMarker::MarkerType MarkerType() const final;
24 24
25 bool IsEmpty() const final; 25 bool IsEmpty() const final;
26 26
27 void Add(DocumentMarker*) final; 27 void Add(DocumentMarker*) final;
28 void Clear() final; 28 void Clear() final;
29 29
30 const HeapVector<Member<RenderedDocumentMarker>>& GetMarkers() const final; 30 const HeapVector<Member<DocumentMarker>>& GetMarkers() const final;
31 31
32 bool MoveMarkers(int length, DocumentMarkerList* dst_list) final; 32 bool MoveMarkers(int length, DocumentMarkerList* dst_list) final;
33 bool RemoveMarkers(unsigned start_offset, int length) final; 33 bool RemoveMarkers(unsigned start_offset, int length) final;
34 bool ShiftMarkers(unsigned offset, 34 bool ShiftMarkers(unsigned offset,
35 unsigned old_length, 35 unsigned old_length,
36 unsigned new_length) final; 36 unsigned new_length) final;
37 37
38 DECLARE_VIRTUAL_TRACE(); 38 DECLARE_VIRTUAL_TRACE();
39 39
40 private: 40 private:
41 HeapVector<Member<RenderedDocumentMarker>> markers_; 41 HeapVector<Member<DocumentMarker>> markers_;
42 42
43 DISALLOW_COPY_AND_ASSIGN(CompositionMarkerListImpl); 43 DISALLOW_COPY_AND_ASSIGN(CompositionMarkerListImpl);
44 }; 44 };
45 45
46 } // namespace blink 46 } // namespace blink
47 47
48 #endif // CompositionMarkerListImpl_h 48 #endif // CompositionMarkerListImpl_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/markers/CompositionMarkerListImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698