third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListImpl.cpp - Issue 2883503004: [DMC #7] Only create RenderedDocumentMarkers for TextMatchMarkerListImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListImpl.cpp

Issue 2883503004: [DMC #7] Only create RenderedDocumentMarkers for TextMatchMarkerListImpl (Closed)

Patch Set: Rebase on InvalidateRectsForAllMarkers() refactor Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListImpl.h ('k') | third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListImpl.cpp

diff --git a/third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListImpl.cpp b/third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListImpl.cpp

index b3ad6755de0e8ed2a75c4373e550e671658eedb4..f0636a51c7b7de4b7a01d1b98b402f180cc1b151 100644

--- a/third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListImpl.cpp

+++ b/third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListImpl.cpp

@@ -24,7 +24,7 @@ void SpellCheckMarkerListImpl::Add(DocumentMarker* marker) {

auto first_overlapping = std::lower_bound(

markers_.begin(), markers_.end(), rendered_marker,

- [](const Member<RenderedDocumentMarker>& marker_in_list,

+ [](const Member<DocumentMarker>& marker_in_list,

const DocumentMarker* marker_to_insert) {

return marker_in_list->EndOffset() < marker_to_insert->StartOffset();

});

@@ -49,8 +49,8 @@ void SpellCheckMarkerListImpl::Clear() {

markers_.clear();

}

-const HeapVector<Member<RenderedDocumentMarker>>&

-SpellCheckMarkerListImpl::GetMarkers() const {

+const HeapVector<Member<DocumentMarker>>& SpellCheckMarkerListImpl::GetMarkers()

+ const {

return markers_;

}