Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2886893008: [DMC #8] Rename DocumentMarkerController::RenderedRectsForMarkers() (Closed)

Created:
3 years, 7 months ago by rlanday
Modified:
3 years, 7 months ago
Reviewers:
tkent, yosin_UTC9, Xiaocheng
CC:
blink-reviews, blink-reviews-frames_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename DocumentMarkerController::RenderedRectsForMarkers() Rename DocumentMarkerController::RenderedRectsForMarkers() to RenderedRectsForTextMatchMarkers() and remove the marker_type param. After https://codereview.chromium.org/2883503004, we only create RenderedDocumentMarkers for TextMatch markers, and the type param is no longer needed. BUG=707867 Review-Url: https://codereview.chromium.org/2886893008 Cr-Commit-Position: refs/heads/master@{#473411} Committed: https://chromium.googlesource.com/chromium/src/+/399db8861f0eb1247b1ebec062ac3fe411ff04d1

Patch Set 1 #

Total comments: 1

Patch Set 2 : Reformat FrameView #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -15 lines) Patch
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp View 1 1 chunk +2 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
rlanday
3 years, 7 months ago (2017-05-18 20:50:03 UTC) #4
yosin_UTC9
lgtm +tkent@ for core/frame/FrameView.cpp https://codereview.chromium.org/2886893008/diff/1/third_party/WebKit/Source/core/frame/FrameView.cpp File third_party/WebKit/Source/core/frame/FrameView.cpp (right): https://codereview.chromium.org/2886893008/diff/1/third_party/WebKit/Source/core/frame/FrameView.cpp#newcode2686 third_party/WebKit/Source/core/frame/FrameView.cpp:2686: if (!tickmarks_.IsEmpty()) { nit: Could ...
3 years, 7 months ago (2017-05-19 06:15:59 UTC) #9
tkent
lgtm
3 years, 7 months ago (2017-05-19 06:29:38 UTC) #10
Xiaocheng
lgtm
3 years, 7 months ago (2017-05-19 18:17:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886893008/20001
3 years, 7 months ago (2017-05-19 22:34:37 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/298786)
3 years, 7 months ago (2017-05-20 01:30:29 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886893008/20001
3 years, 7 months ago (2017-05-20 01:35:46 UTC) #18
commit-bot: I haz the power
3 years, 7 months ago (2017-05-20 04:35:59 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/399db8861f0eb1247b1ebec062ac...

Powered by Google App Engine
This is Rietveld 408576698