third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.h - Issue 2883503004: [DMC #7] Only create RenderedDocumentMarkers for TextMatchMarkerListImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.h

Issue 2883503004: [DMC #7] Only create RenderedDocumentMarkers for TextMatchMarkerListImpl (Closed)

Patch Set: Rebase on InvalidateRectsForAllMarkers() refactor Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h ('k') | third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.h

diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.h b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.h

index df299a90ee3a63f48e469bd3ea975f0e195b6685..55d10c1a0fdfccd398408fd7c587406c4c496770 100644

--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.h

+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.h

@@ -11,14 +11,12 @@

namespace blink {

class DocumentMarker;

-class RenderedDocumentMarker;

class DocumentMarkerListEditor {

public:

- using MarkerList = HeapVector<Member<RenderedDocumentMarker>>;

+ using MarkerList = HeapVector<Member<DocumentMarker>>;

- static void AddMarkerWithoutMergingOverlapping(MarkerList*,

- const DocumentMarker*);

+ static void AddMarkerWithoutMergingOverlapping(MarkerList*, DocumentMarker*);

// Returns true if a marker was moved, false otherwise.

static bool MoveMarkers(MarkerList* src_list,