Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issue 2879383002: [CRD iOS] Move UI stuff into a subdirectory (Closed)

Created:
3 years, 7 months ago by Yuwei
Modified:
3 years, 7 months ago
Reviewers:
nicholss
CC:
chromium-reviews, ios-reviews_chromium.org, chromoting-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[CRD iOS] Move UI stuff into a subdirectory We started having too much mobile UI code under /client. This starts becomming a pain when we deal with mobile client dependencies that involve /client and /client/display. This CL moves the mobile UI code under /client/ui BUG=722577 Review-Url: https://codereview.chromium.org/2879383002 Cr-Commit-Position: refs/heads/master@{#471983} Committed: https://chromium.googlesource.com/chromium/src/+/631efbaf799b5af0f13986871a700289d66f8c9e

Patch Set 1 #

Patch Set 2 : Fix include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -1612 lines) Patch
M remoting/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/client/BUILD.gn View 3 chunks +0 lines, -15 lines 0 comments Download
D remoting/client/desktop_viewport.h View 1 chunk +0 lines, -117 lines 0 comments Download
D remoting/client/desktop_viewport.cc View 1 chunk +0 lines, -246 lines 0 comments Download
D remoting/client/desktop_viewport_unittest.cc View 1 chunk +0 lines, -295 lines 0 comments Download
D remoting/client/direct_input_strategy.h View 1 chunk +0 lines, -47 lines 0 comments Download
D remoting/client/direct_input_strategy.cc View 1 chunk +0 lines, -54 lines 0 comments Download
D remoting/client/fling_animation.h View 1 chunk +0 lines, -56 lines 0 comments Download
D remoting/client/fling_animation.cc View 1 chunk +0 lines, -46 lines 0 comments Download
D remoting/client/fling_animation_unittest.cc View 1 chunk +0 lines, -153 lines 0 comments Download
D remoting/client/fling_tracker.h View 1 chunk +0 lines, -52 lines 0 comments Download
D remoting/client/fling_tracker.cc View 1 chunk +0 lines, -109 lines 0 comments Download
D remoting/client/gesture_interpreter.h View 1 chunk +0 lines, -81 lines 0 comments Download
D remoting/client/gesture_interpreter.cc View 1 chunk +0 lines, -109 lines 0 comments Download
D remoting/client/input_strategy.h View 1 chunk +0 lines, -51 lines 0 comments Download
A remoting/client/ui/BUILD.gn View 1 chunk +43 lines, -0 lines 0 comments Download
A + remoting/client/ui/desktop_viewport.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + remoting/client/ui/desktop_viewport.cc View 1 chunk +1 line, -1 line 0 comments Download
A + remoting/client/ui/desktop_viewport_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + remoting/client/ui/direct_input_strategy.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + remoting/client/ui/direct_input_strategy.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + remoting/client/ui/fling_animation.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + remoting/client/ui/fling_animation.cc View 1 chunk +1 line, -1 line 0 comments Download
A + remoting/client/ui/fling_animation_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + remoting/client/ui/fling_tracker.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + remoting/client/ui/fling_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
A + remoting/client/ui/gesture_interpreter.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + remoting/client/ui/gesture_interpreter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + remoting/client/ui/input_strategy.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + remoting/client/ui/view_matrix.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + remoting/client/ui/view_matrix.cc View 1 chunk +1 line, -1 line 0 comments Download
D remoting/client/view_matrix.h View 1 chunk +0 lines, -74 lines 0 comments Download
D remoting/client/view_matrix.cc View 1 chunk +0 lines, -67 lines 0 comments Download
M remoting/ios/app/host_view_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M remoting/ios/client_gestures.mm View 1 chunk +1 line, -1 line 0 comments Download
M remoting/ios/display/gl_display_handler.h View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/ios/session/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/ios/session/remoting_client.mm View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
Yuwei
PTAL thanks!
3 years, 7 months ago (2017-05-15 21:46:29 UTC) #4
nicholss
lgtm
3 years, 7 months ago (2017-05-15 21:50:03 UTC) #6
Yuwei
On 2017/05/15 21:50:03, nicholss wrote: > lgtm Thanks!
3 years, 7 months ago (2017-05-15 21:51:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2879383002/20001
3 years, 7 months ago (2017-05-15 21:52:31 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 02:20:20 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/631efbaf799b5af0f13986871a70...

Powered by Google App Engine
This is Rietveld 408576698