mash: Serialize ShelfIDs for property conversion and transport.

mash: Serialize ShelfIDs for property conversion and transport.

Mus window properties require conversion to byte arrays.
ShelfID, a string pair struct, cannot be converted directly.
Instead, serialize ShelfIDs for use as window properties.
This fixes mash shelf item population via ShelfWindowWatcher.
Register the property in ChromeBrowserMainExtraPartsAsh.

Also add support for temporary ShelfID assignment in mash.
(so ShelfWindowWatcher will handle all non-ignored windows)

Also add support for duplicate ShelfIDs in mash.
(ShelfWindowWatcher[ItemDelegate] doesn't coalesce windows)

Make ShelfID ctor explicit. Cleanup some WmWindow usage.
TODO: Fix PropertyConverter::RegisterProperty function names.

BUG=557406
TEST=Automated; mash shelf items appear; no ChromeOS shelf changes.
R=jamescook@chromium.org
TBR=sky@chromium.org,tsepez@chromium.org,reveman@chromium.org

Review-Url: https://codereview.chromium.org/2878133002
Cr-Commit-Position: refs/heads/master@{#471935}
Committed: https://chromium.googlesource.com/chromium/src/+/6958e7f12dc01b1e7412d12c5e0b40ca94c3d663

[msw, 2017-05-12 23:03:22]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 23:04:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2017-05-12 23:19:30]

Description was changed from

==========
mash: Serialize ShelfIDs for property conversion and transport.

BUG=557406
==========

to

==========
mash: Serialize ShelfIDs for property conversion and transport.

Mus window properties require conversion to byte arrays.
ShelfID, a string pair struct, cannot be converted directly.
Instead, serialize ShelfIDs for use as window properties.
This fixes mash shelf item population via ShelfWindowWatcher.
Register the property in ChromeBrowserMainExtraPartsAsh.

Also add support for temporary ShelfID assignment in mash.
(so ShelfWindowWatcher will handle all non-ignored windows)

Also add support for duplicate ShelfIDs in mash.
(ShelfWindowWatcher[ItemDelegate] doesn't coalesce windows)

Cleanup some WmWindow usage.

TODO: Fix PropertyConverter::RegisterProperty function names.

BUG=557406
TEST=Automated; mash shelf items appear; no ChromeOS shelf changes.
R=jamescook@chromium.org
==========

[msw, 2017-05-12 23:19:30]

msw@chromium.org changed reviewers:
+ jamescook@chromium.org

[msw, 2017-05-12 23:20:47]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 23:21:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 23:46:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 23:46:34]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[msw, 2017-05-13 00:06:40]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[msw, 2017-05-13 00:07:06]

Description was changed from

==========
mash: Serialize ShelfIDs for property conversion and transport.

Mus window properties require conversion to byte arrays.
ShelfID, a string pair struct, cannot be converted directly.
Instead, serialize ShelfIDs for use as window properties.
This fixes mash shelf item population via ShelfWindowWatcher.
Register the property in ChromeBrowserMainExtraPartsAsh.

Also add support for temporary ShelfID assignment in mash.
(so ShelfWindowWatcher will handle all non-ignored windows)

Also add support for duplicate ShelfIDs in mash.
(ShelfWindowWatcher[ItemDelegate] doesn't coalesce windows)

Cleanup some WmWindow usage.

TODO: Fix PropertyConverter::RegisterProperty function names.

BUG=557406
TEST=Automated; mash shelf items appear; no ChromeOS shelf changes.
R=jamescook@chromium.org
==========

to

==========
mash: Serialize ShelfIDs for property conversion and transport.

Mus window properties require conversion to byte arrays.
ShelfID, a string pair struct, cannot be converted directly.
Instead, serialize ShelfIDs for use as window properties.
This fixes mash shelf item population via ShelfWindowWatcher.
Register the property in ChromeBrowserMainExtraPartsAsh.

Also add support for temporary ShelfID assignment in mash.
(so ShelfWindowWatcher will handle all non-ignored windows)

Also add support for duplicate ShelfIDs in mash.
(ShelfWindowWatcher[ItemDelegate] doesn't coalesce windows)

Make ShelfID ctor explicit. Cleanup some WmWindow usage.
TODO: Fix PropertyConverter::RegisterProperty function names.

BUG=557406
TEST=Automated; mash shelf items appear; no ChromeOS shelf changes.
R=jamescook@chromium.org
==========

[commit-bot: I haz the power, 2017-05-13 00:07:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-13 00:58:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-13 00:58:35]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[msw, 2017-05-13 02:55:12]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-13 02:55:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2017-05-13 02:55:34]

Hey James, please take a look; thanks!

[commit-bot: I haz the power, 2017-05-13 04:02:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-13 04:02:29]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[James Cook, 2017-05-15 16:37:24]

LGTM with nits. Lemme know if you want me to look again.

https://codereview.chromium.org/2878133002/diff/60001/ash/public/cpp/shelf_ty...
File ash/public/cpp/shelf_types.cc (right):

https://codereview.chromium.org/2878133002/diff/60001/ash/public/cpp/shelf_ty...
ash/public/cpp/shelf_types.cc:15: constexpr char kDelimiter[] = {'|', 0};
const char kDelimiter[] = "|"; doesn't work here? Why the {} initializer?

https://codereview.chromium.org/2878133002/diff/60001/ash/public/cpp/shelf_ty...
ash/public/cpp/shelf_types.cc:58: return app_id + std::string(kDelimiter) +
launch_id;
You might be able to skip the std::string(kDelimiter) here, which might end up
using a slightly-more-efficient template-specialized char* append for
std::string. Not sure, tho, have to see if it compiles.

https://codereview.chromium.org/2878133002/diff/60001/ash/public/cpp/shelf_ty...
ash/public/cpp/shelf_types.cc:63: if (!string)
Could this be a DCHECK?

https://codereview.chromium.org/2878133002/diff/60001/ash/public/cpp/shelf_ty...
File ash/public/cpp/shelf_types.h (right):

https://codereview.chromium.org/2878133002/diff/60001/ash/public/cpp/shelf_ty...
ash/public/cpp/shelf_types.h:141: explicit ShelfID(const std::string& app_id =
std::string(),
Good catch.

https://codereview.chromium.org/2878133002/diff/60001/ash/public/cpp/shelf_ty...
ash/public/cpp/shelf_types.h:158: static ShelfID Deserialize(const std::string*
string);
optional: Say something about validation / what happens if string is null / bad
/ etc.

https://codereview.chromium.org/2878133002/diff/60001/ash/shelf/shelf_window_...
File ash/shelf/shelf_window_watcher.cc (right):

https://codereview.chromium.org/2878133002/diff/60001/ash/shelf/shelf_window_...
ash/shelf/shelf_window_watcher.cc:126: // TODO(msw): Remove this temporary Mash
default ShelfID handling code.
Given that this comment is in 3 places, please file a bug for it and reference
it in the code.

https://codereview.chromium.org/2878133002/diff/60001/ash/shelf/shelf_window_...
File ash/shelf/shelf_window_watcher_unittest.cc (right):

https://codereview.chromium.org/2878133002/diff/60001/ash/shelf/shelf_window_...
ash/shelf/shelf_window_watcher_unittest.cc:43: static ShelfID
CreateShelfItem(aura::Window* window) {
Hooray for less WmWindow!

https://codereview.chromium.org/2878133002/diff/60001/ash/shelf/shelf_window_...
ash/shelf/shelf_window_watcher_unittest.cc:45: ash::ShelfID
shelf_id(base::IntToString(id++));
Is ash:: needed?

https://codereview.chromium.org/2878133002/diff/60001/ash/shelf/shelf_window_...
ash/shelf/shelf_window_watcher_unittest.cc:271:
window1->SetProperty(kShelfIDKey, new std::string(ShelfID("a").Serialize()));
Oh, you and your love of fitting it all on one line. "a". lol. :-)

https://codereview.chromium.org/2878133002/diff/60001/ash/wm/overview/window_...
File ash/wm/overview/window_selector_unittest.cc (right):

https://codereview.chromium.org/2878133002/diff/60001/ash/wm/overview/window_...
ash/wm/overview/window_selector_unittest.cc:151: std::string
shelf_id(ash::ShelfID(base::IntToString(id++)).Serialize());
Is ash:: needed?

https://codereview.chromium.org/2878133002/diff/60001/ash/wm/panels/panel_lay...
File ash/wm/panels/panel_layout_manager_unittest.cc (right):

https://codereview.chromium.org/2878133002/diff/60001/ash/wm/panels/panel_lay...
ash/wm/panels/panel_layout_manager_unittest.cc:93: std::string
shelf_id(ash::ShelfID(base::IntToString(id++)).Serialize());
Am I missing something obvious about ash:: for ShelfID? Is there another
ShelfID?

https://codereview.chromium.org/2878133002/diff/60001/ui/aura/mus/property_co...
File ui/aura/mus/property_converter.h (right):

https://codereview.chromium.org/2878133002/diff/60001/ui/aura/mus/property_co...
ui/aura/mus/property_converter.h:98: // TODO(msw): Include type names in
RegisterProperty function names.
Yeah, this would be good to do, given how much time we spent being puzzled by
it. Not for this CL, of course.

[msw, 2017-05-15 19:21:32]

Comments addressed; landing.

https://codereview.chromium.org/2878133002/diff/60001/ash/public/cpp/shelf_ty...
File ash/public/cpp/shelf_types.cc (right):

https://codereview.chromium.org/2878133002/diff/60001/ash/public/cpp/shelf_ty...
ash/public/cpp/shelf_types.cc:15: constexpr char kDelimiter[] = {'|', 0};
On 2017/05/15 16:37:23, James Cook wrote:
> const char kDelimiter[] = "|"; doesn't work here? Why the {} initializer?

Done.

https://codereview.chromium.org/2878133002/diff/60001/ash/public/cpp/shelf_ty...
ash/public/cpp/shelf_types.cc:58: return app_id + std::string(kDelimiter) +
launch_id;
On 2017/05/15 16:37:23, James Cook wrote:
> You might be able to skip the std::string(kDelimiter) here, which might end up
> using a slightly-more-efficient template-specialized char* append for
> std::string. Not sure, tho, have to see if it compiles.

Done.

https://codereview.chromium.org/2878133002/diff/60001/ash/public/cpp/shelf_ty...
ash/public/cpp/shelf_types.cc:63: if (!string)
On 2017/05/15 16:37:23, James Cook wrote:
> Could this be a DCHECK?

I'd rather not, every kShelfIDKey property read would need special casing for
null values.

https://codereview.chromium.org/2878133002/diff/60001/ash/public/cpp/shelf_ty...
File ash/public/cpp/shelf_types.h (right):

https://codereview.chromium.org/2878133002/diff/60001/ash/public/cpp/shelf_ty...
ash/public/cpp/shelf_types.h:141: explicit ShelfID(const std::string& app_id =
std::string(),
On 2017/05/15 16:37:23, James Cook wrote:
> Good catch.

Acknowledged.

https://codereview.chromium.org/2878133002/diff/60001/ash/public/cpp/shelf_ty...
ash/public/cpp/shelf_types.h:158: static ShelfID Deserialize(const std::string*
string);
On 2017/05/15 16:37:23, James Cook wrote:
> optional: Say something about validation / what happens if string is null /
bad
> / etc.

Done.

https://codereview.chromium.org/2878133002/diff/60001/ash/shelf/shelf_window_...
File ash/shelf/shelf_window_watcher.cc (right):

https://codereview.chromium.org/2878133002/diff/60001/ash/shelf/shelf_window_...
ash/shelf/shelf_window_watcher.cc:126: // TODO(msw): Remove this temporary Mash
default ShelfID handling code.
On 2017/05/15 16:37:23, James Cook wrote:
> Given that this comment is in 3 places, please file a bug for it and reference
> it in the code.

Done.

https://codereview.chromium.org/2878133002/diff/60001/ash/shelf/shelf_window_...
File ash/shelf/shelf_window_watcher_unittest.cc (right):

https://codereview.chromium.org/2878133002/diff/60001/ash/shelf/shelf_window_...
ash/shelf/shelf_window_watcher_unittest.cc:43: static ShelfID
CreateShelfItem(aura::Window* window) {
On 2017/05/15 16:37:23, James Cook wrote:
> Hooray for less WmWindow!

Acknowledged.

https://codereview.chromium.org/2878133002/diff/60001/ash/shelf/shelf_window_...
ash/shelf/shelf_window_watcher_unittest.cc:45: ash::ShelfID
shelf_id(base::IntToString(id++));
On 2017/05/15 16:37:23, James Cook wrote:
> Is ash:: needed?

Done.

https://codereview.chromium.org/2878133002/diff/60001/ash/shelf/shelf_window_...
ash/shelf/shelf_window_watcher_unittest.cc:271:
window1->SetProperty(kShelfIDKey, new std::string(ShelfID("a").Serialize()));
On 2017/05/15 16:37:23, James Cook wrote:
> Oh, you and your love of fitting it all on one line. "a". lol. :-)

Hahaha, I can't help it!

https://codereview.chromium.org/2878133002/diff/60001/ash/wm/overview/window_...
File ash/wm/overview/window_selector_unittest.cc (right):

https://codereview.chromium.org/2878133002/diff/60001/ash/wm/overview/window_...
ash/wm/overview/window_selector_unittest.cc:151: std::string
shelf_id(ash::ShelfID(base::IntToString(id++)).Serialize());
On 2017/05/15 16:37:23, James Cook wrote:
> Is ash:: needed?

Done.

https://codereview.chromium.org/2878133002/diff/60001/ash/wm/panels/panel_lay...
File ash/wm/panels/panel_layout_manager_unittest.cc (right):

https://codereview.chromium.org/2878133002/diff/60001/ash/wm/panels/panel_lay...
ash/wm/panels/panel_layout_manager_unittest.cc:93: std::string
shelf_id(ash::ShelfID(base::IntToString(id++)).Serialize());
On 2017/05/15 16:37:23, James Cook wrote:
> Am I missing something obvious about ash:: for ShelfID? Is there another
> ShelfID?

Nope, I was just copy-pasting and missed the namespacing.

https://codereview.chromium.org/2878133002/diff/60001/ui/aura/mus/property_co...
File ui/aura/mus/property_converter.h (right):

https://codereview.chromium.org/2878133002/diff/60001/ui/aura/mus/property_co...
ui/aura/mus/property_converter.h:98: // TODO(msw): Include type names in
RegisterProperty function names.
On 2017/05/15 16:37:23, James Cook wrote:
> Yeah, this would be good to do, given how much time we spent being puzzled by
> it. Not for this CL, of course.

Acknowledged.

[msw, 2017-05-15 19:21:38]

The CQ bit was checked by msw@chromium.org

[msw, 2017-05-15 19:21:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2878133002/#ps80001
(title: "Address comments.")

[commit-bot: I haz the power, 2017-05-15 19:22:49]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 19:51:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 19:51:12]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[msw, 2017-05-15 20:38:00]

Description was changed from

==========
mash: Serialize ShelfIDs for property conversion and transport.

Mus window properties require conversion to byte arrays.
ShelfID, a string pair struct, cannot be converted directly.
Instead, serialize ShelfIDs for use as window properties.
This fixes mash shelf item population via ShelfWindowWatcher.
Register the property in ChromeBrowserMainExtraPartsAsh.

Also add support for temporary ShelfID assignment in mash.
(so ShelfWindowWatcher will handle all non-ignored windows)

Also add support for duplicate ShelfIDs in mash.
(ShelfWindowWatcher[ItemDelegate] doesn't coalesce windows)

Make ShelfID ctor explicit. Cleanup some WmWindow usage.
TODO: Fix PropertyConverter::RegisterProperty function names.

BUG=557406
TEST=Automated; mash shelf items appear; no ChromeOS shelf changes.
R=jamescook@chromium.org
==========

to

==========
mash: Serialize ShelfIDs for property conversion and transport.

Mus window properties require conversion to byte arrays.
ShelfID, a string pair struct, cannot be converted directly.
Instead, serialize ShelfIDs for use as window properties.
This fixes mash shelf item population via ShelfWindowWatcher.
Register the property in ChromeBrowserMainExtraPartsAsh.

Also add support for temporary ShelfID assignment in mash.
(so ShelfWindowWatcher will handle all non-ignored windows)

Also add support for duplicate ShelfIDs in mash.
(ShelfWindowWatcher[ItemDelegate] doesn't coalesce windows)

Make ShelfID ctor explicit. Cleanup some WmWindow usage.
TODO: Fix PropertyConverter::RegisterProperty function names.

BUG=557406
TEST=Automated; mash shelf items appear; no ChromeOS shelf changes.
R=jamescook@chromium.org
TBR=sky@chromium.org,tsepez@chromium.org,jam@chromium.org
==========

[msw, 2017-05-15 20:38:00]

msw@chromium.org changed reviewers:
+ jam@chromium.org, sky@chromium.org, tsepez@chromium.org

[msw, 2017-05-15 20:40:22]

Description was changed from

==========
mash: Serialize ShelfIDs for property conversion and transport.

Mus window properties require conversion to byte arrays.
ShelfID, a string pair struct, cannot be converted directly.
Instead, serialize ShelfIDs for use as window properties.
This fixes mash shelf item population via ShelfWindowWatcher.
Register the property in ChromeBrowserMainExtraPartsAsh.

Also add support for temporary ShelfID assignment in mash.
(so ShelfWindowWatcher will handle all non-ignored windows)

Also add support for duplicate ShelfIDs in mash.
(ShelfWindowWatcher[ItemDelegate] doesn't coalesce windows)

Make ShelfID ctor explicit. Cleanup some WmWindow usage.
TODO: Fix PropertyConverter::RegisterProperty function names.

BUG=557406
TEST=Automated; mash shelf items appear; no ChromeOS shelf changes.
R=jamescook@chromium.org
TBR=sky@chromium.org,tsepez@chromium.org,jam@chromium.org
==========

to

==========
mash: Serialize ShelfIDs for property conversion and transport.

Mus window properties require conversion to byte arrays.
ShelfID, a string pair struct, cannot be converted directly.
Instead, serialize ShelfIDs for use as window properties.
This fixes mash shelf item population via ShelfWindowWatcher.
Register the property in ChromeBrowserMainExtraPartsAsh.

Also add support for temporary ShelfID assignment in mash.
(so ShelfWindowWatcher will handle all non-ignored windows)

Also add support for duplicate ShelfIDs in mash.
(ShelfWindowWatcher[ItemDelegate] doesn't coalesce windows)

Make ShelfID ctor explicit. Cleanup some WmWindow usage.
TODO: Fix PropertyConverter::RegisterProperty function names.

BUG=557406
TEST=Automated; mash shelf items appear; no ChromeOS shelf changes.
R=jamescook@chromium.org
TBR=sky@chromium.org,tsepez@chromium.org,reveman@chromium.org
==========

[msw, 2017-05-15 20:40:23]

msw@chromium.org changed reviewers:
+ reveman@chromium.org
- jam@chromium.org

[msw, 2017-05-15 20:40:40]

+TBR owners for some trivial changes:
sky@chromium.org: comments in property_converter.h
tsepez@chromium.org: comment in window_manager.mojom
reveman@chromium.org: components/exo/shell_surface.cc

[msw, 2017-05-15 20:40:46]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2017-05-15 20:41:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2017-05-15 21:34:39]

LGTM

[commit-bot: I haz the power, 2017-05-15 22:55:09]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1494880846392930,
"parent_rev": "d609cd24c3e263dfc5a0b11970af1b23c0620dae", "commit_rev":
"6958e7f12dc01b1e7412d12c5e0b40ca94c3d663"}

[commit-bot: I haz the power, 2017-05-15 22:55:21]

Description was changed from

==========
mash: Serialize ShelfIDs for property conversion and transport.

Mus window properties require conversion to byte arrays.
ShelfID, a string pair struct, cannot be converted directly.
Instead, serialize ShelfIDs for use as window properties.
This fixes mash shelf item population via ShelfWindowWatcher.
Register the property in ChromeBrowserMainExtraPartsAsh.

Also add support for temporary ShelfID assignment in mash.
(so ShelfWindowWatcher will handle all non-ignored windows)

Also add support for duplicate ShelfIDs in mash.
(ShelfWindowWatcher[ItemDelegate] doesn't coalesce windows)

Make ShelfID ctor explicit. Cleanup some WmWindow usage.
TODO: Fix PropertyConverter::RegisterProperty function names.

BUG=557406
TEST=Automated; mash shelf items appear; no ChromeOS shelf changes.
R=jamescook@chromium.org
TBR=sky@chromium.org,tsepez@chromium.org,reveman@chromium.org
==========

to

==========
mash: Serialize ShelfIDs for property conversion and transport.

Mus window properties require conversion to byte arrays.
ShelfID, a string pair struct, cannot be converted directly.
Instead, serialize ShelfIDs for use as window properties.
This fixes mash shelf item population via ShelfWindowWatcher.
Register the property in ChromeBrowserMainExtraPartsAsh.

Also add support for temporary ShelfID assignment in mash.
(so ShelfWindowWatcher will handle all non-ignored windows)

Also add support for duplicate ShelfIDs in mash.
(ShelfWindowWatcher[ItemDelegate] doesn't coalesce windows)

Make ShelfID ctor explicit. Cleanup some WmWindow usage.
TODO: Fix PropertyConverter::RegisterProperty function names.

BUG=557406
TEST=Automated; mash shelf items appear; no ChromeOS shelf changes.
R=jamescook@chromium.org
TBR=sky@chromium.org,tsepez@chromium.org,reveman@chromium.org

Review-Url: https://codereview.chromium.org/2878133002
Cr-Commit-Position: refs/heads/master@{#471935}
Committed:
https://chromium.googlesource.com/chromium/src/+/6958e7f12dc01b1e7412d12c5e0b...
==========

[commit-bot: I haz the power, 2017-05-15 22:55:24]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/6958e7f12dc01b1e7412d12c5e0b...

[reveman, 2017-05-16 04:00:37]

lgtm