ash/shell/window_watcher.cc - Issue 2878133002: mash: Serialize ShelfIDs for property conversion and transport.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/shell/window_watcher.cc

Issue 2878133002: mash: Serialize ShelfIDs for property conversion and transport. (Closed)

Patch Set: Address comments. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/shell/window_watcher.cc

diff --git a/ash/shell/window_watcher.cc b/ash/shell/window_watcher.cc

index 0dd36307c2a45cfa031b8885ff16c8129a298bcb..cc991ac415ab96f52fc63c4347ad1f14f2965996 100644

--- a/ash/shell/window_watcher.cc

+++ b/ash/shell/window_watcher.cc

@@ -117,7 +117,7 @@ void WindowWatcher::OnWindowAdded(aura::Window* new_window) {

model->SetShelfItemDelegate(

item.id, base::MakeUnique<WindowWatcherShelfItemDelegate>(item.id, this));

- new_window->SetProperty(kShelfIDKey, new ShelfID(item.id));

+ new_window->SetProperty(kShelfIDKey, new std::string(item.id.Serialize()));

}

void WindowWatcher::OnWillRemoveWindow(aura::Window* window) {