mash: Serialize ShelfIDs for property conversion and transport.

ash/shelf/shelf_widget.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/shelf/shelf_widget.h"
 
 #include "ash/animation/animation_change_type.h"
 #include "ash/focus_cycler.h"
 #include "ash/public/cpp/window_properties.h"
 #include "ash/root_window_controller.h"
@@ skipping 279 matching lines @@
     background_animator_.RemoveObserver(status_area_widget_);
     Shell::Get()->focus_cycler()->RemoveWidget(status_area_widget_);
     status_area_widget_->Shutdown();
     status_area_widget_ = nullptr;
   }
 
   CloseNow();
 }
 
 void ShelfWidget::UpdateIconPositionForPanel(WmWindow* panel) {
-  ShelfID* id = panel->aura_window()->GetProperty(kShelfIDKey);
-  if (!shelf_view_ || !id)
+  ShelfID id =
+      ShelfID::Deserialize(panel->aura_window()->GetProperty(kShelfIDKey));
+  if (!shelf_view_ || id.IsNull())
     return;
 
   WmWindow* shelf_window = WmWindow::Get(this->GetNativeWindow());
   shelf_view_->UpdatePanelIconPosition(
-      *id, shelf_window->ConvertRectFromScreen(panel->GetBoundsInScreen())
-               .CenterPoint());
+      id, shelf_window->ConvertRectFromScreen(panel->GetBoundsInScreen())
+              .CenterPoint());
 }
 
 gfx::Rect ShelfWidget::GetScreenBoundsOfItemIconForWindow(WmWindow* window) {
-  ShelfID* id = window->aura_window()->GetProperty(kShelfIDKey);
+  ShelfID id =
+      ShelfID::Deserialize(window->aura_window()->GetProperty(kShelfIDKey));
   // Window animations can be triggered during session restore before the shelf
   // view is created. In that case, return default empty bounds.
-  if (!shelf_view_ || !id)
+  if (!shelf_view_ || id.IsNull())
     return gfx::Rect();
 
-  gfx::Rect bounds(shelf_view_->GetIdealBoundsOfItemIcon(*id));
+  gfx::Rect bounds(shelf_view_->GetIdealBoundsOfItemIcon(id));
   gfx::Point screen_origin;
   views::View::ConvertPointToScreen(shelf_view_, &screen_origin);
   return gfx::Rect(screen_origin.x() + bounds.x(),
                    screen_origin.y() + bounds.y(), bounds.width(),
                    bounds.height());
 }
 
 AppListButton* ShelfWidget::GetAppListButton() const {
   return shelf_view_ ? shelf_view_->GetAppListButton() : nullptr;
 }
@@ skipping 16 matching lines @@
   if (shelf_view_)
     shelf_view_->UpdateShelfItemBackground(color);
 }
 
 void ShelfWidget::WillDeleteShelfLayoutManager() {
   shelf_layout_manager_->RemoveObserver(this);
   shelf_layout_manager_ = nullptr;
 }
 
 }  // namespace ash