chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc - Issue 2878133002: mash: Serialize ShelfIDs for property conversion and transport.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc

Issue 2878133002: mash: Serialize ShelfIDs for property conversion and transport. (Closed)

Patch Set: Address comments. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.cc ('k') | chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc

diff --git a/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc b/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc

index d96c0053fa3c39002e24ba5c074f4096dde1065c..597cf07397a5dfdb27bb763211c872aa5713ead8 100644

--- a/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc

+++ b/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc

@@ -418,8 +418,8 @@ void ArcAppWindowLauncherController::AttachControllerToWindowIfNeeded(

base::MakeUnique<AppWindow>(task_id, info->app_shelf_id(), widget, this));

RegisterApp(info);

DCHECK(info->app_window()->controller());

- window->SetProperty(ash::kShelfIDKey,

- new ash::ShelfID(info->app_window()->shelf_id()));

+ const ash::ShelfID shelf_id(info->app_window()->shelf_id());

+ window->SetProperty(ash::kShelfIDKey, new std::string(shelf_id.Serialize()));

if (ash::Shell::Get()

->maximize_mode_controller()

->IsMaximizeModeWindowManagerEnabled()) {