Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: ui/aura/mus/property_converter.h

Issue 2878133002: mash: Serialize ShelfIDs for property conversion and transport. (Closed)
Patch Set: Address comments. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/ui/public/interfaces/window_manager.mojom ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/aura/mus/property_converter.h
diff --git a/ui/aura/mus/property_converter.h b/ui/aura/mus/property_converter.h
index b523a9a5d75e0addffeba223c89059488e481574..f31751a7680d391322b57145267c6359bc3c16dd 100644
--- a/ui/aura/mus/property_converter.h
+++ b/ui/aura/mus/property_converter.h
@@ -78,6 +78,7 @@ class AURA_EXPORT PropertyConverter {
// Register a property to support conversion between mus and aura.
// |validator| is a callback used to validate incoming values from
// transport_data; if it returns false, the value is rejected.
+ // TODO(msw): Include type names in RegisterProperty function names.
template <typename T>
void RegisterProperty(
const WindowProperty<T>* property,
@@ -93,7 +94,8 @@ class AURA_EXPORT PropertyConverter {
transport_names_.insert(transport_name);
}
- // Specializations for properties to pointer types supporting mojo conversion.
+ // Register owned properties to support conversion between mus and aura.
+ // TODO(msw): Include type names in RegisterProperty function names.
void RegisterProperty(const WindowProperty<gfx::ImageSkia*>* property,
const char* transport_name);
void RegisterProperty(const WindowProperty<gfx::Rect*>* property,
« no previous file with comments | « services/ui/public/interfaces/window_manager.mojom ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698