mash: Serialize ShelfIDs for property conversion and transport.

ash/public/cpp/shelf_types.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_PUBLIC_CPP_SHELF_TYPES_H_
 #define ASH_PUBLIC_CPP_SHELF_TYPES_H_
 
 #include <cstdint>
 #include <string>
 
@@ skipping 120 matching lines @@
   // A shelf item that needs user's attention.
   STATUS_ATTENTION,
 };
 
 // A unique shelf item id composed of an |app_id| and a |launch_id|.
 // |app_id| is the non-empty application id associated with a set of windows.
 // |launch_id| is passed on app launch, to support multiple shelf items per app.
 // As an example, a remote desktop client may want each remote application to
 // have its own icon.
 struct ASH_PUBLIC_EXPORT ShelfID {
-  ShelfID(const std::string& app_id = std::string(),
-          const std::string& launch_id = std::string());
+  explicit ShelfID(const std::string& app_id = std::string(),

[James Cook, 2017/05/15 16:37:23]

Good catch.

[msw, 2017/05/15 19:21:31]

Acknowledged.

+                   const std::string& launch_id = std::string());
   ~ShelfID();
 
   ShelfID(const ShelfID& other);
   ShelfID(ShelfID&& other);
   ShelfID& operator=(const ShelfID& other);
   bool operator==(const ShelfID& other) const;
   bool operator!=(const ShelfID& other) const;
   bool operator<(const ShelfID& other) const;
 
   // Returns true if both the application id and launch id are empty.
   // This is often used to determine if the id is invalid.
   bool IsNull() const;
 
+  // Functions to [de]serialize ids as a string for window property usage, etc.
+  std::string Serialize() const;
+  static ShelfID Deserialize(const std::string* string);

[James Cook, 2017/05/15 16:37:23]

optional: Say something about validation / what happens if string is null / bad
/ etc.

[msw, 2017/05/15 19:21:31]

Done.

+
   // The application id associated with a set of windows.
   std::string app_id;
   // An id passed on app launch, to support multiple shelf items per app.
   std::string launch_id;
 };
 
 }  // namespace ash
 
 #endif  // ASH_PUBLIC_CPP_SHELF_TYPES_H_