RELAND: ShapeDetection: use mojom::Bitmap for mojo interface.

RELAND2: ShapeDetection: use mojom::Bitmap for mojo interface.
    
    Original CL got reverted due to test cases are concurrent in same
    script context, it will cause random crash/time out.
    
    CL [1] has resolved the random issue, so rebase the commit align with
    the latest code. Reland implementation of detecting on mac 
    platform, layout tests files, interface definition in mojom file and
    implementation in /Source/modules/shapedetion. Implementation on
    Android platform is new code include all of java files.
    
    [1] https://chromium-review.googlesource.com/475077
    
    Original CL description ------------------------------------------------
    ShapeDetection: use mojom::Bitmap for mojo interface.
    
    This CL uses mojo::Bitmap for mojo ShapeDetection interfaces definition,
    so that the Detect API is completely flexible and friendly.
    
    BUG=665488
TEST(Layout)=
     third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html
     third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html
     third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html
     third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html
     third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html
     third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html
     third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html
    
    Review-Url: https://codereview.chromium.org/2629433003
    Cr-Commit-Position: refs/heads/master@{#446142}
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

TBR=rockot@chromium.org, dtrainor@chromium.org, haraken@chromium.org
since the gist of the CL hasn't changed.
    

Review-Url: https://codereview.chromium.org/2681913003
Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#450582}
Review-Url: https://codereview.chromium.org/2753413002
Cr-Original-Original-Commit-Position: refs/heads/master@{#458010}
Review-Url: https://codereview.chromium.org/2765723002
Cr-Original-Commit-Position: refs/heads/master@{#458657}
Review-Url: https://codereview.chromium.org/2875243002
Cr-Commit-Position: refs/heads/master@{#476598}
Committed: https://chromium.googlesource.com/chromium/src/+/31eb1a542aea4050d9b17fd7255d366499dedede

[junwei, 2017-05-12 06:58:19]

Description was changed from

==========
RELAND: ShapeDetection: use mojom::Bitmap for mojo interface.

Original CL got reverted due to shapedetection/detection-on-worker.html
fail to fetch source for module skia/public/interfaces/bitmap.mojom.

This CL add gen/skia/public/interfaces to generated bindings paths.

Original CL description ------------------------------------------------
ShapeDetection: use mojom::Bitmap for mojo interface.

This CL uses mojo::Bitmap for mojo ShapeDetection interfaces definition,
so that the Detect API is completely flexible and friendly.

BUG=665488
TEST(Layout)=
 third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html

third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html
 third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html
 third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html
 third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html
 third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html
 third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html

Review-Url: https://codereview.chromium.org/2629433003
Cr-Commit-Position: refs/heads/master@{#446142}
(cherry picked from commit 33adf4c85dd553eb607bcf9c02c5fa60c8738a68)

Conflicts:
	third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp
	third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

TBR=rockot@chromium.org, dtrainor@chromium.org, haraken@chromium.org,
bsalomon@google.com, tsepez@chromium.org
since the gist of the CL hasn't changed.

Review-Url: https://codereview.chromium.org/2681913003
Cr-Original-Original-Commit-Position: refs/heads/master@{#450582}
Review-Url: https://codereview.chromium.org/2753413002
Cr-Original-Commit-Position: refs/heads/master@{#458010}
Review-Url: https://codereview.chromium.org/2765723002
Cr-Commit-Position: refs/heads/master@{#458657}
==========

to

==========
RELAND2: ShapeDetection: use mojom::Bitmap for mojo interface.
    
    Original CL got reverted due to test cases are concurrent in same
    script context, it will cause random crash/time out.
    
    CL [1] and CL [2] has resolved the random issue, so rebase the commit
    align with the latest code.
    
    [1] https://chromium-review.googlesource.com/475077
    [2] https://codereview.chromium.org/2818563006
    
    Original CL description ------------------------------------------------
    ShapeDetection: use mojom::Bitmap for mojo interface.
    
    This CL uses mojo::Bitmap for mojo ShapeDetection interfaces definition,
    so that the Detect API is completely flexible and friendly.
    
    BUG=665488
    TEST(Layout)=
    
third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html
    
third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html
    
third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html
    
third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html
    
third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html
     third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html
     third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html
    
    Review-Url: https://codereview.chromium.org/2629433003
    Cr-Commit-Position: refs/heads/master@{#446142}
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
    
    Review-Url: https://codereview.chromium.org/2681913003
    Cr-Original-Original-Commit-Position: refs/heads/master@{#450582}
    Review-Url: https://codereview.chromium.org/2753413002
    Cr-Original-Commit-Position: refs/heads/master@{#458010}
    Review-Url: https://codereview.chromium.org/2765723002
    Cr-Commit-Position: refs/heads/master@{#458657}
==========

[junwei, 2017-05-12 07:13:00]

junwei.fu@intel.com changed reviewers:
+ dpranke@chromium.org, mcasas@chromium.org

[junwei, 2017-05-12 07:13:00]

mcasas@ PTAL.

[bsalomon, 2017-05-12 11:57:24]

lgtm

[mcasas, 2017-05-12 16:22:57]

On 2017/05/12 11:57:24, bsalomon wrote:
> lgtm

Hmm this is not a 100%  reland because the code underneath
has changed (e.g. all Java files were moved to //services). 
Could you please change the title to reflect that, and just
specify the parts that landed before and the parts that are
fully new? (Also as notes to the reviewers).

[Tom Sepez, 2017-05-12 16:23:26]

lgtm

[junwei, 2017-05-15 08:24:36]

On 2017/05/12 16:22:57, mcasas wrote:
> On 2017/05/12 11:57:24, bsalomon wrote:
> > lgtm
> 
> Hmm this is not a 100%  reland because the code underneath
> has changed (e.g. all Java files were moved to //services). 
> Could you please change the title to reflect that, and just
> specify the parts that landed before and the parts that are
> fully new? (Also as notes to the reviewers).

Thanks Done. It's better all of review.

[mcasas, 2017-05-15 22:40:23]

Would you mind verifying that this patch works
on Android with:

https://beaufortfrancois.github.io/sandbox/media-recorder/mustache.html 	

for at least, say, 100 seconds without running out
of memory?  (There was a leak but now it should be
corrected).

https://codereview.chromium.org/2875243002/diff/20001/services/shape_detectio...
File
services/shape_detection/android/java/src/org/chromium/shape_detection/FaceDetectionImpl.java
(right):

https://codereview.chromium.org/2875243002/diff/20001/services/shape_detectio...
services/shape_detection/android/java/src/org/chromium/shape_detection/FaceDetectionImpl.java:70:
Bitmap bitmap = Bitmap.createBitmap(width, height, Bitmap.Config.ARGB_8888);
This method should use 
Frame frame = SharedBufferUtils.convertToFrame(bitmapData);
like the other .java files, right?

[mcasas, 2017-05-16 18:12:53]

https://codereview.chromium.org/2875243002/diff/20001/services/shape_detectio...
File
services/shape_detection/android/java/src/org/chromium/shape_detection/SharedBufferUtils.java
(right):

https://codereview.chromium.org/2875243002/diff/20001/services/shape_detectio...
services/shape_detection/android/java/src/org/chromium/shape_detection/SharedBufferUtils.java:18:
public class SharedBufferUtils {
Also this file/class should not be called 
SharedBufferUtils.  This applies to l.16 as well.

[junwei, 2017-05-17 01:09:36]

On 2017/05/15 22:40:23, mcasas wrote:
> Would you mind verifying that this patch works
> on Android with:
> 
> https://beaufortfrancois.github.io/sandbox/media-recorder/mustache.html 	
> 
> for at least, say, 100 seconds without running out
> of memory?  (There was a leak but now it should be
> corrected).
How to run the patch with this Mustanche?

>
https://codereview.chromium.org/2875243002/diff/20001/services/shape_detectio...
> File
>
services/shape_detection/android/java/src/org/chromium/shape_detection/FaceDetectionImpl.java
> (right):
> 
>
https://codereview.chromium.org/2875243002/diff/20001/services/shape_detectio...
>
services/shape_detection/android/java/src/org/chromium/shape_detection/FaceDetectionImpl.java:70:
> Bitmap bitmap = Bitmap.createBitmap(width, height, Bitmap.Config.ARGB_8888);
> This method should use 
> Frame frame = SharedBufferUtils.convertToFrame(bitmapData);
> like the other .java files, right?
convertToFrame is return Frame that is not need in here, how about split it into
two method, one is conditional judgment, another is create frame with Bitmap?

[junwei, 2017-05-17 01:15:25]

The CQ bit was checked by junwei.fu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 01:16:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 03:12:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 03:12:37]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[David Trainor- moved to gerrit, 2017-05-17 17:34:40]

lgtm

[mcasas, 2017-05-17 22:32:57]

On 2017/05/17 01:09:36, junwei wrote:
> On 2017/05/15 22:40:23, mcasas wrote:
> > Would you mind verifying that this patch works
> > on Android with:
> > 
> > https://beaufortfrancois.github.io/sandbox/media-recorder/mustache.html 	
> > 
> > for at least, say, 100 seconds without running out
> > of memory?  (There was a leak but now it should be
> > corrected).
> How to run the patch with this Mustanche?

Build and install chrome_public_apk (as you are doing now,
right?), see the instructions at
https://chromium.googlesource.com/chromium/src/+/master/docs/android_build_in...
and don't forget the 
chrome://flags/#enable-experimental-web-platform-features
flag to be connected.

> 
> >
>
https://codereview.chromium.org/2875243002/diff/20001/services/shape_detectio...
> > File
> >
>
services/shape_detection/android/java/src/org/chromium/shape_detection/FaceDetectionImpl.java
> > (right):
> > 
> >
>
https://codereview.chromium.org/2875243002/diff/20001/services/shape_detectio...
> >
>
services/shape_detection/android/java/src/org/chromium/shape_detection/FaceDetectionImpl.java:70:
> > Bitmap bitmap = Bitmap.createBitmap(width, height, Bitmap.Config.ARGB_8888);
> > This method should use 
> > Frame frame = SharedBufferUtils.convertToFrame(bitmapData);
> > like the other .java files, right?
> convertToFrame is return Frame that is not need in here, how about split it
into
> two method, one is conditional judgment, another is create frame with Bitmap?

I'm sorry I don't understand that.  Note that there's a patch
landing 2 JS unittests at https://crrev.com/2863773005/, so
you'll have to rebase this patch.

Please rename the files and classes appropriately to reflect
that you're using Bitmaps, e.g. SharedBufferUtils should become
BitmapUtils etc.


And please edit the CL description to point out explicitly
what is reland and what is new code.

[junwei, 2017-05-19 08:46:13]

Description was changed from

==========
RELAND2: ShapeDetection: use mojom::Bitmap for mojo interface.
    
    Original CL got reverted due to test cases are concurrent in same
    script context, it will cause random crash/time out.
    
    CL [1] and CL [2] has resolved the random issue, so rebase the commit
    align with the latest code.
    
    [1] https://chromium-review.googlesource.com/475077
    [2] https://codereview.chromium.org/2818563006
    
    Original CL description ------------------------------------------------
    ShapeDetection: use mojom::Bitmap for mojo interface.
    
    This CL uses mojo::Bitmap for mojo ShapeDetection interfaces definition,
    so that the Detect API is completely flexible and friendly.
    
    BUG=665488
    TEST(Layout)=
    
third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html
    
third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html
    
third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html
    
third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html
    
third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html
     third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html
     third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html
    
    Review-Url: https://codereview.chromium.org/2629433003
    Cr-Commit-Position: refs/heads/master@{#446142}
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
    
    Review-Url: https://codereview.chromium.org/2681913003
    Cr-Original-Original-Commit-Position: refs/heads/master@{#450582}
    Review-Url: https://codereview.chromium.org/2753413002
    Cr-Original-Commit-Position: refs/heads/master@{#458010}
    Review-Url: https://codereview.chromium.org/2765723002
    Cr-Commit-Position: refs/heads/master@{#458657}
==========

to

==========
RELAND2: ShapeDetection: use mojom::Bitmap for mojo interface.
    
    Original CL got reverted due to test cases are concurrent in same
    script context, it will cause random crash/time out.
    
    CL [1] and CL [2] has resolved the random issue, so rebase the commit
    align with the latest code.
    
    [1] https://chromium-review.googlesource.com/475077
    [2] https://codereview.chromium.org/2818563006
    
    Original CL description ------------------------------------------------
    ShapeDetection: use mojom::Bitmap for mojo interface.
    
    This CL uses mojo::Bitmap for mojo ShapeDetection interfaces definition,
    so that the Detect API is completely flexible and friendly.
    
    BUG=665488
    TEST(Layout)=
    
third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html
    
third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html
    
third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html
    
third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html
    
third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html
     third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html
     third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html
    
    Review-Url: https://codereview.chromium.org/2629433003
    Cr-Commit-Position: refs/heads/master@{#446142}
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
    
    Review-Url: https://codereview.chromium.org/2681913003
    Cr-Original-Original-Commit-Position: refs/heads/master@{#450582}
    Review-Url: https://codereview.chromium.org/2753413002
    Cr-Original-Commit-Position: refs/heads/master@{#458010}
    Review-Url: https://codereview.chromium.org/2765723002
    Cr-Commit-Position: refs/heads/master@{#458657}
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[junwei, 2017-05-19 10:47:03]

Patchset #5 (id:80001) has been deleted

[junwei, 2017-05-19 10:47:19]

Patchset #4 (id:60001) has been deleted

[junwei, 2017-05-19 10:47:58]

Patchset #3 (id:40001) has been deleted

[junwei, 2017-05-19 11:35:16]

Description was changed from

==========
RELAND2: ShapeDetection: use mojom::Bitmap for mojo interface.
    
    Original CL got reverted due to test cases are concurrent in same
    script context, it will cause random crash/time out.
    
    CL [1] and CL [2] has resolved the random issue, so rebase the commit
    align with the latest code.
    
    [1] https://chromium-review.googlesource.com/475077
    [2] https://codereview.chromium.org/2818563006
    
    Original CL description ------------------------------------------------
    ShapeDetection: use mojom::Bitmap for mojo interface.
    
    This CL uses mojo::Bitmap for mojo ShapeDetection interfaces definition,
    so that the Detect API is completely flexible and friendly.
    
    BUG=665488
    TEST(Layout)=
    
third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html
    
third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html
    
third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html
    
third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html
    
third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html
     third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html
     third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html
    
    Review-Url: https://codereview.chromium.org/2629433003
    Cr-Commit-Position: refs/heads/master@{#446142}
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
    
    Review-Url: https://codereview.chromium.org/2681913003
    Cr-Original-Original-Commit-Position: refs/heads/master@{#450582}
    Review-Url: https://codereview.chromium.org/2753413002
    Cr-Original-Commit-Position: refs/heads/master@{#458010}
    Review-Url: https://codereview.chromium.org/2765723002
    Cr-Commit-Position: refs/heads/master@{#458657}
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
RELAND2: ShapeDetection: use mojom::Bitmap for mojo interface.
    
Original CL got reverted due to test cases are concurrent in same
script context, it will cause random crash/time out.
    
CL [1] has resolved the random issue, so rebase the commit
align with the latest code. Reland implementation of detecting on mac platform,
layout tests files, interface definition in mojom file and implementation in
/Source/modules/shapedetion. Implementation on Android platform is new code
include all of java files.
    
    [1] https://chromium-review.googlesource.com/475077
    
    Original CL description ------------------------------------------------
    ShapeDetection: use mojom::Bitmap for mojo interface.
    
    This CL uses mojo::Bitmap for mojo ShapeDetection interfaces definition,
    so that the Detect API is completely flexible and friendly.
    
    BUG=665488
    TEST(Layout)=
    
third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html
    
third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html
    
third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html
    
third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html
    
third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html
     third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html
     third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html
    
    Review-Url: https://codereview.chromium.org/2629433003
    Cr-Commit-Position: refs/heads/master@{#446142}
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
    
    Review-Url: https://codereview.chromium.org/2681913003
    Cr-Original-Original-Commit-Position: refs/heads/master@{#450582}
    Review-Url: https://codereview.chromium.org/2753413002
    Cr-Original-Commit-Position: refs/heads/master@{#458010}
    Review-Url: https://codereview.chromium.org/2765723002
    Cr-Commit-Position: refs/heads/master@{#458657}
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[junwei, 2017-05-19 11:37:08]

Description was changed from

==========
RELAND2: ShapeDetection: use mojom::Bitmap for mojo interface.
    
Original CL got reverted due to test cases are concurrent in same
script context, it will cause random crash/time out.
    
CL [1] has resolved the random issue, so rebase the commit
align with the latest code. Reland implementation of detecting on mac platform,
layout tests files, interface definition in mojom file and implementation in
/Source/modules/shapedetion. Implementation on Android platform is new code
include all of java files.
    
    [1] https://chromium-review.googlesource.com/475077
    
    Original CL description ------------------------------------------------
    ShapeDetection: use mojom::Bitmap for mojo interface.
    
    This CL uses mojo::Bitmap for mojo ShapeDetection interfaces definition,
    so that the Detect API is completely flexible and friendly.
    
    BUG=665488
    TEST(Layout)=
    
third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html
    
third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html
    
third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html
    
third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html
    
third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html
     third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html
     third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html
    
    Review-Url: https://codereview.chromium.org/2629433003
    Cr-Commit-Position: refs/heads/master@{#446142}
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
    
    Review-Url: https://codereview.chromium.org/2681913003
    Cr-Original-Original-Commit-Position: refs/heads/master@{#450582}
    Review-Url: https://codereview.chromium.org/2753413002
    Cr-Original-Commit-Position: refs/heads/master@{#458010}
    Review-Url: https://codereview.chromium.org/2765723002
    Cr-Commit-Position: refs/heads/master@{#458657}
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
RELAND2: ShapeDetection: use mojom::Bitmap for mojo interface.
    
    Original CL got reverted due to test cases are concurrent in same
    script context, it will cause random crash/time out.
    
    CL [1] has resolved the random issue, so rebase the commit align with
    the latest code. Reland implementation of detecting on mac 
    platform,
    layout tests files, interface definition in mojom file and
    implementation in /Source/modules/shapedetion. Implementation on
    Android platform is new code include all of java files.
    
    [1] https://chromium-review.googlesource.com/475077
    
    Original CL description ------------------------------------------------
    ShapeDetection: use mojom::Bitmap for mojo interface.
    
    This CL uses mojo::Bitmap for mojo ShapeDetection interfaces definition,
    so that the Detect API is completely flexible and friendly.
    
    BUG=665488
    TEST(Layout)=
    
third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html
    
third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html
    
third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html
    
third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html
    
third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html
     third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html
     third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html
    
    Review-Url: https://codereview.chromium.org/2629433003
    Cr-Commit-Position: refs/heads/master@{#446142}
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
    
    Review-Url: https://codereview.chromium.org/2681913003
    Cr-Original-Original-Commit-Position: refs/heads/master@{#450582}
    Review-Url: https://codereview.chromium.org/2753413002
    Cr-Original-Commit-Position: refs/heads/master@{#458010}
    Review-Url: https://codereview.chromium.org/2765723002
    Cr-Commit-Position: refs/heads/master@{#458657}
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[junwei, 2017-05-19 11:37:39]

Description was changed from

==========
RELAND2: ShapeDetection: use mojom::Bitmap for mojo interface.
    
    Original CL got reverted due to test cases are concurrent in same
    script context, it will cause random crash/time out.
    
    CL [1] has resolved the random issue, so rebase the commit align with
    the latest code. Reland implementation of detecting on mac 
    platform,
    layout tests files, interface definition in mojom file and
    implementation in /Source/modules/shapedetion. Implementation on
    Android platform is new code include all of java files.
    
    [1] https://chromium-review.googlesource.com/475077
    
    Original CL description ------------------------------------------------
    ShapeDetection: use mojom::Bitmap for mojo interface.
    
    This CL uses mojo::Bitmap for mojo ShapeDetection interfaces definition,
    so that the Detect API is completely flexible and friendly.
    
    BUG=665488
    TEST(Layout)=
    
third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html
    
third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html
    
third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html
    
third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html
    
third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html
     third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html
     third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html
    
    Review-Url: https://codereview.chromium.org/2629433003
    Cr-Commit-Position: refs/heads/master@{#446142}
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
    
    Review-Url: https://codereview.chromium.org/2681913003
    Cr-Original-Original-Commit-Position: refs/heads/master@{#450582}
    Review-Url: https://codereview.chromium.org/2753413002
    Cr-Original-Commit-Position: refs/heads/master@{#458010}
    Review-Url: https://codereview.chromium.org/2765723002
    Cr-Commit-Position: refs/heads/master@{#458657}
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
RELAND2: ShapeDetection: use mojom::Bitmap for mojo interface.
    
    Original CL got reverted due to test cases are concurrent in same
    script context, it will cause random crash/time out.
    
    CL [1] has resolved the random issue, so rebase the commit align with
    the latest code. Reland implementation of detecting on mac 
    platform, layout tests files, interface definition in mojom file and
    implementation in /Source/modules/shapedetion. Implementation on
    Android platform is new code include all of java files.
    
    [1] https://chromium-review.googlesource.com/475077
    
    Original CL description ------------------------------------------------
    ShapeDetection: use mojom::Bitmap for mojo interface.
    
    This CL uses mojo::Bitmap for mojo ShapeDetection interfaces definition,
    so that the Detect API is completely flexible and friendly.
    
    BUG=665488
    TEST(Layout)=
    
third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html
    
third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html
    
third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html
    
third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html
    
third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html
     third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html
     third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html
    
    Review-Url: https://codereview.chromium.org/2629433003
    Cr-Commit-Position: refs/heads/master@{#446142}
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
    
    Review-Url: https://codereview.chromium.org/2681913003
    Cr-Original-Original-Commit-Position: refs/heads/master@{#450582}
    Review-Url: https://codereview.chromium.org/2753413002
    Cr-Original-Commit-Position: refs/heads/master@{#458010}
    Review-Url: https://codereview.chromium.org/2765723002
    Cr-Commit-Position: refs/heads/master@{#458657}
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[junwei, 2017-05-19 11:38:28]

On 2017/05/17 22:32:57, mcasas wrote:
> On 2017/05/17 01:09:36, junwei wrote:
> > On 2017/05/15 22:40:23, mcasas wrote:
> > > Would you mind verifying that this patch works
> > > on Android with:
> > > 
> > > https://beaufortfrancois.github.io/sandbox/media-recorder/mustache.html 	
> > > 
> > > for at least, say, 100 seconds without running out
> > > of memory?  (There was a leak but now it should be
> > > corrected).
> > How to run the patch with this Mustanche?
> 
> Build and install chrome_public_apk (as you are doing now,
> right?), see the instructions at
>
https://chromium.googlesource.com/chromium/src/+/master/docs/android_build_in...
> and don't forget the 
> chrome://flags/#enable-experimental-web-platform-features
> flag to be connected.
> 
> > 
> > >
> >
>
https://codereview.chromium.org/2875243002/diff/20001/services/shape_detectio...
> > > File
> > >
> >
>
services/shape_detection/android/java/src/org/chromium/shape_detection/FaceDetectionImpl.java
> > > (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/2875243002/diff/20001/services/shape_detectio...
> > >
> >
>
services/shape_detection/android/java/src/org/chromium/shape_detection/FaceDetectionImpl.java:70:
> > > Bitmap bitmap = Bitmap.createBitmap(width, height,
Bitmap.Config.ARGB_8888);
> > > This method should use 
> > > Frame frame = SharedBufferUtils.convertToFrame(bitmapData);
> > > like the other .java files, right?
> > convertToFrame is return Frame that is not need in here, how about split it
> into
> > two method, one is conditional judgment, another is create frame with
Bitmap?
> 
> I'm sorry I don't understand that.  Note that there's a patch
> landing 2 JS unittests at https://crrev.com/2863773005/, so
> you'll have to rebase this patch.
Done.

> Please rename the files and classes appropriately to reflect
> that you're using Bitmaps, e.g. SharedBufferUtils should become
> BitmapUtils etc.
Done.

> And please edit the CL description to point out explicitly
> what is reland and what is new code.
Done.

[mcasas, 2017-05-19 17:20:22]

Almost there!

https://codereview.chromium.org/2875243002/diff/100001/services/shape_detecti...
File
services/shape_detection/android/java/src/org/chromium/shape_detection/BitmapUtils.java
(right):

https://codereview.chromium.org/2875243002/diff/100001/services/shape_detecti...
services/shape_detection/android/java/src/org/chromium/shape_detection/BitmapUtils.java:46:
public static Frame convertToFrame(org.chromium.skia.mojom.Bitmap bitmapData) {
This method is called convertToX() whereas the previous
one is called createX(), can we homogenise those names?
I.e. either both convertTo...() or both create...()

https://codereview.chromium.org/2875243002/diff/100001/services/shape_detecti...
services/shape_detection/android/java/src/org/chromium/shape_detection/BitmapUtils.java:54:
}
We landed recently a Junit test for the predecessor of
this file, SharedBufferUtils.java, in SharedBufferUtilsTest.java
(see [1]), please rename it and update the tests as
appropriate to cover the "return null" cases of this file.

You can compile and run these tests locally with:

ninja -j 30 -C out/gn service_junit_tests
./out/gn/bin/run_service_junit_tests -f *shape_detection*



[1]
https://cs.chromium.org/chromium/src/services/shape_detection/android/junit/s...

[junwei, 2017-05-22 05:56:51]

The CQ bit was checked by junwei.fu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 05:57:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 06:14:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 06:14:52]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[junwei, 2017-05-22 07:12:41]

Patchset #4 (id:110001) has been deleted

[junwei, 2017-05-22 07:12:50]

The CQ bit was checked by junwei.fu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 07:13:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 07:34:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 07:34:35]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[junwei, 2017-05-22 07:54:42]

The CQ bit was checked by junwei.fu@intel.com to run a CQ dry run

[junwei, 2017-05-22 07:54:48]

Patchset #4 (id:130001) has been deleted

[commit-bot: I haz the power, 2017-05-22 07:54:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 08:18:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 08:18:45]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[junwei, 2017-05-22 08:27:36]

Patchset #4 (id:150001) has been deleted

[junwei, 2017-05-22 08:27:44]

The CQ bit was checked by junwei.fu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 08:28:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 09:00:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 09:01:00]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[junwei, 2017-05-22 11:32:37]

The CQ bit was checked by junwei.fu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 11:32:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[junwei, 2017-05-22 11:33:01]

Patchset #4 (id:170001) has been deleted

[junwei, 2017-05-22 11:44:05]

On 2017/05/19 17:20:22, mcasas wrote:
> Almost there!
> 
>
https://codereview.chromium.org/2875243002/diff/100001/services/shape_detecti...
> File
>
services/shape_detection/android/java/src/org/chromium/shape_detection/BitmapUtils.java
> (right):
> 
>
https://codereview.chromium.org/2875243002/diff/100001/services/shape_detecti...
>
services/shape_detection/android/java/src/org/chromium/shape_detection/BitmapUtils.java:46:
> public static Frame convertToFrame(org.chromium.skia.mojom.Bitmap bitmapData)
{
> This method is called convertToX() whereas the previous
> one is called createX(), can we homogenise those names?
> I.e. either both convertTo...() or both create...()
Done.

>
https://codereview.chromium.org/2875243002/diff/100001/services/shape_detecti...
>
services/shape_detection/android/java/src/org/chromium/shape_detection/BitmapUtils.java:54:
> }
> We landed recently a Junit test for the predecessor of
> this file, SharedBufferUtils.java, in SharedBufferUtilsTest.java
> (see [1]), please rename it and update the tests as
> appropriate to cover the "return null" cases of this file.
Done.

> You can compile and run these tests locally with:
> 
> ninja -j 30 -C out/gn service_junit_tests
> ./out/gn/bin/run_service_junit_tests -f *shape_detection*
Will verify it soon.

[commit-bot: I haz the power, 2017-05-22 12:12:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 12:12:51]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[junwei, 2017-05-22 12:28:43]

> > You can compile and run these tests locally with:
> > 
> > ninja -j 30 -C out/gn service_junit_tests
> > ./out/gn/bin/run_service_junit_tests -f *shape_detection*
> Will verify it soon.

ninja: error: loading '*shape_detection*': No such file or directory

[junwei, 2017-05-22 13:02:00]

The CQ bit was checked by junwei.fu@intel.com to run a CQ dry run

[junwei, 2017-05-22 13:02:08]

Patchset #4 (id:190001) has been deleted

[commit-bot: I haz the power, 2017-05-22 13:02:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 14:50:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 14:50:53]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[mcasas, 2017-05-22 17:57:21]

On 2017/05/22 12:28:43, junwei wrote:
> > > You can compile and run these tests locally with:
> > > 
> > > ninja -j 30 -C out/gn service_junit_tests
> > > ./out/gn/bin/run_service_junit_tests -f *shape_detection*
> > Will verify it soon.
> 
> ninja: error: loading '*shape_detection*': No such file or directory

Those are two different execution lines, first, to compile:
ninja -j 30 -C out/gn service_junit_tests

then, to run the tests:
./out/gn/bin/run_service_junit_tests -f *shape_detection*

the tests are looking good but failing in linux_android_rel_ng:
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.andro...

[junwei, 2017-05-23 12:36:47]

On 2017/05/22 17:57:21, mcasas wrote:
> On 2017/05/22 12:28:43, junwei wrote:
> > > > You can compile and run these tests locally with:
> > > > 
> > > > ninja -j 30 -C out/gn service_junit_tests
> > > > ./out/gn/bin/run_service_junit_tests -f *shape_detection*
> > > Will verify it soon.
> > 
> > ninja: error: loading '*shape_detection*': No such file or directory
> 
> Those are two different execution lines, first, to compile:
> ninja -j 30 -C out/gn service_junit_tests
> 
> then, to run the tests:
> ./out/gn/bin/run_service_junit_tests -f *shape_detection*
> 
> the tests are looking good but failing in linux_android_rel_ng:
>
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.andro...

Mockito can not mock final class org.chromium.skia.mojom.Bitmap, i am trying to
fix it.

[junwei, 2017-05-24 10:55:38]

Patchset #4 (id:210001) has been deleted

[junwei, 2017-05-24 10:55:39]

The CQ bit was checked by junwei.fu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 10:55:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 10:58:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 10:58:18]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[junwei, 2017-05-24 10:59:05]

On 2017/05/23 12:36:47, junwei wrote:
> On 2017/05/22 17:57:21, mcasas wrote:
> > On 2017/05/22 12:28:43, junwei wrote:
> > > > > You can compile and run these tests locally with:
> > > > > 
> > > > > ninja -j 30 -C out/gn service_junit_tests
> > > > > ./out/gn/bin/run_service_junit_tests -f *shape_detection*
> > > > Will verify it soon.
> > > 
> > > ninja: error: loading '*shape_detection*': No such file or directory
> > 
> > Those are two different execution lines, first, to compile:
> > ninja -j 30 -C out/gn service_junit_tests
> > 
> > then, to run the tests:
> > ./out/gn/bin/run_service_junit_tests -f *shape_detection*
> > 
> > the tests are looking good but failing in linux_android_rel_ng:
> >
>
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.andro...
> 
> Mockito can not mock final class org.chromium.skia.mojom.Bitmap, i am trying
to
> fix it.
Using real Bitmap instead of Mock Object because the version of Mockito in
chromium isn't support final class.

[junwei, 2017-05-24 11:17:16]

The CQ bit was checked by junwei.fu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 11:17:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[junwei, 2017-05-24 11:17:46]

Patchset #5 (id:230001) has been deleted

[junwei, 2017-05-24 11:19:19]

Patchset #4 (id:210001) has been deleted

[commit-bot: I haz the power, 2017-05-24 13:02:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 13:02:37]

Dry run: This issue passed the CQ dry run.

[mcasas, 2017-05-24 16:40:20]

On 2017/05/24 10:59:05, junwei wrote:
> On 2017/05/23 12:36:47, junwei wrote:
> > On 2017/05/22 17:57:21, mcasas wrote:
> > > On 2017/05/22 12:28:43, junwei wrote:
> > > > > > You can compile and run these tests locally with:
> > > > > > 
> > > > > > ninja -j 30 -C out/gn service_junit_tests
> > > > > > ./out/gn/bin/run_service_junit_tests -f *shape_detection*
> > > > > Will verify it soon.
> > > > 
> > > > ninja: error: loading '*shape_detection*': No such file or directory
> > > 
> > > Those are two different execution lines, first, to compile:
> > > ninja -j 30 -C out/gn service_junit_tests
> > > 
> > > then, to run the tests:
> > > ./out/gn/bin/run_service_junit_tests -f *shape_detection*
> > > 
> > > the tests are looking good but failing in linux_android_rel_ng:
> > >
> >
>
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.andro...
> > 
> > Mockito can not mock final class org.chromium.skia.mojom.Bitmap, i am trying
> to
> > fix it.
> Using real Bitmap instead of Mock Object because the version of Mockito in
> chromium isn't support final class.

In this case you should have used robolectric ShadowBitmap [1]
but PS4 is good enough and don't want to block this patch more
than is necessary, so lgtm, ship it !

[1] http://robolectric.org/javadoc/3.0/org/robolectric/shadows/ShadowBitmap.html

[junwei, 2017-05-25 00:58:33]

The CQ bit was checked by junwei.fu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 00:59:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 04:39:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 04:39:07]

Dry run: This issue passed the CQ dry run.

[junwei, 2017-05-25 06:42:11]

Patchset #4 (id:250001) has been deleted

[junwei, 2017-05-31 07:16:45]

The CQ bit was checked by junwei.fu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 07:17:00]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 09:25:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 09:25:32]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mcasas, 2017-05-31 16:25:51]

On 2017/05/24 16:40:20, mcasas wrote:
> On 2017/05/24 10:59:05, junwei wrote:
> > On 2017/05/23 12:36:47, junwei wrote:
> > > On 2017/05/22 17:57:21, mcasas wrote:
> > > > On 2017/05/22 12:28:43, junwei wrote:
> > > > > > > You can compile and run these tests locally with:
> > > > > > > 
> > > > > > > ninja -j 30 -C out/gn service_junit_tests
> > > > > > > ./out/gn/bin/run_service_junit_tests -f *shape_detection*
> > > > > > Will verify it soon.
> > > > > 
> > > > > ninja: error: loading '*shape_detection*': No such file or directory
> > > > 
> > > > Those are two different execution lines, first, to compile:
> > > > ninja -j 30 -C out/gn service_junit_tests
> > > > 
> > > > then, to run the tests:
> > > > ./out/gn/bin/run_service_junit_tests -f *shape_detection*
> > > > 
> > > > the tests are looking good but failing in linux_android_rel_ng:
> > > >
> > >
> >
>
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.andro...
> > > 
> > > Mockito can not mock final class org.chromium.skia.mojom.Bitmap, i am
trying
> > to
> > > fix it.
> > Using real Bitmap instead of Mock Object because the version of Mockito in
> > chromium isn't support final class.
> 
> In this case you should have used robolectric ShadowBitmap [1]
> but PS4 is good enough and don't want to block this patch more
> than is necessary, so lgtm, ship it !
> 
> [1]
http://robolectric.org/javadoc/3.0/org/robolectric/shadows/ShadowBitmap.html

junwei.fu@ what's the plan now for this CL?

[junwei, 2017-06-01 00:29:11]

On 2017/05/31 16:25:51, mcasas wrote:
> On 2017/05/24 16:40:20, mcasas wrote:
> > On 2017/05/24 10:59:05, junwei wrote:
> > > On 2017/05/23 12:36:47, junwei wrote:
> > > > On 2017/05/22 17:57:21, mcasas wrote:
> > > > > On 2017/05/22 12:28:43, junwei wrote:
> > > > > > > > You can compile and run these tests locally with:
> > > > > > > > 
> > > > > > > > ninja -j 30 -C out/gn service_junit_tests
> > > > > > > > ./out/gn/bin/run_service_junit_tests -f *shape_detection*
> > > > > > > Will verify it soon.
> > > > > > 
> > > > > > ninja: error: loading '*shape_detection*': No such file or directory
> > > > > 
> > > > > Those are two different execution lines, first, to compile:
> > > > > ninja -j 30 -C out/gn service_junit_tests
> > > > > 
> > > > > then, to run the tests:
> > > > > ./out/gn/bin/run_service_junit_tests -f *shape_detection*
> > > > > 
> > > > > the tests are looking good but failing in linux_android_rel_ng:
> > > > >
> > > >
> > >
> >
>
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.andro...
> > > > 
> > > > Mockito can not mock final class org.chromium.skia.mojom.Bitmap, i am
> trying
> > > to
> > > > fix it.
> > > Using real Bitmap instead of Mock Object because the version of Mockito in
> > > chromium isn't support final class.
> > 
> > In this case you should have used robolectric ShadowBitmap [1]
> > but PS4 is good enough and don't want to block this patch more
> > than is necessary, so lgtm, ship it !
> > 
> > [1]
> http://robolectric.org/javadoc/3.0/org/robolectric/shadows/ShadowBitmap.html
> 
> junwei.fu@ what's the plan now for this CL?

Tests will time out after updating the latest code, i have requested a CL [1]
that will be landed today.

[1] https://codereview.chromium.org/2912323002/#

[junwei, 2017-06-02 04:05:10]

The CQ bit was checked by junwei.fu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 04:05:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 05:56:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 05:56:39]

Dry run: This issue passed the CQ dry run.

[junwei, 2017-06-02 06:05:56]

Patchset #5 (id:290001) has been deleted

[junwei, 2017-06-02 07:00:08]

The CQ bit was checked by junwei.fu@intel.com

[junwei, 2017-06-02 07:00:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org, bsalomon@google.com, tsepez@chromium.org,
mcasas@chromium.org
Link to the patchset: https://codereview.chromium.org/2875243002/#ps310001
(title: "RELAND2: ShapeDetection: use mojom::Bitmap for mojo interface.")

[commit-bot: I haz the power, 2017-06-02 07:00:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 07:08:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 07:08:12]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[junwei, 2017-06-02 07:29:52]

Description was changed from

==========
RELAND2: ShapeDetection: use mojom::Bitmap for mojo interface.
    
    Original CL got reverted due to test cases are concurrent in same
    script context, it will cause random crash/time out.
    
    CL [1] has resolved the random issue, so rebase the commit align with
    the latest code. Reland implementation of detecting on mac 
    platform, layout tests files, interface definition in mojom file and
    implementation in /Source/modules/shapedetion. Implementation on
    Android platform is new code include all of java files.
    
    [1] https://chromium-review.googlesource.com/475077
    
    Original CL description ------------------------------------------------
    ShapeDetection: use mojom::Bitmap for mojo interface.
    
    This CL uses mojo::Bitmap for mojo ShapeDetection interfaces definition,
    so that the Detect API is completely flexible and friendly.
    
    BUG=665488
    TEST(Layout)=
    
third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html
    
third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html
    
third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html
    
third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html
    
third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html
     third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html
     third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html
    
    Review-Url: https://codereview.chromium.org/2629433003
    Cr-Commit-Position: refs/heads/master@{#446142}
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
    
    Review-Url: https://codereview.chromium.org/2681913003
    Cr-Original-Original-Commit-Position: refs/heads/master@{#450582}
    Review-Url: https://codereview.chromium.org/2753413002
    Cr-Original-Commit-Position: refs/heads/master@{#458010}
    Review-Url: https://codereview.chromium.org/2765723002
    Cr-Commit-Position: refs/heads/master@{#458657}
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
RELAND2: ShapeDetection: use mojom::Bitmap for mojo interface.
    
    Original CL got reverted due to test cases are concurrent in same
    script context, it will cause random crash/time out.
    
    CL [1] has resolved the random issue, so rebase the commit align with
    the latest code. Reland implementation of detecting on mac 
    platform, layout tests files, interface definition in mojom file and
    implementation in /Source/modules/shapedetion. Implementation on
    Android platform is new code include all of java files.
    
    [1] https://chromium-review.googlesource.com/475077
    
    Original CL description ------------------------------------------------
    ShapeDetection: use mojom::Bitmap for mojo interface.
    
    This CL uses mojo::Bitmap for mojo ShapeDetection interfaces definition,
    so that the Detect API is completely flexible and friendly.
    
    BUG=665488
    TEST(Layout)=
    
third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html
    
third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html
    
third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html
    
third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html
    
third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html
     third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html
     third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html
    
    Review-Url: https://codereview.chromium.org/2629433003
    Cr-Commit-Position: refs/heads/master@{#446142}
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

TBR=rockot@chromium.org, dtrainor@chromium.org, haraken@chromium.org
since the gist of the CL hasn't changed.
    
    Review-Url: https://codereview.chromium.org/2681913003
    Cr-Original-Original-Commit-Position: refs/heads/master@{#450582}
    Review-Url: https://codereview.chromium.org/2753413002
    Cr-Original-Commit-Position: refs/heads/master@{#458010}
    Review-Url: https://codereview.chromium.org/2765723002
    Cr-Commit-Position: refs/heads/master@{#458657}
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[junwei, 2017-06-02 07:30:18]

The CQ bit was checked by junwei.fu@intel.com

[commit-bot: I haz the power, 2017-06-02 07:30:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 07:35:59]

CQ is committing da patch.

Bot data: {"patchset_id": 310001, "attempt_start_ts": 1496388618481370,
"parent_rev": "de8768ff87be6c854b998864584d0c7c2e3adfea", "commit_rev":
"31eb1a542aea4050d9b17fd7255d366499dedede"}

[commit-bot: I haz the power, 2017-06-02 07:36:09]

Description was changed from

==========
RELAND2: ShapeDetection: use mojom::Bitmap for mojo interface.
    
    Original CL got reverted due to test cases are concurrent in same
    script context, it will cause random crash/time out.
    
    CL [1] has resolved the random issue, so rebase the commit align with
    the latest code. Reland implementation of detecting on mac 
    platform, layout tests files, interface definition in mojom file and
    implementation in /Source/modules/shapedetion. Implementation on
    Android platform is new code include all of java files.
    
    [1] https://chromium-review.googlesource.com/475077
    
    Original CL description ------------------------------------------------
    ShapeDetection: use mojom::Bitmap for mojo interface.
    
    This CL uses mojo::Bitmap for mojo ShapeDetection interfaces definition,
    so that the Detect API is completely flexible and friendly.
    
    BUG=665488
    TEST(Layout)=
    
third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html
    
third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html
    
third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html
    
third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html
    
third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html
     third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html
     third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html
    
    Review-Url: https://codereview.chromium.org/2629433003
    Cr-Commit-Position: refs/heads/master@{#446142}
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

TBR=rockot@chromium.org, dtrainor@chromium.org, haraken@chromium.org
since the gist of the CL hasn't changed.
    
    Review-Url: https://codereview.chromium.org/2681913003
    Cr-Original-Original-Commit-Position: refs/heads/master@{#450582}
    Review-Url: https://codereview.chromium.org/2753413002
    Cr-Original-Commit-Position: refs/heads/master@{#458010}
    Review-Url: https://codereview.chromium.org/2765723002
    Cr-Commit-Position: refs/heads/master@{#458657}
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
RELAND2: ShapeDetection: use mojom::Bitmap for mojo interface.
    
    Original CL got reverted due to test cases are concurrent in same
    script context, it will cause random crash/time out.
    
    CL [1] has resolved the random issue, so rebase the commit align with
    the latest code. Reland implementation of detecting on mac 
    platform, layout tests files, interface definition in mojom file and
    implementation in /Source/modules/shapedetion. Implementation on
    Android platform is new code include all of java files.
    
    [1] https://chromium-review.googlesource.com/475077
    
    Original CL description ------------------------------------------------
    ShapeDetection: use mojom::Bitmap for mojo interface.
    
    This CL uses mojo::Bitmap for mojo ShapeDetection interfaces definition,
    so that the Detect API is completely flexible and friendly.
    
    BUG=665488
    TEST(Layout)=
    
third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html
    
third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html
    
third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html
    
third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html
    
third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html
     third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html
     third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html
    
    Review-Url: https://codereview.chromium.org/2629433003
    Cr-Commit-Position: refs/heads/master@{#446142}
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

TBR=rockot@chromium.org, dtrainor@chromium.org, haraken@chromium.org
since the gist of the CL hasn't changed.
    

Review-Url: https://codereview.chromium.org/2681913003
Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#450582}
Review-Url: https://codereview.chromium.org/2753413002
Cr-Original-Original-Commit-Position: refs/heads/master@{#458010}
Review-Url: https://codereview.chromium.org/2765723002
Cr-Original-Commit-Position: refs/heads/master@{#458657}
Review-Url: https://codereview.chromium.org/2875243002
Cr-Commit-Position: refs/heads/master@{#476598}
Committed:
https://chromium.googlesource.com/chromium/src/+/31eb1a542aea4050d9b17fd7255d...
==========

[commit-bot: I haz the power, 2017-06-02 07:36:11]

Committed patchset #5 (id:310001) as
https://chromium.googlesource.com/chromium/src/+/31eb1a542aea4050d9b17fd7255d...

[Dirk Pranke, 2017-06-07 19:55:31]

rs- lgtm.