RELAND: ShapeDetection: use mojom::Bitmap for mojo interface.

RELAND: ShapeDetection: use mojom::Bitmap for mojo interface.

Original CL got reverted due to shapedetection/detection-on-worker.html
fail to fetch source for module skia/public/interfaces/bitmap.mojom.

This CL add gen/skia/public/interfaces to generated bindings paths.

Original CL description ------------------------------------------------
ShapeDetection: use mojom::Bitmap for mojo interface.

This CL uses mojo::Bitmap for mojo ShapeDetection interfaces definition,
so that the Detect API is completely flexible and friendly.

BUG=665488
TEST(Layout)=
 third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html
 third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html
 third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html
 third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html
 third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html
 third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html
 third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html

Review-Url: https://codereview.chromium.org/2629433003
Cr-Commit-Position: refs/heads/master@{#446142}
(cherry picked from commit 33adf4c85dd553eb607bcf9c02c5fa60c8738a68)

Conflicts:
	third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp
	third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

TBR=rockot@chromium.org, dtrainor@chromium.org, haraken@chromium.org, bsalomon@google.com, tsepez@chromium.org
since the gist of the CL hasn't changed.

Review-Url: https://codereview.chromium.org/2681913003
Cr-Original-Original-Commit-Position: refs/heads/master@{#450582}
Review-Url: https://codereview.chromium.org/2753413002
Cr-Original-Commit-Position: refs/heads/master@{#458010}
Review-Url: https://codereview.chromium.org/2765723002
Cr-Commit-Position: refs/heads/master@{#458657}
Committed: https://chromium.googlesource.com/chromium/src/+/11a82c3aaabd39fc3a0981a6e66bf870cc46d5e8

[junwei, 2017-03-21 01:20:27]

Patchset #2 (id:20001) has been deleted

[junwei, 2017-03-21 02:59:09]

Patchset #1 (id:1) has been deleted

[junwei, 2017-03-21 02:59:18]

Patchset #1 (id:40001) has been deleted

[junwei, 2017-03-21 03:06:43]

junwei.fu@intel.com changed reviewers:
+ dpranke@chromium.org, mcasas@chromium.org

[junwei, 2017-03-21 03:06:44]

Dirk Pranke@ mcasas@ PTAL. The cl of adding gen/skia/public/interfaces to
generated bindings paths is [1].

[1] https://chromium-review.googlesource.com/c/457267/

[bsalomon_chromium, 2017-03-21 13:24:44]

skia DEPS lgtm

[David Trainor- moved to gerrit, 2017-03-21 16:33:53]

lgtm

[Tom Sepez, 2017-03-21 18:32:49]

mojom LGTM

[Dirk Pranke, 2017-03-21 19:39:57]

lgtm, though really haraken is a better reviewer for this.

[mcasas, 2017-03-21 22:07:34]

On 2017/03/21 19:39:57, Dirk Pranke wrote:
> lgtm, though really haraken is a better reviewer for this.

lgtm since it's essentially the original CL that got reverted.

Also, when I reland several times, I add a number: RELAND 2 etc
(my personal max is RELAND 3).

[junwei, 2017-03-22 00:48:28]

Patchset #2 (id:80001) has been deleted

[junwei, 2017-03-22 00:48:41]

The CQ bit was checked by junwei.fu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 00:49:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[junwei, 2017-03-22 02:08:06]

On 2017/03/21 22:07:34, mcasas wrote:
> On 2017/03/21 19:39:57, Dirk Pranke wrote:
> > lgtm, though really haraken is a better reviewer for this.
> 
> lgtm since it's essentially the original CL that got reverted.
> 
> Also, when I reland several times, I add a number: RELAND 2 etc
> (my personal max is RELAND 3).

Updated the description of commit in Patch set 2.

[commit-bot: I haz the power, 2017-03-22 02:51:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 02:51:14]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't
started yet, builder probably lacks capacity)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_TIMED_OUT,
build hasn't started yet, builder probably lacks capacity)

[junwei, 2017-03-22 02:53:20]

The CQ bit was checked by junwei.fu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 02:54:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[junwei, 2017-03-22 03:05:18]

The CQ bit was checked by junwei.fu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 03:06:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[junwei, 2017-03-22 03:13:20]

Patchset #3 (id:120001) has been deleted

[commit-bot: I haz the power, 2017-03-22 03:22:12]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[haraken, 2017-03-22 04:14:30]

WebKit LGTM

[commit-bot: I haz the power, 2017-03-22 04:55:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 04:55:22]

Dry run: Exceeded global retry quota

[junwei, 2017-03-22 06:08:11]

The CQ bit was checked by junwei.fu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 06:08:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 06:15:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 06:15:18]

Dry run: This issue passed the CQ dry run.

[junwei, 2017-03-22 06:18:41]

The CQ bit was checked by junwei.fu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 06:19:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[junwei, 2017-03-22 06:24:42]

Patchset #3 (id:140001) has been deleted

[junwei, 2017-03-22 06:26:36]

The CQ bit was unchecked by junwei.fu@intel.com

[junwei, 2017-03-22 06:27:19]

The CQ bit was checked by junwei.fu@intel.com

[junwei, 2017-03-22 06:27:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org, dpranke@chromium.org, bsalomon@chromium.org,
mcasas@chromium.org, tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2765723002/#ps100001
(title: "RELAND 2: revert the dependence of skia/public/interfaces in
BUILD.gn.")

[commit-bot: I haz the power, 2017-03-22 06:27:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 07:09:35]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1490164039090410,
"parent_rev": "8c49908782266ac97dd687faf89ad10804db108b", "commit_rev":
"11a82c3aaabd39fc3a0981a6e66bf870cc46d5e8"}

[commit-bot: I haz the power, 2017-03-22 07:10:20]

Description was changed from

==========
RELAND: ShapeDetection: use mojom::Bitmap for mojo interface.

Original CL got reverted due to shapedetection/detection-on-worker.html
fail to fetch source for module skia/public/interfaces/bitmap.mojom.

This CL add gen/skia/public/interfaces to generated bindings paths.

Original CL description ------------------------------------------------
ShapeDetection: use mojom::Bitmap for mojo interface.

This CL uses mojo::Bitmap for mojo ShapeDetection interfaces definition,
so that the Detect API is completely flexible and friendly.

BUG=665488
TEST(Layout)=
 third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html

third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html
 third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html
 third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html
 third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html
 third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html
 third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html

Review-Url: https://codereview.chromium.org/2629433003
Cr-Commit-Position: refs/heads/master@{#446142}
(cherry picked from commit 33adf4c85dd553eb607bcf9c02c5fa60c8738a68)

Conflicts:
	third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp
	third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

TBR=rockot@chromium.org, dtrainor@chromium.org, haraken@chromium.org,
bsalomon@google.com, tsepez@chromium.org
since the gist of the CL hasn't changed.

Review-Url: https://codereview.chromium.org/2681913003
Cr-Original-Commit-Position: refs/heads/master@{#450582}
Review-Url: https://codereview.chromium.org/2753413002
Cr-Commit-Position: refs/heads/master@{#458010}
==========

to

==========
RELAND: ShapeDetection: use mojom::Bitmap for mojo interface.

Original CL got reverted due to shapedetection/detection-on-worker.html
fail to fetch source for module skia/public/interfaces/bitmap.mojom.

This CL add gen/skia/public/interfaces to generated bindings paths.

Original CL description ------------------------------------------------
ShapeDetection: use mojom::Bitmap for mojo interface.

This CL uses mojo::Bitmap for mojo ShapeDetection interfaces definition,
so that the Detect API is completely flexible and friendly.

BUG=665488
TEST(Layout)=
 third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html

third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html
 third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html
 third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html
 third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html
 third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html
 third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html

Review-Url: https://codereview.chromium.org/2629433003
Cr-Commit-Position: refs/heads/master@{#446142}
(cherry picked from commit 33adf4c85dd553eb607bcf9c02c5fa60c8738a68)

Conflicts:
	third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp
	third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

TBR=rockot@chromium.org, dtrainor@chromium.org, haraken@chromium.org,
bsalomon@google.com, tsepez@chromium.org
since the gist of the CL hasn't changed.

Review-Url: https://codereview.chromium.org/2681913003
Cr-Original-Original-Commit-Position: refs/heads/master@{#450582}
Review-Url: https://codereview.chromium.org/2753413002
Cr-Original-Commit-Position: refs/heads/master@{#458010}
Review-Url: https://codereview.chromium.org/2765723002
Cr-Commit-Position: refs/heads/master@{#458657}
Committed:
https://chromium.googlesource.com/chromium/src/+/11a82c3aaabd39fc3a0981a6e66b...
==========

[commit-bot: I haz the power, 2017-03-22 07:10:22]

Committed patchset #2 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/11a82c3aaabd39fc3a0981a6e66b...

[dgozman, 2017-03-22 23:59:20]

A revert of this CL (patchset #2 id:100001) has been created in
https://codereview.chromium.org/2773593002/ by dgozman@chromium.org.

The reason for reverting is: Breaks on MSAN:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linu....

[dgozman, 2017-03-23 00:09:17]

On 2017/03/22 23:59:20, dgozman wrote:
> A revert of this CL (patchset #2 id:100001) has been created in
> https://codereview.chromium.org/2773593002/ by mailto:dgozman@chromium.org.
> 
> The reason for reverting is: Breaks on MSAN:
>
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linu....

Revert failed, so I filed an issue:
https://bugs.chromium.org/p/chromium/issues/detail?id=704360