RELAND: ShapeDetection: use mojom::Bitmap for mojo interface.

RELAND: ShapeDetection: use mojom::Bitmap for mojo interface.

Original CL got reverted due to shapedetection/detection-on-worker.html
fail to fetch source for module skia/public/interfaces/bitmap.mojom.

This CL includes the generated JS bindings for skia/public/interfaces/bitmap.mojom
in the layout tests archive.

Original CL description ------------------------------------------------
ShapeDetection: use mojom::Bitmap for mojo interface.

This CL uses mojo::Bitmap for mojo ShapeDetection interfaces definition,
so that the Detect API is completely flexible and friendly.

BUG=665488
TEST(Layout)=
 third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html
 third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html
 third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html
 third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html
 third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html
 third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html
 third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html

Review-Url: https://codereview.chromium.org/2629433003
Cr-Commit-Position: refs/heads/master@{#446142}
(cherry picked from commit 33adf4c85dd553eb607bcf9c02c5fa60c8738a68)

Conflicts:
	third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp
	third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

TBR=rockot@chromium.org, dtrainor@chromium.org, haraken@chromium.org, bsalomon@google.com, tsepez@chromium.org
since the gist of the CL hasn't changed.

Review-Url: https://codereview.chromium.org/2681913003
Cr-Original-Commit-Position: refs/heads/master@{#450582}
Review-Url: https://codereview.chromium.org/2753413002
Cr-Commit-Position: refs/heads/master@{#458010}
Committed: https://chromium.googlesource.com/chromium/src/+/b1caeee1ee08c8b3bcaa423c8aa4a9f06e9ce40a

[junwei, 2017-03-18 09:47:20]

junwei.fu@intel.com changed reviewers:
+ dpranke@chromium.org, mcasas@chromium.org

[junwei, 2017-03-18 09:47:21]

Dirk Pranke@ mcasas@ PTAL.

[junwei, 2017-03-18 09:48:00]

The CQ bit was checked by junwei.fu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-18 09:48:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-18 09:48:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-18 09:48:06]

Dry run: No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[mcasas, 2017-03-19 20:39:02]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-19 20:39:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dirk Pranke, 2017-03-19 21:10:05]

lgtm

(dunno if you want to use this CL or https://codereview.chromium.org/2681913003/
).

[commit-bot: I haz the power, 2017-03-19 22:11:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-19 22:11:16]

Dry run: This issue passed the CQ dry run.

[mcasas, 2017-03-19 22:37:32]

On 2017/03/19 21:10:05, Dirk Pranke wrote:
> lgtm
> 
> (dunno if you want to use this CL or
https://codereview.chromium.org/2681913003/
> ).

lgtm  - good perseverance!

[mcasas, 2017-03-19 22:40:31]

On 2017/03/19 22:37:32, mcasas wrote:
> On 2017/03/19 21:10:05, Dirk Pranke wrote:
> > lgtm
> > 
> > (dunno if you want to use this CL or
> https://codereview.chromium.org/2681913003/
> > ).
> 
> lgtm  - good perseverance!

Bots are happy - but if you still get some troubles, check
https://codereview.chromium.org/2045573002/  for an 
example of adding the appropriate .mojom to the slave zip
file.

[junwei, 2017-03-20 00:38:30]

The CQ bit was checked by junwei.fu@intel.com

[commit-bot: I haz the power, 2017-03-20 00:38:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 00:45:16]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489970310166030,
"parent_rev": "2a9fb0166f08fecc7b3b68deff1b6523f1610d23", "commit_rev":
"b1caeee1ee08c8b3bcaa423c8aa4a9f06e9ce40a"}

[commit-bot: I haz the power, 2017-03-20 00:46:45]

Description was changed from

==========
RELAND: ShapeDetection: use mojom::Bitmap for mojo interface.

Original CL got reverted due to shapedetection/detection-on-worker.html
fail to fetch source for module skia/public/interfaces/bitmap.mojom.

This CL includes the generated JS bindings for
skia/public/interfaces/bitmap.mojom
in the layout tests archive.

Original CL description ------------------------------------------------
ShapeDetection: use mojom::Bitmap for mojo interface.

This CL uses mojo::Bitmap for mojo ShapeDetection interfaces definition,
so that the Detect API is completely flexible and friendly.

BUG=665488
TEST(Layout)=
 third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html

third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html
 third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html
 third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html
 third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html
 third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html
 third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html

Review-Url: https://codereview.chromium.org/2629433003
Cr-Commit-Position: refs/heads/master@{#446142}
(cherry picked from commit 33adf4c85dd553eb607bcf9c02c5fa60c8738a68)

Conflicts:
	third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp
	third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

TBR=rockot@chromium.org, dtrainor@chromium.org, haraken@chromium.org,
bsalomon@google.com, tsepez@chromium.org
since the gist of the CL hasn't changed.

Review-Url: https://codereview.chromium.org/2681913003
Cr-Commit-Position: refs/heads/master@{#450582}
==========

to

==========
RELAND: ShapeDetection: use mojom::Bitmap for mojo interface.

Original CL got reverted due to shapedetection/detection-on-worker.html
fail to fetch source for module skia/public/interfaces/bitmap.mojom.

This CL includes the generated JS bindings for
skia/public/interfaces/bitmap.mojom
in the layout tests archive.

Original CL description ------------------------------------------------
ShapeDetection: use mojom::Bitmap for mojo interface.

This CL uses mojo::Bitmap for mojo ShapeDetection interfaces definition,
so that the Detect API is completely flexible and friendly.

BUG=665488
TEST(Layout)=
 third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html

third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html
 third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html
 third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html
 third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html
 third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html
 third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html

Review-Url: https://codereview.chromium.org/2629433003
Cr-Commit-Position: refs/heads/master@{#446142}
(cherry picked from commit 33adf4c85dd553eb607bcf9c02c5fa60c8738a68)

Conflicts:
	third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp
	third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

TBR=rockot@chromium.org, dtrainor@chromium.org, haraken@chromium.org,
bsalomon@google.com, tsepez@chromium.org
since the gist of the CL hasn't changed.

Review-Url: https://codereview.chromium.org/2681913003
Cr-Original-Commit-Position: refs/heads/master@{#450582}
Review-Url: https://codereview.chromium.org/2753413002
Cr-Commit-Position: refs/heads/master@{#458010}
Committed:
https://chromium.googlesource.com/chromium/src/+/b1caeee1ee08c8b3bcaa423c8aa4...
==========

[commit-bot: I haz the power, 2017-03-20 00:46:47]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b1caeee1ee08c8b3bcaa423c8aa4...

[vasilii, 2017-03-20 10:19:55]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2755393002/ by vasilii@chromium.org.

The reason for reverting is: Broke shapedetection/detection-on-worker.html
shapedetection/detection-security-test.html reliably:

18:14:35.412 4150  
[10306:39683:0319/181429.446067:1229254778376:WARNING:url_request_job_manager.cc(90)]
Failed to map:
layout-test-mojom://content/shell/renderer/layout_test/frame_interface_registry
18:14:35.413 4150  
[10306:39683:0319/181429.446194:1229254899173:WARNING:url_request_job_manager.cc(90)]
Failed to map:
layout-test-mojom://content/shell/renderer/layout_test/interface_registry
18:14:35.413 4150  
[10308:771:0319/181429.450430:1229259136455:ERROR:mojo_context_state.cc(199)]
Failed to fetch source for module
"content/shell/renderer/layout_test/frame_interface_registry"
18:14:35.413 4150  
[10308:771:0319/181429.450505:1229259209121:ERROR:mojo_context_state.cc(199)]
Failed to fetch source for module
"content/shell/renderer/layout_test/interface_registry"
18:14:35.413 4150  
[10308:771:0319/181429.452582:1229261287723:ERROR:mojo_context_state.cc(199)]
Failed to fetch source for module "skia/public/interfaces/bitmap.mojom"
18:14:35.414 4111 [46631/51882] shapedetection/detection-security-test.html
failed unexpectedly (test timed out).

[junwei, 2017-03-20 11:19:09]

Could you please share the link of try bots so that I can get more information
about the error messages.

发自我的 iPhone
在 2017年3月20日，下午6:20，"vasilii@chromium.org<mailto:vasilii@chromium.org>"
<vasilii@chromium.org<mailto:vasilii@chromium.org>> 写道：

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2755393002/ by
vasilii@chromium.org<mailto:vasilii@chromium.org>.

The reason for reverting is: Broke shapedetection/detection-on-worker.html
shapedetection/detection-security-test.html reliably:

18:14:35.412 4150
[10306:39683:0319/181429.446067:1229254778376:WARNING:url_request_job_manager.cc(90)]
Failed to map:
layout-test-mojom://content/shell/renderer/layout_test/frame_interface_registry
18:14:35.413 4150
[10306:39683:0319/181429.446194:1229254899173:WARNING:url_request_job_manager.cc(90)]
Failed to map:
layout-test-mojom://content/shell/renderer/layout_test/interface_registry
18:14:35.413 4150
[10308:771:0319/181429.450430:1229259136455:ERROR:mojo_context_state.cc(199)]
Failed to fetch source for module
"content/shell/renderer/layout_test/frame_interface_registry"
18:14:35.413 4150
[10308:771:0319/181429.450505:1229259209121:ERROR:mojo_context_state.cc(199)]
Failed to fetch source for module
"content/shell/renderer/layout_test/interface_registry"
18:14:35.413 4150
[10308:771:0319/181429.452582:1229261287723:ERROR:mojo_context_state.cc(199)]
Failed to fetch source for module "skia/public/interfaces/bitmap.mojom"
18:14:35.414 4111 [46631/51882] shapedetection/detection-security-test.html
failed unexpectedly (test timed out).

https://codereview.chromium.org/2753413002/

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[junwei, 2017-03-20 11:19:10]

Could you please share the link of try bots so that I can get more information
about the error messages.

发自我的 iPhone
在 2017年3月20日，下午6:20，"vasilii@chromium.org<mailto:vasilii@chromium.org>"
<vasilii@chromium.org<mailto:vasilii@chromium.org>> 写道：

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2755393002/ by
vasilii@chromium.org<mailto:vasilii@chromium.org>.

The reason for reverting is: Broke shapedetection/detection-on-worker.html
shapedetection/detection-security-test.html reliably:

18:14:35.412 4150
[10306:39683:0319/181429.446067:1229254778376:WARNING:url_request_job_manager.cc(90)]
Failed to map:
layout-test-mojom://content/shell/renderer/layout_test/frame_interface_registry
18:14:35.413 4150
[10306:39683:0319/181429.446194:1229254899173:WARNING:url_request_job_manager.cc(90)]
Failed to map:
layout-test-mojom://content/shell/renderer/layout_test/interface_registry
18:14:35.413 4150
[10308:771:0319/181429.450430:1229259136455:ERROR:mojo_context_state.cc(199)]
Failed to fetch source for module
"content/shell/renderer/layout_test/frame_interface_registry"
18:14:35.413 4150
[10308:771:0319/181429.450505:1229259209121:ERROR:mojo_context_state.cc(199)]
Failed to fetch source for module
"content/shell/renderer/layout_test/interface_registry"
18:14:35.413 4150
[10308:771:0319/181429.452582:1229261287723:ERROR:mojo_context_state.cc(199)]
Failed to fetch source for module "skia/public/interfaces/bitmap.mojom"
18:14:35.414 4111 [46631/51882] shapedetection/detection-security-test.html
failed unexpectedly (test timed out).

https://codereview.chromium.org/2753413002/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.